From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39FC0466B7B for ; Wed, 17 Jun 2026 14:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781707916; cv=none; b=pqvmF/z2wRsQiJsrVvyP6lubo3x4ITXwReEbQNryontFH39lGIijc7Vyxw71rJ2O5EPtFIi6ADhkkH/tNgSpqHkb93IICmo4/Ew2RJ7x/5BS4D9mCA0aqEX4iZdZe6RjHQzJl1ZEe0jFPPpEBxuvY+ShdFQ8ZiPtigUaYNuOuPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781707916; c=relaxed/simple; bh=ekF+EqAqxUIoNHacdJRxFOkqPmHLuXqzXJMGa52578E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=cDEALruIsPTrlKnw2MXkPUys0yVZMqoOgXd4EFVOYEUEDLJw2qcov7PrLDniE7YQ2k5aPi3JNfzitK0oO44Gno0Gp+XlWg5j0DsTn/ggmm6z2zXMg7wuNNsr9O75ervbreNYdXJZL9f3iKVF2DR8KU8oNM9WwGKzfZ6KkRipijE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--sebastianene.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=m+V8PScY; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--sebastianene.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="m+V8PScY" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-490b93debc8so56618535e9.1 for ; Wed, 17 Jun 2026 07:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781707914; x=1782312714; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=y79oPW1dRkbvOFQ/8D6OY6Iq3f4xRjBQw7MgzYvcGaA=; b=m+V8PScYrVf71Q1YDsey36Zd2eT/rt7nHi3GNi2/wlYIdPZjMGDoGJ3AgVws5vRzNG DnifGZkc2AFewIy5HsRMKrF+0/xp0ffYpv5IAPx/5S3SY4j2SNvW1DEqTVpvRfqO1ubk wLfg+5jxG6MFCOFSxQmnOYCr1TIbDyEeTZYKE+pLyxBdqVZNFLgImJmJ6fATHCu1OzfL +nk1CIxkYWy8XDYcWwoUpRfww84G09hjx/j17Yh4y1oeALKCLG9tmyytXvJGttSkQcvr 55GBq9qV57kT++7J3w5m9vD0hz10hr9x1EYY1LmmEXC+SA7xeZeVJqzGT7uD3zNYFs8j mmWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781707914; x=1782312714; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y79oPW1dRkbvOFQ/8D6OY6Iq3f4xRjBQw7MgzYvcGaA=; b=p8kAGA3/jgs6qqE9nroZ1e/bkAfKGFuP/8zwYqY7GLlhrWSx/OXnxCqucmGNHUZ1kF GtlnyvK50Rb6KKEP6jq1+yHw8+/eM/n1NDUOrSboIRt3LZ0QYaf/HDBHhMxkiFnShLBx Yf8OwCLUgsnq2cp6MtvO4mzcOdSYlHpfElinmZ/WfQoXx/6Dc9w0QDxoQRXiYFBiE+IR NO/zFn2RVxTD3UZpqn8fkp+kTXV0G0mqYEvlCR4CUl0G9mtHI5JhPQkgdWgGTlSgkZf+ v/7SmzMB7KRreEh2uu+C6iyKsvBrzA8NJFjSFaun13qGY2TkxRiZSy5qzgWLl3LnEk0H Uvkg== X-Forwarded-Encrypted: i=1; AFNElJ9RqRSJyJiVI8eGFN8F1oeJlMQ3LoUyJlMg7fREEIwaUuKtJlj8HKLOMI7SThWrwa0ZiFF0WnbJh2lCtPc=@vger.kernel.org X-Gm-Message-State: AOJu0YxqOnO2TZAANJNokv6/5wnvBTS3qP3HH3NdJmpKJdMJHha++H8j lU9+4rHFEkCF6rzCGJH99rQtXKoDGm0SCP62X0na18+9sr5dbtxSMmUStc7NGBP+wdSAq6YoC4g KmW3mJ+NiFsVOnJVc/9KoEmzoAUT6fw== X-Received: from wmxb4-n2.prod.google.com ([2002:a05:600d:8444:20b0:490:4477:50d3]) (user=sebastianene job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4743:b0:492:1e36:bb03 with SMTP id 5b1f17b1804b1-492333f829dmr72605705e9.36.1781707912951; Wed, 17 Jun 2026 07:51:52 -0700 (PDT) Date: Wed, 17 Jun 2026 14:51:30 +0000 In-Reply-To: <20260617145130.3729015-1-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260617145130.3729015-1-sebastianene@google.com> X-Mailer: git-send-email 2.54.0.1136.gdb2ca164c4-goog Message-ID: <20260617145130.3729015-8-sebastianene@google.com> Subject: [PATCH v7 7/7] KVM: arm64: Zero out the stack initialized data in the FFA handler From: Sebastian Ene To: catalin.marinas@arm.com, oupton@kernel.org, sudeep.holla@kernel.org, will@kernel.org Cc: jens.wiklander@linaro.org, joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, maz@kernel.org, mrigendra.chaubey@gmail.com, op-tee@lists.trustedfirmware.org, perlarsen@google.com, sebastianene@google.com, seiden@linux.ibm.com, smostafa@google.com, sumit.garg@kernel.org, suzuki.poulose@arm.com, vdonnefort@google.com, yuzenghui@huawei.com, Sashiko AI Content-Type: text/plain; charset="UTF-8" Don't leak hypervisor stack data when using the FFA_VERSION call. When the compiler doesn't support -ftrivial-auto-var-init=zero option we need to zero out the stack initialized variable before returning data to the host caller. Reported-by: Sashiko AI Closes: https://lore.kernel.org/all/20260616160016.C62C81F000E9@smtp.kernel.org/ Fixes: c9c012625e12 ("KVM: arm64: Trap FFA_VERSION host call in pKVM") Signed-off-by: Sebastian Ene --- arch/arm64/kvm/hyp/nvhe/ffa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c index d7c5701d0584..b321682ead04 100644 --- a/arch/arm64/kvm/hyp/nvhe/ffa.c +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c @@ -883,7 +883,7 @@ static void do_ffa_part_get(struct arm_smccc_1_2_regs *res, bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) { - struct arm_smccc_1_2_regs res; + struct arm_smccc_1_2_regs res = {0}; /* * There's no way we can tell what a non-standard SMC call might -- 2.54.0.1136.gdb2ca164c4-goog