From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E45849552F for ; Wed, 17 Jun 2026 15:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781708677; cv=none; b=h/WlNGQio8yUapTcfxwR2yh2tfo8wI+Gj7s8AznU5JWD0pWkMxcbqabCdiawhzJ7cdvhShmQeyG3Jm3++WGLjvuKHrUNoFAToW3E76eNd+pyPkpmwYeCbnLGyLD9x7U8nIV/M2QB5g8ByF4dR/9yJv1/FkGPWbmOe5oXSGPhDPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781708677; c=relaxed/simple; bh=L4IGNbM7y1d+TqDRCJgF9JoD/da1bj3QcNTtav1CsvA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dv9TrAsT6os1e+fOSRO5r1VwrrerE6tpZt2g9gocwyso0i9EGVhsGF3ozHKyetRbP5nOItFbNEP/TmzMvdSNc4g2X2f2ZBAVzs8a7F4qKqjfWnoYG1NvqmoNG+L//EKe3e+13VfPJm+2PnaSHwkAip8k/6W7SzpW2j6EICV2yC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IrQzabwD; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IrQzabwD" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-660e9fe3c3aso3479009d50.2 for ; Wed, 17 Jun 2026 08:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781708675; x=1782313475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xutruK5RfR43rmAYdiUjHl9bnTWIPbtUF5GMeFFCbOs=; b=IrQzabwDdjP/XSrF1UzgLR98QrrXIk6QOn/E4saD/PKeIOnfwG5m8jAUp1duu9GG9k hE1fkc86Ci47h47pan6WmKcg1umiteAThOtfJbAYU+EnVXSAgFXyVS5gYz7R3qs97P+i nD9lVeqxHQetZ02L04ijWv32GVU2e9cYkq/55awdrxwmJ64+yh7NrkOPJihgEHUqSj+d e4u7zJfRiQETa6Xedf6VUcJvmxI5Dp0CqjzuKymTb67NWxnCT2e1/5zjPc4Cmx9vFvX0 tcRyo6paPocm8/y9/n5GQIIgWmvy78Jt8/CS3cOwWNpdsnNJeE14H99Nazuya7FzLUYG rjjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781708675; x=1782313475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xutruK5RfR43rmAYdiUjHl9bnTWIPbtUF5GMeFFCbOs=; b=OeeO2i756mHUqxXtiih8gzKKWJ/wXZIpKA6ikqjB5Cy/9Ar4m20YsR0cgO+iDQ+z6M fO3/+eJgANJC1ubGRZZH5KzryOhZcYfPb4EGylAhlsJctJ1kmPbfhtxwJO20fgnFgE6m 7S6rE5/Jn9OwjbHoHNwTUC670HJPQ+987Hh7pa3EMUVqVDrvkznq1Bo1clFYRcoiQTzd QEwuA0RdDy9aZBk7EWxC/6HHuxx8sbl5mzLxtt+Wa2YksRgBrY563tMjVrBM4IPTLbRT e0lvdEQ1vVOsPzv2UwgxpDpwO1Q+DuMs4I5PBi1Z218C++1wbB6b9FwP+P0qWeDAoQhz SKfQ== X-Forwarded-Encrypted: i=1; AFNElJ91bmRJ52hBVG8AWK2PGbwo01HW5PNCADr7+t8JPt/Gf/HaEgWrg4nhTp++TpL/Foru05YwxoKSf9L+alw=@vger.kernel.org X-Gm-Message-State: AOJu0YxmyiJJbSmqTsLSMhbky6UfoajuC9e3Ht9IQcshW9hAua4bV7p+ u4Guw7/e+AzMZvDzHODp5SdSqxAKnldz4tjvJ0G7d0BecSAayxOKODWX X-Gm-Gg: AfdE7cllYM0SD1qsAD3DrqgYCJwWwdiaBAFgDhOw5Px83nyQxcmN1LaJEBE5yiT4lp1 2UAyD1E2oxyDFyTHhdUBKWovTWqNAUPYg4E2h1U+VcC++mtUqGDNEKL+38VHvEQvB+AXlvDxIL9 TaJvektSPfOWXFCv7XKE8cpMjRRXEEK+8/IH50AbPbJshWuIHoMQnJ4ZFip7XxrmcqrEYpqIUoq LALCnHAiIXUuz28nerAsnp8ID5OAg4hdkINbxnonhFBDMfkKknMI718P31lSf/5Trm3+SPe4DFH Jw2OpcfgsidZ4cM/9kC7Sjrfxbxaz42iNkgO6Wylf67OTg4e3v5HFOroDhxZ8W0PJ2nn0+vnqzo E1J/8mHhEHTILhg6VdDdGnXiJoOL9st8nYWmYdEsiH7bYNfOE1rCgnvoAlK27XEEwSaGL8fo9AM SszYJuyLOFiA== X-Received: by 2002:a53:a94a:0:b0:660:eaa4:5c17 with SMTP id 956f58d0204a3-662cb8494d9mr2924093d50.2.1781708613613; Wed, 17 Jun 2026 08:03:33 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:c491::1002]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-662b976e47csm4387677d50.20.2026.06.17.08.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 08:03:33 -0700 (PDT) From: Jun Yan To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jun Yan , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 01/10] Input: cap11xx - clean up duplicate log and add probe error logs Date: Wed, 17 Jun 2026 23:02:40 +0800 Message-ID: <20260617150318.753148-2-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260617150318.753148-1-jerrysteve1101@gmail.com> References: <20260617150318.753148-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Duplicated device detection log exists at line 537 and line 542, which brings redundant kernel print messages. Drop one redundant log entry to clean up dmesg output. Meanwhile add missing error logs when I2C communication fails during driver probe(), helping debug. Signed-off-by: Jun Yan --- drivers/input/keyboard/cap11xx.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c index 2447c1ae2166..485d8ba97723 100644 --- a/drivers/input/keyboard/cap11xx.c +++ b/drivers/input/keyboard/cap11xx.c @@ -512,7 +512,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) error = regmap_read(priv->regmap, CAP11XX_REG_PRODUCT_ID, &val); if (error) - return error; + return dev_err_probe(dev, error, "Failed to read product ID\n"); if (val != cap->product_id) { dev_err(dev, "Product ID: Got 0x%02x, expected 0x%02x\n", @@ -522,7 +522,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) error = regmap_read(priv->regmap, CAP11XX_REG_MANUFACTURER_ID, &val); if (error) - return error; + return dev_err_probe(dev, error, "Failed to read manufacturer ID\n"); if (val != CAP11XX_MANUFACTURER_ID) { dev_err(dev, "Manufacturer ID: Got 0x%02x, expected 0x%02x\n", @@ -531,11 +531,8 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) } error = regmap_read(priv->regmap, CAP11XX_REG_REVISION, &rev); - if (error < 0) - return error; - - dev_info(dev, "CAP11XX detected, model %s, revision 0x%02x\n", - id->name, rev); + if (error) + return dev_err_probe(dev, error, "Failed to read revision\n"); priv->model = cap; -- 2.54.0