From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2B1C31F981 for ; Wed, 17 Jun 2026 18:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781720517; cv=none; b=ptadWKFs+9IsL7SNqZIvKl8LNWob8vNsqu7wTDcQkuccuOJn469jiGVAQ6zxhyT5UW9HVaQuGW1dsj6BZGcftjgHuTG+eKYYm1BSMKcdYaEY0BnlQ4NJOe09Ze5ZltrN9AoKKaSWX4fERzTAz5mETR2MnWnGhR7gPGPwUZcYQik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781720517; c=relaxed/simple; bh=YH8ddk1uOZv5MsVhQHXZldbqbgDr8aDpn69KDbJKBXo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=tRE9IGUpYss2ddp9kNvPMIdZnrD38V87ZSOg0dMm8FmRZW2PyrIcZVAhX8XSazu1Gh5ATIiHwslR/QtEfTiAh1yhNIuW1bJlSq2ayzNOI4JAsCegWwcPdeHkzEOPY3a4siPM/gQLSjOvesF4jWcSbWP3845aRar+lxK9AkySO5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TOSta2CX; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TOSta2CX" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-30b9e755555so205259eec.1 for ; Wed, 17 Jun 2026 11:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781720516; x=1782325316; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=0iYXs1cU5u1YpR2ayFZC3+vq4V6UqvGux+DRBVroafs=; b=TOSta2CXuLwsYmh6xziVhj38C1zG1onTFN6LbYI3UifLpOO1UxdssTRCfIrMFal4dG BDBx8SNGVw1ZiE90pGVE+Vva9w0uqr4ErWqjhwZq0gDMwKDekbM8xIuTwF3bLAOGxLMa R18RRZpyF308Bz/NmRWoZ6OJ22caKrZFSTi2r3b70fAaFY92T6C6Awk8pJl+yZ9SS9T/ hW2ZKvDBPDzfoW0JppzADBKFXE831RtS6j2FoV8L6OXxe4vXK2AdBJVxQfoQKj3E9JAz UQkPSTKibANZCsXksswylynXTpVkmxlSsFjiAYUq9TswofOLM0XVe+zA9rLpS2ZHLf7Z LmcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781720516; x=1782325316; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0iYXs1cU5u1YpR2ayFZC3+vq4V6UqvGux+DRBVroafs=; b=LRGfv2fYnOY7y0ZiP9Xa4OEys/53P5Ry6og+F/UqnuwRt6xsEraoE1kipKixzMqmhT d0q9WLxm/Sv7hmSPTxJCzSq9PNVhP103ufkya07qyuBwfaJG5xL0PD8pGblE25/pfKH0 VRuToIbv54VBlypCljtXYKCtgfqDBU+apyvi+JjCnfyshic/kpyW2vOC5dWs2UXl6ehI l1zkocMmNrtXsqALa34ONi9DlpRoC3+00Ez8X1JwTDpY7yhkwidWQExU9CZbB7mOWN9Z RCmOVhvhIDMRfnsM1unVaOV7zRmPbQsS3Rtz182I9to/OQnNndpDgt9srQjk7M4uKauP nA2Q== X-Forwarded-Encrypted: i=1; AFNElJ+qQqrf58bu5r5tAs6kI2E6aoQyHSz9JsLkEvcjehxlLZiojUpWqc3kx+oL3CrPcYxc5hHme/y3fAv0fhc=@vger.kernel.org X-Gm-Message-State: AOJu0YzaVO9vu1yxbE6QKN8Lco02Nj5zouTvpD0fZaE8YrCtkGuCJKoq 8pxlsItwcf4r73NOkz+sgnANHm0+MEHPhM64VFE8uQV+249h33DsxGzYP1AN3e3nPcI= X-Gm-Gg: AfdE7cmMJd1AyAL9Ch6Nt/QkQRz3ReVb8uO7/3v4ZCTj+z0irL2QGNJNw+fxHzHTWom Gzf+mIw0wrP9+sxopM6pXfyxczJPsKMNkK25n3xybTNhIHSQBnEl644X2FHsHIkiBxEuQVwOUJz ja6+Xps5RKlBkDUTrXfnjwERwix7Y1417wjhXjOpcA6MKVhdfogmnM4sQWwBo8Na667dWj8RH1S FcUh6o0/ztGDzG2soaTLTmJSUb5ZIzRYe0cXLskVFroF7cjstdk2oSYbeB9mBLVxTXxv8AhkzU9 mmNiqhFWR6Zo7Wic6/2MtImqpk1r6O2mI6axNr59YdZpdhN2kY7wPQuUvzJ+dO3IcAKd70br7Ki oDuts478RC7hTFcM7lGQRW0w7H2yl+pa9A8FoOwzphWORa/DHGHpz/RtmaTE8HE7rTPKrBOeLzJ Ws1gEBwKUD/Y7oJbMoIbX8W+UVj5OnUrDy X-Received: by 2002:a05:7300:6cab:b0:30b:e3c7:27f0 with SMTP id 5a478bee46e88-30bf078f484mr61879eec.13.1781720515950; Wed, 17 Jun 2026 11:21:55 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1886:6b7a:3e78:272c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081eb9a2e7sm23479792eec.30.2026.06.17.11.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 11:21:55 -0700 (PDT) From: Ruoyu Wang To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: qcom: q6apm: initialize graph refcount before publishing Date: Thu, 18 Jun 2026 02:21:50 +0800 Message-ID: <20260617182150.959983-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit q6apm_get_audioreach_graph() inserts a newly allocated graph into graph_idr before initializing its refcount. Another caller looking up the same graph id can find the graph and call kref_get() before kref_init(). Initialize the refcount before publishing the graph in the IDR. Signed-off-by: Ruoyu Wang --- sound/soc/qcom/qdsp6/q6apm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 2e5b25b8d00fd..1953e8ca8777b 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -65,6 +65,7 @@ static struct audioreach_graph *q6apm_get_audioreach_graph(struct q6apm *apm, ui graph->apm = apm; graph->info = info; graph->id = graph_id; + kref_init(&graph->refcount); graph->graph = audioreach_alloc_graph_pkt(apm, info); if (IS_ERR(graph->graph)) { @@ -85,8 +86,6 @@ static struct audioreach_graph *q6apm_get_audioreach_graph(struct q6apm *apm, ui } mutex_unlock(&apm->lock); - kref_init(&graph->refcount); - q6apm_send_cmd_sync(apm, graph->graph, 0); return graph; -- 2.51.0