From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6BD339872 for ; Wed, 17 Jun 2026 18:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781720542; cv=none; b=UuHYscpyAyyIFC1Pa+25clmJBKEmIra+yVHOR4yShxa6gfyIXoEmCgG9f8RXtV8iR5uPDXEq2x3gHx7CSsDlFeMiBco56x6PritY00AaBF0e3wIaV7oOqy9JipkcybCgGFaYWF1b3bsCdA803yNi2kQhFbmN557ztlg53FmD2Lg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781720542; c=relaxed/simple; bh=7u7EzRuUYvbMZj8ZaGRw0TrDTGp/q+KebVWIUaH9cxs=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=vEgUGbPZ80B4UQkyY0iG18JVXWgnKMtUKtwEwiyhQNsUdoDC59lKYC4Oo3//ocyry68E5NZkRHD9AH43SqGccPXw7T4NZLOT8wUG+YgBYgkkvSPd+N90jRxHAleZVJHcfZD4KyYxRtCZjqe1wHkmt5/oGrsES/QjcP9+H5O9tf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OuarVTV3; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuarVTV3" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-30bcc877b4cso245697eec.0 for ; Wed, 17 Jun 2026 11:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781720540; x=1782325340; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=MgCzcqH4IWNrKDybpVLEd1w34Hk1jlKkTZczYza9DXM=; b=OuarVTV30uLnql0rNoZlL18biRvNZn6ytn+q7R0Ym+al2xAG8Rw78nzzMmcrPEv9ao oWNoQPqTlvuZCpOJJL8irWe2u8YpdQvvwI6elVv9veacFoaxNWPKBqJ28YcX+bZCd6bj Em9jgu1pEEFABJ+YcwFR+peiNN0bvaDs7BK4xFHxBPykcsc+j0C5ICm28uo2FIqOG0v1 C9i9/9BN9ffgWktWsUEL/aNHhvMolbgppqv/XGrGoPxeYZyWlaP9Fg0slMR3p1XQPT69 125qbC9v1pbC/BxqK/ud0AcPL9osEfzyK2uVtNQXS7R4IaOBF+fHZPKft/Zre5ydFfEG K1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781720540; x=1782325340; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MgCzcqH4IWNrKDybpVLEd1w34Hk1jlKkTZczYza9DXM=; b=To9Gn625kjDMEwglaImbtY0lNOHTUcJRTOtuO/qwttFprCzQUmc2sQJeDk3+fp4fJz LvGHHftPecbOW0Dbp3Ft9hkNqPu+AVVD2zJP+tw4CK3sqK0k1izscPdPulpO0HaO03m2 EsmRaOOq8u5zqMZpm9JJOxTc8TFCoAu+3JFNLpHZ5txezcy/AvQyUMZMdN0+mV3k7jyf W0LhZS+tO0Q8+ughGlz83j0R1c09x/3T1KGvkL2WmgQY0wSgeGzIAxDAqTgGPMpu/zev zOz2PHvBLvn3NFZzDC4ZLJUsDDXsSyvJiqy32nJHvxuIfO/fGQxwF5Z/nZEqY2rxiBfR +zaw== X-Forwarded-Encrypted: i=1; AFNElJ83ySPrwefvYxJVsLykF9J3kiAMeE/yb8uLI6qUDyYUj0MmRUhuZGNkCnoHdESJzxolXbv+W1tvRuSIOVA=@vger.kernel.org X-Gm-Message-State: AOJu0YzCuRE7xcDef1uN0IFtRPEpDAw06jCbbYp1L/pFonFHckeYJQJa 1hSZhARo2spAJPth+VYAEhdn1vsenmKNWBMxOixekk/NSv2ji0hrAMpa X-Gm-Gg: AfdE7cnmdSWgH9nB47KrpDxOS7k9kVBb9Cfe8R2DoG4/4znUg5UU4iy3+33Krhjx8i3 q/oEPmrwGr5WeGGbtcmXp3KCMVaagAZcp7lpxIL4ISGGZpmm+vDScHSDOPrFmgvsonuMiMhsmqm nHxAB56OlFGHKAQo7/THY14OrZtxDngN7UwLM+Omh9DPr7z48/5JMvRtkDOVLC7pSnDiSXPXGRx 0i8iwGWmLfsP5DIkH9RRZUVXy2lL2ckz0yMBs0Yr8jBImyIA+6ysV4PEgvIo0PW4hbp7T4LXFd9 ZSAofOW0G/3tR2cdx2bHI+/Bui9LhYWXrOPDL0gWbGweyZj4BY0ST5GYPvrV76qow03BvKbdnjm 7p9l50NUjlRM1CuP6DXhIAW6QV1jckhho+9dqMQirB6P1BubMeCpUvnBQ9pVDJFjCbh6icJkbMO RsJFe/r/SZq7L4JZa0Yy2wnURAscMz+yeM X-Received: by 2002:a05:7300:230f:b0:2c5:b23e:48a6 with SMTP id 5a478bee46e88-30bf099f8c6mr30944eec.23.1781720540523; Wed, 17 Jun 2026 11:22:20 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1886:6b7a:3e78:272c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081ddaf69asm24724030eec.0.2026.06.17.11.22.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 11:22:20 -0700 (PDT) From: Ruoyu Wang To: Taras Chornyi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: prestera: initialize err in prestera_port_sfp_bind Date: Thu, 18 Jun 2026 02:22:14 +0800 Message-ID: <20260617182214.963694-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit prestera_port_sfp_bind() returns err after walking the ports node. If no child node matches the port's front-panel id, err is never assigned. Initialize it to 0 so the no-match path does not return stack data. Signed-off-by: Ruoyu Wang --- drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 41e19e9ad28d4..a82e7a8029851 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -373,7 +373,7 @@ static int prestera_port_sfp_bind(struct prestera_port *port) struct device_node *ports, *node; struct fwnode_handle *fwnode; struct phylink *phy_link; - int err; + int err = 0; if (!sw->np) return 0; -- 2.51.0