From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A6D2F6920 for ; Wed, 17 Jun 2026 18:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781721464; cv=none; b=uDSb0elEgoiUGVseOXOTsUpQPJLzKdUoVHJ1wmN/XA5HKcKx8Y04qGYIb4iEw8DISDpVF67jj/u3JeIR5DYUG1vRa5ajM6Gmg5Lor2xl5o07veB4l66DMZXizg6rbhci8ZYQCdLyAPD2MKJsfKF9w+S6KuemSG5a5PVVndNb0gM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781721464; c=relaxed/simple; bh=JHqsBFFKqcEE2tI31FypwpXdCMqVE07bXo/uWbRYT9A=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Wx2MWhDbTwWDbjBrxR+p3LqoZRecAZxo1gdRAdtQalt+I8G4cJ5qqoNdUbnmh4ubxKv9dDWt6+F0gKo86bA9W9BpcN3uFOyqXcVhIyz0DuILnSsZPf3XeGMsbf8r8PSdzjY+VukXO+POXevoz3BlPhQMJUeydjOoNL6C+1ym9fA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XEiylH2T; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XEiylH2T" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8422f395a4aso51668b3a.0 for ; Wed, 17 Jun 2026 11:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781721463; x=1782326263; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HBTeI2fu2gLidQ2w1YzFRkzMgZ3dP5HPVmfeBg+Z4uc=; b=XEiylH2TGFq0GmWDgQy2B/aIMTiovPhX/nQ0g+0PKb93yB2vU9SPJSxIl1oJQ0Vafe AW/l1WHspSwqW3xTOS7/O0bVGyIWXEPgyMvqYKGSPjSbeVoSR2KsaeF9a/9x0zAIZ0eM y+qvsSXqPCFBlN1E+Q2O4JNZeRnaUbAVMdE2SQIwrMS/X9um6YetwqT/QJ0Uicl5yWZB wI1/nPV8K+Dzkw0u05gRv+AzLJe42xHbEl1g0n27PMFU0yF0VkMXybdz89t+h49404VD BszLekNP9eVjGal9FOcAfvPUlyvhjmSnrJcQNscEo0dHEEAZCBpyNh1JOtqkdw/CDuNJ iXEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781721463; x=1782326263; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HBTeI2fu2gLidQ2w1YzFRkzMgZ3dP5HPVmfeBg+Z4uc=; b=Y0CYeh65Pe39psdKIoWZZALsQLF4j2P9bbhC/DyG/RvrQ3gs/uNhqHpiKFEFOoUXru qgsHsV3v+TOK1CUeBeBuu95xTFKV5fshFCHqZ7PYG9Kj8VdJOHETSKBbbED4uRCXg2JI d4ucAILLcdUk9xOja3dokcS/ECL0XlUeEq+5RAqlhev7dMY3JH9Gi5SlfvDgUnLaT2Gq 778RDSLvnq0Op/6aHKZf0HqnNgyZO/7CZNUKK5fdyWD1L0i6JUo/imXvG+tWAq/fNQAo qjT2yhrZs1ya10mY4sedojf79iXI1FbsMmscdkGofSMPqWB1n4qJXbSnfYrsztTmjJEy s+sA== X-Forwarded-Encrypted: i=1; AFNElJ8x2Uw+Iv8Y5wUKZNI+/tiBIe8Zw71rhMzgEgTIIl8Aq5oUXCUuiiY1MKNtnZoWT8Aqg0ZHdCtjcr+/KwY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc27wNipS8Q/xfm/IpPMmFI3tdbRB0sZOR16tCASvLuD0t5GGR ckIRekZzioFRwLKOnojIiGBZIL+/vRkTgiEN/ZlXNNeclK5oDdZZzI9m X-Gm-Gg: Acq92OE4VRFsjgZKf2O8KomM+L4repb1E4ZmPbzKehkvq3DhJK/dgi+9y17VlRi0iQy KFyiHEvag+LQZRGMff3354gOIbMZlTbmYfWa6NvWWOLrnjTrDQwhggg4F0NKB+xPDGF8ezANqre GrxBHlTcHNgoEKwJdQdoQ7ZfUoUJU1VE3yXz8k7z1abtxsUKl6XAi0rJkrTzRyvBh1r8PgWeqvg MSLt57wu6kd8UcwG/1RmBn8Y5pTQqCQ7MYExctRLNT6kMbEJFgcF2SKotkeeCwiRE7LnKgHTAMp SPuW9pMtKgMoql9SYMVwlAWwrhbCaSs/VfWHeD9yg4N45UMb1nyDV7ysRyKLwpzdCdpG01PE74T hGCtrKuTTbRnvjWuGWo3L2jDn4GXoOUC1Cb9FLCNMXZnKvYaYx8O1xjYYlq36fFdXxWXvbZHRj0 3ax14Of00U0sTx/zgOhSu/ivCtPqnMmupo X-Received: by 2002:a05:6a00:138b:b0:7e8:3fcb:9b03 with SMTP id d2e1a72fcca58-84539561caamr527712b3a.25.1781721463031; Wed, 17 Jun 2026 11:37:43 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1886:6b7a:3e78:272c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434accae18sm17380924b3a.17.2026.06.17.11.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 11:37:42 -0700 (PDT) From: Ruoyu Wang To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu: initialize ret in UMC error record fill Date: Thu, 18 Jun 2026 02:37:37 +0800 Message-ID: <20260617183737.1101458-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit umc_v12_0_fill_error_record() returns ret after walking the pages reported by amdgpu_umc_lookup_bad_pages_in_a_row(). That helper can return zero, including when its temporary allocation fails, leaving the loop skipped and ret uninitialized. Initialize ret to 0 so the zero-page path reports a deterministic status instead of returning stack data. Signed-off-by: Ruoyu Wang --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c index 14092150336a5..77a9f6a47d428 100644 --- a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c +++ b/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c @@ -681,7 +681,7 @@ static int umc_v12_0_fill_error_record(struct amdgpu_device *adev, { struct ras_err_data *err_data = (struct ras_err_data *)ras_error_status; uint64_t page_pfn[UMC_V12_0_BAD_PAGE_NUM_PER_CHANNEL]; - int ret, i, count; + int ret = 0, i, count; if (!err_data || !ecc_err) return -EINVAL; -- 2.51.0