From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1825335E95E for ; Wed, 17 Jun 2026 19:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781724757; cv=none; b=oRUNzmAmgbFrAWPVWNqIJy3Fus1Xy7nwBsh9P0120Mp7TT0WWTQRpngb0625x3jUg/zPKdO3P/JlvwwcY4EjM/uiy39O+mMgcuos7SHRTOKax0UVfNFRlG3IZHQowtU9ItDez/29PHWUFtbZNkntBMJdlT4HGFRzoAZTLn9WgKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781724757; c=relaxed/simple; bh=nKRdkhzwzEm90owcL3p24QS4bGL3H7hAHBUqc1YKGsQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=MV49+YClPqvBffFtFLaGEGdU42Zq+yxdxrsQV3qRLOeV/qpFME2o5Glx0ESkRLtLKKEZXLFllcA1yZwz1dsXfBEx7GJmdCqcXy3YjygnxJZLi+tYddKYrAkMnlGxVaLLXYmHYbWvtCPdfwG8bNnwkm6POpB/YgUsehcXBa2yG8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pje5s1iR; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pje5s1iR" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2c168baac83so837245ad.2 for ; Wed, 17 Jun 2026 12:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781724755; x=1782329555; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=e6f2LzXtdnvpe92q5bjdHaZ0Bfv9oZUQy+JVLYIcGw0=; b=pje5s1iR5L/lSOz1aEqkfY8eUXAHRo7GJja5keHLtvkp1XqE7vyU0qSOunUiC6cCUZ iJPgy4YyKkGmMIIu0BkV7fdx33iaifwDl4/3FTQ0dNy5MoOQ7TErKLZKk1CZbWBap0+Y eluQlICvWhs2OVHxCqKK06eMDb/QGDIh2gYWyCZWJsGO/PgmcZmI40imI97/9lJzMJux oSu9k5v9qe0u/GdPqTi0acRi8e35DD9tip9lVko/EGFjCCzeeeC1PA9PyJyHF4XAvq8h 0pUoit+mU208xCe0UBXkUA60GQiP3KbsKMD44x37ItDWCbJeUrUd+ZKeQLTevqivNjGA h21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781724755; x=1782329555; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e6f2LzXtdnvpe92q5bjdHaZ0Bfv9oZUQy+JVLYIcGw0=; b=IXooqzghjk8Llzz3/MH6m/vp5eYQYtXhWXPdTL3dgudodu3ExDMLR5yIVWKQ8x8YqT 2hdi+F3m/uOvZ8RU0F4mXCSqqwUfPUC6Eo4WOPDTOeDWuh7+255+G/xwm8a+wcfb9wXe Db3q0+C/klG3Bjnw+6ZkV7gU1iPWapMWI4n+glNsU6Vvn81z8PpBu3Pc3aWyfFBPBU0A n/FjFsAznI3nb37oGuJgJi6d8wvs+KnHR8AwLM57RK6SOpT2Gat+vJzS3KSzTL1U6jTu gYyaEBsq/0Un9rSkCJuTjHCGRNdfOnvYXgswF3h8pKv2ztbleyJB5lj5br3wigtmqn1M y2cA== X-Forwarded-Encrypted: i=1; AFNElJ8w26BzFhiWDs4hZCvV/SiTeV80yE3G7e3staeS/F/uNmvn6zE4l/7GQ7o6YkFiAolUA062rPhGRtSRAIc=@vger.kernel.org X-Gm-Message-State: AOJu0Yytw3bfTYkEvHhxRVPYWoe7wdiKdvHKDuLSaFI6G8MdX4F3w3RA Dr8gI7Hl8yPxB1tGkoYGWi77S5BxkvL7m8RMzIfwoExNCV8TPJq6Ffpq X-Gm-Gg: AfdE7cmCzHL53YoRGWNzcfgE4PNzsYshvjTWdhSwI80oBbJhstu4WSDXeAN20xFn0il Ja12HsTdxnEUDnYOO2Q47CmHBIzf9hLbFVAK9kEDOHYdKLaGoNUHAvZZ7+6nZ6erhwrs8nwJ+JI LUW95A5PPt8SfTVr3zPG/1OUpyKUxxUSc7DrrugmKkltyTW4jOz+romvLEmcewzPsB6xLeMuT/u D3IpVq/dkR8W25Vn+lRUzWJ0U6aUwQmHVYjkan3h//ykgJS/IhDt/KGa1Gx57082EAISnGKgYMI sm7vInft48/CChxPfIHW/ibWt46Exjrd/c1oaJ1+AVRUro7IuDYRBq7Q4s33A2ZVqJC1uEzoWs3 f8P3TOa3nBtuQI7vKGC8pLQZwFLWYf+Ly3cVmOf8GDrkul1H2kWky+DRnkaSN+OUvgR+4SrvlK7 yVqea5cpzzmIQJy0kWEfipb4iFX3kA1eCK X-Received: by 2002:a17:903:2b0f:b0:2c6:6424:c79f with SMTP id d9443c01a7336-2c6bbf98e47mr55775115ad.8.1781724755407; Wed, 17 Jun 2026 12:32:35 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1886:6b7a:3e78:272c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c432f77479sm173007915ad.63.2026.06.17.12.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 12:32:35 -0700 (PDT) From: Ruoyu Wang To: Taras Chornyi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Oleksandr Mazur , Yevhen Orlov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2] net: marvell: prestera: initialize err in prestera_port_sfp_bind Date: Thu, 18 Jun 2026 03:32:28 +0800 Message-ID: <20260617193228.1653582-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit prestera_port_sfp_bind() returns err after walking the ports node. If no child node matches the port's front-panel id, err is never assigned. Initialize err to 0 because absence of a matching optional port device tree node is not an error. In that case no phylink is created and port creation should continue with port->phy_link left NULL. Errors from malformed matched nodes and phylink_create() still propagate. Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support") Signed-off-by: Ruoyu Wang --- v2: - Add net tree target to the subject. - Explain why the no-match path returns 0 instead of -ENODEV. drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 41e19e9ad28d4..a82e7a8029851 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -373,7 +373,7 @@ static int prestera_port_sfp_bind(struct prestera_port *port) struct device_node *ports, *node; struct fwnode_handle *fwnode; struct phylink *phy_link; - int err; + int err = 0; if (!sw->np) return 0; -- 2.51.0