From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4519035E95E for ; Wed, 17 Jun 2026 19:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781724827; cv=none; b=ZCcKV41hPGKSZ87wOFSSUThJZeG4+8D8+IUSvPEQmH7r+Cn9+lLLl4F+XfvYTJYIJHEFBw9YyurIawi7b5ynXsE2AcgSNl7v83+A0rANaDJNII1nWb0OkkohVduCJkT4E2FRuQzP5is1lpz7gKusU/ivLCF+GApkNTCNv1YQIbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781724827; c=relaxed/simple; bh=YIFtvxbBAsR+MWwz0fHvf+bw8NHPHW0bRBmmLkWreqo=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Mg9TKnWH1lgYu9YjFyCWPsPx2DBVaZ36IhYoTNK182MiidFjbtAZm2RFR+TmYDygbKmZVbWg9NSVf/G1t4c7J2I5d8rnYImD1je+hsX3gwiCs1H5QLMCjJSkHHu0OABrRfRojsj4kpQ2T6pq5ZmwqdFD/vnp93D+/cJTE16bgPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f7PN3ZuS; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f7PN3ZuS" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2c40397e3caso1973875ad.2 for ; Wed, 17 Jun 2026 12:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781724826; x=1782329626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=iQZtMnehaDPaW/1htcuGu1b4iDiFaXM/HgU9tJx9XaY=; b=f7PN3ZuSlQ5SFAZvRoEf8bxC4MNAd80KH4MqTIykHcsYTXN93gyxl+Rrj+R9uwuohM eTZ1Pyy1FiOoHMuPCMBDZsaJXUfKHsGO0mvzBGWIgb2PnoUo5FeeyjFrE1l8EPpCRoRK UiBz2idGz56rw3FvsHEMJOG4oPZZG+chPpRLYRu/xZeiuMqg2gG02dfsH1VEP7Q6PidT JD/tz6L67wcBrTzpx3s7/V3d6AFD7v/0Qev8uAchsAKqq067+RkaJouKAA7FII8oq2OD e3NvAFTfAVzwjPXpo4CN52Vxvb81x/mKmqhmrCl63xmmXEWLJxfJmDxoRmceWAaTk+Cc Iw5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781724826; x=1782329626; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iQZtMnehaDPaW/1htcuGu1b4iDiFaXM/HgU9tJx9XaY=; b=kgmUa0m14xtFteIGL4n0mKYoP0bgLI7aPkX/1z92OaG6r62UFQbJXegV8AnAonDxjL dhDjvk9BqbNlMC9RESz1cI/E2c8lLhylmKuHY0+JtX/1R0aI2Rdr/4/TIefqT5ToOBfO uVsiDG68wYfi/fdlS6gTUHx8SvDBtgYgHOY5dZMU0AY9vwqJxsdcNahPExVz//yMAnzd V672EBNx7H6b0fi0E9rdHYuhNpI+3YJNYi1aAPD8K3o3LPT9cVk4idJD09m+yxawLdhA pM8XQiiElnPb23TVa/T2syTcDBtY1NhUSBf3n5B4ZgDV+g1700ItnSxxIOSbaap0yaGX oUvA== X-Forwarded-Encrypted: i=1; AFNElJ/V0vkPV7MZwO8wh0upUbqBpl/fCxVi1u7ccV+A7FQOE5Lc49jDyUS39LR7B2jM/SrD2sCoGFYr6pJt8LA=@vger.kernel.org X-Gm-Message-State: AOJu0YyaObL4MCIMiP+FmFhdF8Gjlsi6MOrCmGVUram0gh21/rTvUM5C MnP14revofb+Q3b/JxJtKakdr7xyfuGxrMhZerI635yy38rfuT9rLMiU X-Gm-Gg: AfdE7clW/ZQ/Tf6cpq+JYyeQaMQDATXaU2AObc6A207NpGK6T3lMZ9TFPgepGOW51ic AdGUcVxaXEaWJao9Z82BKs7ZbYZ7LxCQsf8AMNVc66e8ODp/RDMzMxQbY1G+LDt77/zdlwxiP0e 1aBX87/CJ1F8iEoSqnfHPdD6LXCUQde8Dnr/G/QsRD93fTXsR1v7y1dv7xFEQoLMtOpzT9xb0tk le1XH+cZXxPpRf4868TmbOLEJro9Cxg1+z502OmFstjUTVJOZr/KS7UQwDFFXZaSseSiieTt095 dyzwJHGqlIQdvvf9Nx/mW0PdvUQX5Jkddw4zIL4Afd4a6njqSUbiYGrXjnffPtm1x2HgGWvzdtk aYEMnsB6pG+7743O3tTpdOAhKXfhtUKx0U7TD0BzlNOohhkYw8wZDlF27XGO4Or640kRAbrgDXq uLd3rv5k/C/+GxoT108U07XWq7OM4Dvlen X-Received: by 2002:a17:902:e892:b0:2c2:bd7f:ccd4 with SMTP id d9443c01a7336-2c6bc20a970mr50252375ad.21.1781724820880; Wed, 17 Jun 2026 12:33:40 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1886:6b7a:3e78:272c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4327aca78sm182035555ad.54.2026.06.17.12.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 12:33:40 -0700 (PDT) From: Ruoyu Wang To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm/amdgpu: initialize ret before UMC error record loop Date: Thu, 18 Jun 2026 03:33:35 +0800 Message-ID: <20260617193335.1662613-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit umc_v12_0_fill_error_record() returns ret after walking the pages reported by amdgpu_umc_lookup_bad_pages_in_a_row(). That helper can return zero entries, leaving the loop skipped and ret uninitialized. Set ret to 0 immediately before the loop so the zero-page path reports a deterministic status instead of returning stack data. Suggested-by: Christian König Signed-off-by: Ruoyu Wang --- v2: - Set ret immediately before the loop instead of initializing it in the declaration, as suggested by Christian. - Avoid describing the zero-entry case as an allocation-failure fix. drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c index 14092150336a5..4842340d9d65f 100644 --- a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c +++ b/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c @@ -690,6 +690,7 @@ static int umc_v12_0_fill_error_record(struct amdgpu_device *adev, count = amdgpu_umc_lookup_bad_pages_in_a_row(adev, ecc_err->pa_pfn << AMDGPU_GPU_PAGE_SHIFT, page_pfn, ARRAY_SIZE(page_pfn)); + ret = 0; for (i = 0; i < count; i++) { ret = amdgpu_umc_fill_error_record(err_data, -- 2.51.0