From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: pr-tracker-bot@kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [GIT PULL] MM updates for 7.2-rc1
Date: Thu, 18 Jun 2026 16:58:52 -0400 [thread overview]
Message-ID: <20260618-first-aspiring-wapiti-71c024@meerkat> (raw)
In-Reply-To: <20260618-generous-sceptical-jackdaw-3d32db@meerkat>
On Thu, Jun 18, 2026 at 04:37:52PM -0400, Konstantin Ryabitsev wrote:
> On Thu, Jun 18, 2026 at 09:02:06AM -0700, Linus Torvalds wrote:
> > This is very wrong. That merge (2f9f5887b427) is merging Jens'
> > io_uring epoll cleanup. Not Andrew's MM tree, which I haven't gotten
> > to yet.
> >
> > I wonder why pr-tracker-bot got this wrong.
> >
> > [ Goes off and looks ]
> >
> > Oh. Andrew's pull request is confused. It says
> >
> > The following changes since commit e771677...
> > ...
> > for you to fetch changes up to e771677....
> >
> > and note how the "since" commit and "up to" commits are the same (and
> > is my iommufd merge). So then pr-tracker bot thinks it's merged when
> > the "since" commit was merged.
>
> Let me at least handle this situation -- it's clearly an oversight.
The bot should now properly recognize when the start and end of the range are
the same sha and ignore the message (it seemed a safer logic than trying to do
anything else).
> > That doesn't explain why pr-tracker-bot thinks it got merged in what
> > was me merging Jens' tree, but whatever.
It's "bad assumptions snowballing." The merge commit in the notification isn't
taken from the pull request at all -- it's computed. Once the bot believes a
commit is merged, it runs:
git rev-list <commit>.. --ancestry-path
and then takes the oldest commit in that range. With <commit> being e771677,
that is simply the next merge you made after the iommufd pull:
$ git rev-list e771677c937d.. --ancestry-path | tail -1
2f9f5887b42711595e768b9dc0582dccfdf60c3b
...which is your merge of Jens' io_uring epoll tree. So the bot wasn't
associating Andrew's MM tree with Jens' work; it just tried to do its best
with bad data, with predictably bad outcomes. :)
-K
prev parent reply other threads:[~2026-06-18 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 22:31 Andrew Morton
2026-06-18 15:22 ` pr-tracker-bot
2026-06-18 16:02 ` Linus Torvalds
2026-06-18 16:29 ` Andrew Morton
2026-06-18 20:37 ` Konstantin Ryabitsev
2026-06-18 20:58 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618-first-aspiring-wapiti-71c024@meerkat \
--to=konstantin@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=pr-tracker-bot@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®