From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B5E25B09B; Fri, 19 Jun 2026 00:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781829108; cv=none; b=bpOe3qIgdW8YQHkwZev9544oKoFXoeFaLnQ99499FB0Kwa60YjildJWdFAF838C51ZjIhCDs229FU9wAfOHYY7Zhpa//YTjOCKdsCjyC9I2fpfataUkwZosHPvd9E4U4KgieHTCYGsQirh5LCXe2lXBhFXj6XXnlbiJJzqwoyL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781829108; c=relaxed/simple; bh=zwr/kib05D0i/Eehwnu1gSWwPlJmpnwxEu/3mfyz01M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=afDfQrR6V0KUjKtRO1RYQiMPp960WTZjMH5GvMYjW+GavsAYwitu6JNP4mo5XQxv4kX+yjb9CfhvoQV7bENyjnHmvOSoElYhvJTIpGmRXReiOzpqyBC8V0xRvfKFU+mFgX726poM6QrmnkfzQ7i3Us06TSfXU+bOdgSm084V3Y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aT1lMDnQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aT1lMDnQ" Received: by smtp.kernel.org (Postfix) with ESMTPS id AFFE9C2BCC6; Fri, 19 Jun 2026 00:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1781829108; bh=zwr/kib05D0i/Eehwnu1gSWwPlJmpnwxEu/3mfyz01M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=aT1lMDnQ/Hssjko+ktcLQNhGZE4FZUIEZhBPBgI6uihEym94fE0u8rmBUGf8oidOJ S/rKVLw+ccs+VMsepcwFDhZTWYLLyBX2ZqpBvVcHHgyggkug7/Nu2J1U1RPCzXesdt AFQIFyjheLB6PD/SoYNfmjl9GM/qBOORKEjtnf4Y03puH4aGCGqneKnbHpnvkFhXc/ O4yoKgkn/o+Kh7TaIrmbgAQfdgLfWuSDAs2JMZcSa2jqsoYZyKiJ3QQ07A8h88WcET VkQkYjL1c5ydJ2G9idxWW/kJGVr1BNLIiKTnFpzTbTxF28+QYGPAO9vxWzXSDW+i+p 7/0xriAVQ96zA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A637CCD98FE; Fri, 19 Jun 2026 00:31:48 +0000 (UTC) From: Ackerley Tng via B4 Relay Date: Thu, 18 Jun 2026 17:31:56 -0700 Subject: [PATCH v8 19/46] KVM: guest_memfd: Use actual size for invalidation in kvm_gmem_release() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260618-gmem-inplace-conversion-v8-19-9d2959357853@google.com> References: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> In-Reply-To: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> To: aik@amd.com, andrew.jones@linux.dev, binbin.wu@linux.intel.com, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Baoquan He , Jason Gunthorpe , Vlastimil Babka , Baoquan He Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, Ackerley Tng X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781829104; l=1550; i=ackerleytng@google.com; s=20260225; h=from:subject:message-id; bh=2g4cy0ezLsimvjBUeN80lEVTjw7VPhXUpjCJcq31lAQ=; b=6SZymPWXElVmP6Ks6J4dZmntqiQYDHtI43GPt0vGuDfQzqECi0WCLuV/5v+5akHZjHb/8CzX0 QeO5kliyrRiAG4Q00KInoT8eoZhH98t8zn+L8T76Kcci66v5MwF141W X-Developer-Key: i=ackerleytng@google.com; a=ed25519; pk=sAZDYXdm6Iz8FHitpHeFlCMXwabodTm7p8/3/8xUxuU= X-Endpoint-Received: by B4 Relay for ackerleytng@google.com/20260225 with auth_id=649 X-Original-From: Ackerley Tng Reply-To: ackerleytng@google.com From: Ackerley Tng __kvm_gmem_invalidate_begin() and __kvm_gmem_invalidate_end() actually do not specially handle -1ul. -1ul is used as a huge number, which legal indices do not exceed, and hence the invalidation works as expected. Since a later patch is going to make use of the exact range, calculate the size of the guest_memfd inode and use it as the end range for invalidating SPTEs. Signed-off-by: Ackerley Tng --- virt/kvm/guest_memfd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index d163559da0235..d72ecbfcc3144 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -366,6 +366,7 @@ static long kvm_gmem_fallocate(struct file *file, int mode, loff_t offset, static int kvm_gmem_release(struct inode *inode, struct file *file) { + pgoff_t end = i_size_read(inode) >> PAGE_SHIFT; struct gmem_file *f = file->private_data; struct kvm_memory_slot *slot; struct kvm *kvm = f->kvm; @@ -396,9 +397,9 @@ static int kvm_gmem_release(struct inode *inode, struct file *file) * Zap all SPTEs pointed at by this file. Do not free the backing * memory, as its lifetime is associated with the inode, not the file. */ - __kvm_gmem_invalidate_start(f, 0, -1ul, + __kvm_gmem_invalidate_start(f, 0, end, kvm_gmem_get_invalidate_filter(inode)); - __kvm_gmem_invalidate_end(f, 0, -1ul); + __kvm_gmem_invalidate_end(f, 0, end); list_del(&f->entry); -- 2.55.0.rc0.738.g0c8ab3ebcc-goog