From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 626761A6814; Fri, 19 Jun 2026 00:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781829111; cv=none; b=L+dJ22KTOTjkPrcsVlaE5piI52pt4LcQ+VjoYTkXdeptQQL/VBN7edmd+MJcVZCatYwZ/7vT1XNbrJAB3fWUv27Qo76wvkIBsnssWK1SMSSmAOnMaCPQ8VTUILITzE9mRbpRzL0hPbe0Qc+sPifYXdQCzKVM/dINeyB8kj3f50w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781829111; c=relaxed/simple; bh=N7rSu4GBVvvF+mRKIbced645XzNRnFAZny3SraOu/Lo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ucxe76t43A5rrWSgu6ZhqpczrEgtB0t3m0FIsJlw+ejK80kaKEFLzTb/+w4ZqJhlbK1wwJcDVTS5MBXXuupAbLasK9vQ8Apef0+pHOFDE8GAdtTwflBmKlS5PEVAm4P8FZCfP/SVc6V9t9T3UtqprUlf7drCmH06jh/M0k95DEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q80Wbh/X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q80Wbh/X" Received: by smtp.kernel.org (Postfix) with ESMTPS id 36D6BC2BCC7; Fri, 19 Jun 2026 00:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1781829111; bh=N7rSu4GBVvvF+mRKIbced645XzNRnFAZny3SraOu/Lo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=q80Wbh/XNAbH4XasX/d3S9uguNh3fQF/m5o1fLy6JRIKCKOJqAIjTjwuHTz/pwpYc //M7Lm0lLZjDoEKZaCalXZp/arAkw+2yCsa+TwVUcAfW1xczsw93DgorZgxKbBvm2B DAUBkTf4s6Q4I2vHVWXS2QBJz1XPvYoow2csFuSLlXoTAJabtmuXv/U2PwVhk5n4Lt QkNK/ROrbVAyLNFbl6vrHASuxnTamuwiELBysgEX15x72An3Wfx35GNfYOgYCbbV18 OexjYJ9QNFK5eVneI2OCH84dJTPHfN2N/JLKMBMPmzBUGEnR/Iq8/44vTx6ZFZChw5 wHX+jgKIKCJIA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2814CCDB467; Fri, 19 Jun 2026 00:31:51 +0000 (UTC) From: Ackerley Tng via B4 Relay Date: Thu, 18 Jun 2026 17:32:20 -0700 Subject: [PATCH v8 43/46] KVM: selftests: Check fd/flags provided to mmap() when setting up memslot Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260618-gmem-inplace-conversion-v8-43-9d2959357853@google.com> References: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> In-Reply-To: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> To: aik@amd.com, andrew.jones@linux.dev, binbin.wu@linux.intel.com, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Baoquan He , Jason Gunthorpe , Vlastimil Babka , Baoquan He Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, Ackerley Tng X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781829104; l=1300; i=ackerleytng@google.com; s=20260225; h=from:subject:message-id; bh=FfvOOziuKY7J+zAwvdCM21a/oE41ilanjqOldELME0Y=; b=bGm6mj4nU3DmKRVpn7tZlCQEkarM+48B/RQBAyw/VTpU0D3j33YT8OwpwMm+dDQJ0LUtFNveM KST7dvTTwduBD/4p9kp1IKhL8gRzKBkk40HX2bYJ916lTYy+dF1md+x X-Developer-Key: i=ackerleytng@google.com; a=ed25519; pk=sAZDYXdm6Iz8FHitpHeFlCMXwabodTm7p8/3/8xUxuU= X-Endpoint-Received: by B4 Relay for ackerleytng@google.com/20260225 with auth_id=649 X-Original-From: Ackerley Tng Reply-To: ackerleytng@google.com From: Sean Christopherson Check that a valid fd provided to mmap() must be accompanied by MAP_SHARED. With an invalid fd (usually used for anonymous mappings), there are no constraints on mmap() flags. Add this check to make sure that when a guest_memfd is used as region->fd, the flag provided to mmap() will include MAP_SHARED. Signed-off-by: Sean Christopherson [Rephrase assertion message.] Signed-off-by: Ackerley Tng --- tools/testing/selftests/kvm/lib/kvm_util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c index 0b2256ea65ff9..6b304e8a0e0d5 100644 --- a/tools/testing/selftests/kvm/lib/kvm_util.c +++ b/tools/testing/selftests/kvm/lib/kvm_util.c @@ -1110,6 +1110,9 @@ void vm_mem_add(struct kvm_vm *vm, enum vm_mem_backing_src_type src_type, src_type == VM_MEM_SRC_SHARED_HUGETLB); } + TEST_ASSERT(region->fd == -1 || backing_src_is_shared(src_type), + "A valid fd provided to mmap() must be accompanied by MAP_SHARED."); + region->mmap_start = __kvm_mmap(region->mmap_size, PROT_READ | PROT_WRITE, vm_mem_backing_src_alias(src_type)->flag, region->fd, mmap_offset); -- 2.55.0.rc0.738.g0c8ab3ebcc-goog