From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A372923ED5B for ; Thu, 18 Jun 2026 03:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781751643; cv=none; b=t9qR5KQVZO6BEalJ2UHh5bHad/SowiJN/uUr/pYi2LdJU84hioQHvBnAs4LIVDqDeIMp9hPzXOpze6dhGonboAiMSXd/eT2sMB/ASHeFuZN7ItDEoHy8dZ+XGFOVtoD8EEWEInB7aKik8okUglF98Y+0T7UfnmwGQ7FaIzi5GpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781751643; c=relaxed/simple; bh=OT6Zl/hHRw7EPQ1OQ6DYL9Xti2nBrEUcQwBVhNAy2ac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jQx5oVAxBO3IFEyxrXEdzbiz7/qcFWB3lhdzbkrj4XTeHeh7UsScI9Bfa+cAwqZ5Vpg5jfs4ZJ80j/ckemZ3tYjyxTB4jQR8IPsJs9SDD5g7jtaksxknSukP+/i0YCUlCnrGZ27oixH9nT8Ao4RP4vs53nGFD2gO2BIyvv/5ggo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mRKZ1Wef; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mRKZ1Wef" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-5176465a4a4so5947921cf.2 for ; Wed, 17 Jun 2026 20:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781751642; x=1782356442; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GjOWM8Fz7RsEt/VUPLUWR6H2bvEPTsT21fE+7hr3SSo=; b=mRKZ1WefKNFfh7xEjMWMfb57p3GPp5uRcKQ/LKKkYdjUXpRjTsAxlJyaseI9t+aR3p bIUzUlE0KaAaCAaRiT6qK27kNaBFrMFPbAgJAuf13fXW1uMTcFfTND6kxuSXokIVCId/ 8LhR6zbYjDxBlYG4iod7LYJuOShCFQ9NSqHkE1SI6xafejyD1T8DZXo6xyeJkX/8P5bt 2ApTGVScqvY73QCiUwB1Tx0RhjhNlY3uG1U4APc9P+hvJ35bW1QQietDkwTdqtuAx7Sx ia2T38moG9AZlavPlmzaiCqAyY16xMeTktjQ/4/x2GJlNKEI8lhrCyFHPn68DsnVrQZZ 7YsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781751642; x=1782356442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GjOWM8Fz7RsEt/VUPLUWR6H2bvEPTsT21fE+7hr3SSo=; b=QtQ6TiNisxQcTo9+JihTagVr+rNyNZFNMLrcKObDpOb09LtlWIR98yxXXxbVdHIlVo tnAOpOU9PThht81IThgEwWOCgjuDnDznE2FdvFkOocH1UbZsWavc/4L3PtH9BTvye6R/ vGNhFy7h9FG+0U6ztrPre8cCrL5aK6MrXKf1ad6gwRM0GGwdTeBtJTwn93KhwJrNSuoE RipHSp7cKXzyxnh7mGsE4avpDd38I0HTxSi9noMuJxMUooMuDDmB6lSqGgM28qWv/d5D IvC/lx6EkWmvcudid2CbN9BxHEzx3nbn4plZieiDdAub5KumWHUFRAnlFOfL67NcaCWw ccqw== X-Forwarded-Encrypted: i=1; AFNElJ9X+XecxTkB4hWm0Lcrg7bLNASdlAQF/dLVbwFMA0p48YEXmCi9cfaEEMqtTVIU5+pxTnk6IX4IZ8hneWg=@vger.kernel.org X-Gm-Message-State: AOJu0YwQiUmwiBeSVC8WV+qSa3PL6u83fXbpW6CW4BzybMebTel4HTzl HpSUB+DmbwfoV5IoXr1HbSNawqWNLAGnxJhllTc4vi13ULNv2pOaV8FRnQR8Ttrxy7w= X-Gm-Gg: Acq92OF7h1KSJ3VmZi5NzZD6D8/MYWQ2Po2vTtX6+kvIQaCTgekQLuk/GO2fCyNJXd6 xfNNd0LEMw6frRTujpsyO/qNRRMUdD9kUOZ4KSYGooFFJH5f6xLN0pjNR60Be1GjTrdfNVKwZHM O9qxFMy6BGiNXMX27GCZcPUlNbT0ke+W7zcaCbcgqrd9Dy31AsvN+Y9Krp3pxnKw9nRJwkDa1WT sJQ3+OD1nSHfCAO4UU48Zwiuj/MkralW246Ud6P6P450SEmjwlRPlSqCyPyxk226LniKq0cxeor ANlGoHg+Pu7GvVmsPJl9b7dMxCigMEmcyVx9ugda05id3JWayPOLkCSMJeum/7iJl7Ht8KUjDRA ylePl2qLNz1D62VcuXqVukuazzPGaWxy6rDJaUxCObog1A5JMErwOXbvvNLsTI6taE0Xu+kAHrJ oh2SUNajVEs+Yrq1OmyQZoaDCIY+/B68EIOJEvwwYrPLBbTUiucLbzFrvGeVOg9Z1QB+18BBxzx +9w2SgSZQfTREuVnTlbVOqy5r8mVcrG X-Received: by 2002:ac8:7f93:0:b0:50e:a1ab:67ea with SMTP id d75a77b69052e-519c6f3dbc2mr27789611cf.40.1781751641662; Wed, 17 Jun 2026 20:00:41 -0700 (PDT) Received: from server0.tail6e7dd.ts.net (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-517fb61eaf4sm183849021cf.4.2026.06.17.20.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 20:00:41 -0700 (PDT) From: Michael Bommarito To: Stefan Achatz , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] HID: roccat: bound device-supplied profile index Date: Wed, 17 Jun 2026 23:00:35 -0400 Message-ID: <20260618030036.1880139-2-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260618030036.1880139-1-michael.bommarito@gmail.com> References: <20260618030036.1880139-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit kone_keep_values_up_to_date() and kone_profile_activated() use an 8-bit, device-supplied profile value as an index into the 5-element kone->profiles[] array without a range check. A malicious USB device claiming the Roccat Kone id can send a switch-profile event (or a startup_profile read at probe) with an out-of-range value and make the driver read out of bounds; the result is exposed via the actual_dpi sysfs attribute. Reject out-of-range indices in both paths. This was found with static analysis and confirmed with the KUnit test added in the following patch (KASAN: slab-out-of-bounds). Fixes: 14bf62cde7942 ("HID: add driver for Roccat Kone gaming mouse") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Michael Bommarito --- drivers/hid/hid-roccat-kone.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c index 58654cf78f0df..17495fcc8b7da 100644 --- a/drivers/hid/hid-roccat-kone.c +++ b/drivers/hid/hid-roccat-kone.c @@ -36,6 +36,8 @@ static uint profile_numbers[5] = {0, 1, 2, 3, 4}; static void kone_profile_activated(struct kone_device *kone, uint new_profile) { + if (new_profile < 1 || new_profile > ARRAY_SIZE(kone->profiles)) + new_profile = 1; kone->actual_profile = new_profile; kone->actual_dpi = kone->profiles[new_profile - 1].startup_dpi; } @@ -793,8 +795,10 @@ static void kone_keep_values_up_to_date(struct kone_device *kone, { switch (event->event) { case kone_mouse_event_switch_profile: - kone->actual_dpi = kone->profiles[event->value - 1]. - startup_dpi; + if (event->value >= 1 && + event->value <= ARRAY_SIZE(kone->profiles)) + kone->actual_dpi = + kone->profiles[event->value - 1].startup_dpi; fallthrough; case kone_mouse_event_osd_profile: kone->actual_profile = event->value; -- 2.53.0