From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E65421D5AF for ; Thu, 18 Jun 2026 04:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781755747; cv=none; b=M2GVPcgyxw5yKDsjYN/YJit6+ayp1eeDUXYlYUgmJz+dn4dh0WPlkZMNEwAsI9eJPZuZfQu4nNwqll0zaiPvrKwRkXQQnwcJTrFlg18I1XKWEN+DYy2Aw2r+GtQBD6sdxrFn/v8xdhpovNuOm1oekF73u+LdhPnNQfHg5UTxocs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781755747; c=relaxed/simple; bh=M5k9ci2HxZM9fdTpSAxdgAlMz3EwzmB16rSq2JZN8y0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PHSMxeD0BUAGjfx1qg0g6gbdfJnKmHJ3SqpQYSTj6syfbzpbXtIQSrxPgB+dw75JdWbLe+2JbG+XIHeKz5eJ6s5vuoELcx06KU7C7gJPu5ZT9nK6vISc2PevBJw4kVlPF1T7c8zoC/vNU4Rzh9lW2GNhsGntuLIGcZsbCQqN4Pw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Khk/1b8r; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Khk/1b8r" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-8453f568e84so252399b3a.0 for ; Wed, 17 Jun 2026 21:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781755745; x=1782360545; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mf3jJNGCHMNwyX+15Gf3qCeUSoD/AqOS50pGRceH38o=; b=Khk/1b8r6wauU42kp4lYDjsKthHgp4P6vNcRfRoHO65EEv27TqWrKQlQzphQ5APqWB sDFYRYoa7LMWiBGCL22iRIhjoM1tfNrkGq4HYoIkBCaK9HPIFhAWOMZuTMJWOgc4cBDb lh7WfQEqT/yQVKWASInmy2HlgmZ16y5IIe4XDux1tcpInGhsAYN0XHeCNzgk7MrhGOPx Kx0Lunl9alTne5L7NqSvEsGIOrfkJRYNLRxjkGdt19pr2/570eE7emYHjKJqE9MytNSQ yJUIgRu5l25KbPEAIrf3kcf6qIxkePKWO5oxW3UnzPYyRbABT/PEVwszNX9PPJ/ZQ+QI t49w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781755745; x=1782360545; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mf3jJNGCHMNwyX+15Gf3qCeUSoD/AqOS50pGRceH38o=; b=rfqTB8ZXiXXXjsDsYD9MQq8B5D/Aw6MgWZQxBrIsOFOTsChEUKnSWFt5YzdsBCPGQ7 DKWxItAwHjVIV/UUszeeKCE1Tbbk+CHSWHumfOR1wulvqs02JYtLfn4L3gTsSlhvTjDA A6g6a+otTEv0J0VUK6HypV30oU87NEB0WaqVqZK/sIs00U4RkL1+6XdorhiAJaz0QhG0 EMhTqzlTo/upVVLU4ZFzvKdzZ2zSNiwxikbWrpA2LxzomJuyMG4mSd140voAPbRt8z48 gtlDljMowEeWJRVnHhb/Ve7j1c+FvXztMgsBhL+4ypkmUWBdW/CiwlVKBioL+TcHDLmL IXXw== X-Forwarded-Encrypted: i=1; AFNElJ+tVdshkKvRsf/9pHYiqiDCW/1i0TS0aCkxDX2vhM70vLkv/GOE9uj89t3qtRKiEihgukNy7C1o0X2l+Yg=@vger.kernel.org X-Gm-Message-State: AOJu0Yww4CLe3L5R2HO72hrFnZlpxfAlycMzZTo16cMYjGpIOrZlvEnK jYNpwt1oyrxRFQHMrokXvruFVBFA0S7kcC1hvueb36k6hvsbO7foggsO X-Gm-Gg: Acq92OF6pM3T0t/UJwtU4GER0EIvl0XU0Sn3EIAuKzcqVzgIz+jPENcf6mTAcU0FUnU w9s8PC916vmL5HX3fNSrNlaGFpSPqWw//8yp0Chx/9uq9lzeRlmby+Pwe8NGx505hqVwesGnBn2 rYpy5x9rUIXjo4qCStfmurjNVl9BjOtCbBoeNBf+6EBfGj7C5m+Te9q2W7QUz1X6PCKUc8mMvh1 QVcoeuxp13pwmpKu9LFmn6IA/0TBmYc5wjIQmyXDkodKi0IyOxh/1aw1JBAdPUOJqw8JhqbGgvW a4hjbj3W5dROh0RBd17J0uzGTS09H5hHAKWblTEZW9sqDIFnpJPbsNWVTIi6iBc+H+YPkEiyLm8 dvQ6B0TcqYVBuoW8e5xogJXSWVPUqKUdcGvRN89DxdwJSy51rDQJy9qPQKO9UUdwgTwm6CBBJEv vXInBUbjNMBClKAbfA4FIAOdez8iMaT7AW X-Received: by 2002:a05:6a00:228f:b0:842:6c02:2fa4 with SMTP id d2e1a72fcca58-8452446d90amr7256898b3a.14.1781755745338; Wed, 17 Jun 2026 21:09:05 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:c19d:3f9a:e9ce:93d4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434afc9fa8sm18077491b3a.32.2026.06.17.21.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 21:09:05 -0700 (PDT) From: Ruoyu Wang To: Srinivas Kandagatla Cc: Heiko Stuebner , Jonas Karlman , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH v2] nvmem: rockchip-otp: skip zero-byte reads Date: Thu, 18 Jun 2026 12:08:59 +0800 Message-ID: <20260618040859.407326-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit nvmem_device_read() does not reject a zero-byte read before calling the provider reg_read callback. rockchip_otp_read() then enables clocks and dispatches to the SoC-specific callback. Return 0 from rockchip_otp_read() before enabling clocks when bytes is zero. This avoids hardware access for empty reads and prevents zero counts from reaching the internal reg_read callbacks. Fixes: 8ab099fafbbc ("nvmem: rockchip-otp: Add support for RK3588") Suggested-by: Jonas Karlman Signed-off-by: Ruoyu Wang --- v2: - Handle empty reads in rockchip_otp_read() instead of initializing ret in rk3588_otp_read(). drivers/nvmem/rockchip-otp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c index 0ec78b5e19e7d..95685a9fcc77b 100644 --- a/drivers/nvmem/rockchip-otp.c +++ b/drivers/nvmem/rockchip-otp.c @@ -272,6 +272,9 @@ static int rockchip_otp_read(void *context, unsigned int offset, if (!otp->data || !otp->data->reg_read) return -EINVAL; + if (!bytes) + return 0; + ret = clk_bulk_prepare_enable(otp->data->num_clks, otp->clks); if (ret < 0) { dev_err(otp->dev, "failed to prepare/enable clks\n"); -- 2.51.0