From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E29AD378838 for ; Thu, 18 Jun 2026 04:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781756284; cv=none; b=darUaIxu0q2fZE3vbQcCacSqiPqYb3l5uIHaiQK7fcnNDsCl2W2wyg8C33DO+/Jh8d2NlXD2IOAl3vwjQeHLnl8Fdom3/Tq6ByPsUd1UFgoKAYJ1scXWTK+TCzTbTKRsvFoA+l5wbIrx/c0yFG7uxZRejXDZbZKtSsFnHEq9i60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781756284; c=relaxed/simple; bh=YZVjxHytK6JV04yDSOVmcLzWgf6HDh5iivbaDRspdtE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hPY+ht/He9k/o7zNPddInUJNluCdh25YjYb/zHkLsc7kGKjmkZMbxjGTP5WXpvEpMb/TPG7wIrSY5zH9G82J1TmWlYZRChqL3rXsPn2i93Sa0w3hTh9GQf3bVVj8xrjQ+bmgCvbSP9BaQIa6EpuIeFjtdn+dUq+rRXHCc7i+Wm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=azwx9mDq; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="azwx9mDq" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2c40397e3caso5394985ad.2 for ; Wed, 17 Jun 2026 21:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781756282; x=1782361082; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EHvs7Qp7jp88X6reSVKZtHJFIAjpU0BO9YqmUs6J9W0=; b=azwx9mDqjiOab8zfLW0HwwvRh6J0ltQ3z1PWSlzm5srJNsRuf1qI6Z7a2/4euq2H9O XzsgQC5VZUM/1WdBjbcfDJ3ruk2STuMFQE0LnxNgxQmTaMqtM1xtd+xUhWDTQcYyHYEc ntFRRHm2/4U3vD1MwSdkyKnmsPIoZCeB/vpX4Rt37rALoTXvKlH1NinM6NyLy6/XQc96 NUmWg2xxvPFIrweYu877pz/N0ztWsD3M7dYbkB6Fdu6yAAObnLkoDuHs8eNbA3j1CQ5U oLA0ImRvpq5YlG9D7sk89x06HxTiF/WN9bIrm68hnCMKhid50/aLcxyscq0qaL5E8Ewa 8uwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781756282; x=1782361082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EHvs7Qp7jp88X6reSVKZtHJFIAjpU0BO9YqmUs6J9W0=; b=rqqJeHxTPkta7uAmYw/FwBGl3TPqVmEc7QiY4OL7eknzEEi+XuEQUklWxDm8CEeFg1 VlqxDZisyru4TKZgoS17cj/j4UxqIO9aQNhEbompmndrqJI8/k22tOqktCeYo4FCYtKo DEZUCHHN2nlBEa0LdvidBMWrXy0CeVEcHG2nB/bERa6CIx15vdt+niExyWgXt76lynWZ rsXoUpjUlLWi7/0gj3r7v9JhRKe/Mxp7k8uz6yHJ66o6XHz2IbcML7tuUCms1PAMMLS0 ItPNMo2yNjCDfMB7d7hbPoCYlLSzB6d3N7ddAf2TMRQvT/6ZNeM5wiWt27u/EXdWjIDR BXAQ== X-Forwarded-Encrypted: i=1; AFNElJ9XIsH3R5Ihg8zP6X3/3MHfoAWTlZ9FvJD3L+fWoMHYdybgnX9silineiJZESaiPi+WJRHG6TtRPDK4zpI=@vger.kernel.org X-Gm-Message-State: AOJu0YzRY0KHk+kK9goryM1wkcxMK9hH4HUccPl8P5TVVfnNARuM++Gh dCgWzN+qhwOYnqdOnTp/HwQ6mz1yyAclaAEwx6dZMJvZCwy3RbvqvDpp X-Gm-Gg: AfdE7clWhmsVg+F3jR96n1ex6sLF85ErDNi6gBVOTnVqw38ueTwX6li3Yz23umXiZEe wrMqvq0/gB2Y2Oi5VAjuVyaQiqp7m3vii2slLgocJYfQ3Nd/fYCiTyEspo7Ks2mc6+Wq4OL72no LCHHkBwocQU42dRZN4KzMdXbTaw8cL3FtH5U8ztyhuE/c/tBocd8dE6iJIYcWq2AtLiJaD8PLQf 87KCgzXW5oi3sb0D8zx+9JcXWo5S08yb22J0vPp6HRvDK02VqmaH6rJ6A2NW4UYwEYgBaXKwBBp QF1KbJdIMeXjMJDOJAzpSd9bv8Rtt9arN4K+90cH6BO/7JF8B8QEgfJLRClbTQVeI4WVYYeejuM x8+2c2ypK/sTshr39SKzpv7ufUzcBY0lpkJgDHPtg87ryz5YUO1E1cqVWOi3a2z1oG5/PnwrL7N Zo8n8TcBC2chs83uoN/VTRtW9Myid1wdIv X-Received: by 2002:a17:902:d2cc:b0:2c6:8eeb:a7c5 with SMTP id d9443c01a7336-2c6bc252f5fmr69903275ad.34.1781756282242; Wed, 17 Jun 2026 21:18:02 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:c19d:3f9a:e9ce:93d4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c6c4689ccfsm34516645ad.66.2026.06.17.21.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 21:18:01 -0700 (PDT) From: Ruoyu Wang To: Jason Gunthorpe , Leon Romanovsky Cc: Cheng Xu , Kai Shen , Long Li , Konstantin Taranov , linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH v2 2/2] RDMA/mana_ib: initialize err for empty send WR lists Date: Thu, 18 Jun 2026 12:17:52 +0800 Message-ID: <20260618041752.481193-2-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260618041752.481193-1-ruoyuw560@gmail.com> References: <20260618041752.481193-1-ruoyuw560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mana_ib_post_send() returns err after walking the send work request list. If the caller passes an empty list, the loop is skipped and err is not assigned. Initialize err to 0 so an empty send work request list returns success instead of stack data. Fixes: c8017f5b4856 ("RDMA/mana_ib: UD/GSI work requests") Signed-off-by: Ruoyu Wang --- v2: - Split the erdma and mana_ib changes into separate patches. - Add a driver-specific Fixes tag. drivers/infiniband/hw/mana/wr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mana/wr.c b/drivers/infiniband/hw/mana/wr.c index 1813567d3b16c..36a1d506f08f6 100644 --- a/drivers/infiniband/hw/mana/wr.c +++ b/drivers/infiniband/hw/mana/wr.c @@ -144,7 +144,7 @@ static int mana_ib_post_send_ud(struct mana_ib_qp *qp, const struct ib_ud_wr *wr int mana_ib_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr, const struct ib_send_wr **bad_wr) { - int err; + int err = 0; struct mana_ib_qp *qp = container_of(ibqp, struct mana_ib_qp, ibqp); for (; wr; wr = wr->next) { -- 2.51.0