From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27FBC36F90C for ; Thu, 18 Jun 2026 06:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781764919; cv=none; b=BWCLn4pPknhZt47zOpryH9qABVXnSEpwjLpfLjNbYy8N6Ci+ijaCZ8AfRlyfy5njWS01+Kc00gbV0kXtlEuteb9aAU2TicS/qXBM/t74s8tbYm5dYWrqYvBJjqd/U4IYxK5RWOqqGO/sbVLnjJFchzBM71qAYnpda2phmx/c4c0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781764919; c=relaxed/simple; bh=WLF7/xznf2EvJR4gFlmVaoocRv93ZakQpL8lMrw/czI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=P26S8b9RefJgzlHcNBkthv+s9JXycKpsMp0zaZgeCEqtDmKfqEjl3NfKHukngUoVNaenCIZABxWjSiXQqfnHtuNXe27aRBfxn10TG0ciPUn5dQ698X+vWHl40+384VQpYWAOS10gIuTdS4L5m4HHCowiXMkMtYf6tOT3CAW9dW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kbeJorBh; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kbeJorBh" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c86307c4e6bso301338a12.0 for ; Wed, 17 Jun 2026 23:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781764915; x=1782369715; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Uq+UrIAjX4AZwds/jvySlMBzvhIQPTWIB6Jqv3g81b4=; b=kbeJorBhWqTcZnMni6xtcOgwwZ3RIbCNojJ98oyBZ5iB142tMeu0NAP2CCqcS5zVY0 Wy3crzifAuqMo1nKEyIuTBVUGJyuV+zGlTbrRRmUI9GSXVxbs7leW2bUzbtDngN1R1Y6 qgqetx3zMAH1u15TFajMakUnjLZV5/kJWCau6ahCsAunrWPdQBhyBK6CQWPG19JUyTS1 ax2kFv6qxAtrahe0dbwVwVc08c8wb5BC52X0Yd+/7e5/MUk/gl6SzWJMMKCfXLoAHe0k 9DuApTDZEN4NS/+Q2v0fDm1CMIKNRgathFiNJ29OwquSG3ABAbRnJK3QAooTFluSJuwR L+mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781764915; x=1782369715; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Uq+UrIAjX4AZwds/jvySlMBzvhIQPTWIB6Jqv3g81b4=; b=WR8bbyYdMmtO9D9kdgKDjhHsyq/yHxgFdS2mdIh/Xbqr3uf9ZUdi5/2rtUiB/M5vnC ZexB+wJ9KoupQXpRVEkpAH8xAyfPNP5YPCUQNfu/Z61xMHmz7Bm5VGpZULqOQToraxYR MGwK3rIC7PDPiI/OGXqxi742NgHwL7o+vTPoNSR7AekrSSofsrRKVTmT+5coU6FkVqjL SdHQGXrRk0+bEA+64sLl1/c/OJP+L94KR3DX6FZOAFJ/przj8pzZE9bzMMb8RjvyP3kq pjSoz/U8NVJo8dCkBGY41fzedAxOxhCWOVumsEtBh7lvr/FrpMjMq6bDK09MXDC1PU/U 8/cQ== X-Forwarded-Encrypted: i=1; AFNElJ9ieDJklNuY+9JQ6g/lCem5EhtWZFMPDa/YdVOZN8WTq/O/f/RCx6V9I/AOSWlqYVhS7w7aOO3/Dj/qBuM=@vger.kernel.org X-Gm-Message-State: AOJu0YyLUqKM0ePndQY1i8QQn9H3ZDkumGYQz2KVYTaMjUS6nifhE4BY XJWFY+m+3nI2rZZy1rShfl3HaOSWptudH2ittCkvk6BtW5lKs7E0bcCR X-Gm-Gg: AfdE7clHOOYzyly9eoyU2wl2l3cQMS68LHZ+k5rE64XhQTJOWqak+zdRUGddeiWCkWe FwhCoP7yjnqQQmgg1h5oyskm0/NeD9hqU5JdeA8O4ImUhFtNxQIwDuEwMMLBv5wyAgugPLt/8ZF t3Sf38Hr06owCxLSSqd++Uncm2f0yPuBMWyzyrUMpBg3P8dsJYFKXA+BaawTKj7irgPFKVHsICW x7a3WMBASBm4xm0iyuffX1dzyU+Zgw3WSS+dxmz+rWEmQ5gClYs03MDRYP/MQ1aZ9KXykNfqdFx twQ0GHtTCMUwXI5yJ9lJQlm/DYVNp+XYR3Sujw75NcX80fslXgT9nwzfxqZwOXENu2YM5M4qBzB LmEoJ/TO/JOXPGswzu5Ist9OyZyNGrTJQWNU3gp9uB1PeAV3tU7hIE9OzAFT21WrV6ixEZCv0Yh 2L7kgsutH1Bx8= X-Received: by 2002:a05:6a21:4d17:b0:3b7:9aa8:3be3 with SMTP id adf61e73a8af0-3ba4d0e7999mr1744739637.2.1781764915177; Wed, 17 Jun 2026 23:41:55 -0700 (PDT) Received: from localhost ([2001:19f0:8000:3e6e:5400:6ff:fe38:3d01]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c866325d156sm16799602a12.13.2026.06.17.23.41.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 23:41:54 -0700 (PDT) From: Inochi Amaoto To: Inochi Amaoto , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Yixun Lan , "Russell King (Oracle)" Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: [PATCH net] net: stmmac: dwmac-spacemit: Fix wrong ctrl register definition Date: Thu, 18 Jun 2026 14:41:43 +0800 Message-ID: <20260618064143.1102179-1-inochiama@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There register layout of the phy ctrl register has something wrong, fix it to match the right layout Fixes: 30f0ba420ed3 ("net: stmmac: Add glue layer for Spacemit K3 SoC") Signed-off-by: Inochi Amaoto --- .../net/ethernet/stmicro/stmmac/dwmac-spacemit.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c index 223754cc5c79..6feffaa3ef3a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c @@ -18,10 +18,12 @@ #include "stmmac_platform.h" /* ctrl register bits */ -#define CTRL_PHY_INTF_RGMII BIT(3) -#define CTRL_PHY_INTF_MII BIT(4) -#define CTRL_WAKE_IRQ_EN BIT(9) -#define CTRL_PHY_IRQ_EN BIT(12) +#define CTRL_PHY_INTF_MODE GENMASK(4, 3) +#define CTRL_PHY_INTF_RMII FIELD_PREP(CTRL_PHY_INTF_MODE, 0) +#define CTRL_PHY_INTF_RGMII FIELD_PREP(CTRL_PHY_INTF_MODE, 1) +#define CTRL_PHY_INTF_MII FIELD_PREP(CTRL_PHY_INTF_MODE, 3) +#define CTRL_PHY_IRQ_EN BIT(9) +#define CTRL_WAKE_IRQ_EN BIT(12) /* dline register bits */ #define RGMII_RX_DLINE_EN BIT(0) @@ -118,7 +120,7 @@ static void spacemit_get_interfaces(struct stmmac_priv *priv, void *bsp_priv, static int spacemit_set_phy_intf_sel(void *bsp_priv, u8 phy_intf_sel) { - unsigned int mask = CTRL_PHY_INTF_MII | CTRL_PHY_INTF_RGMII; + unsigned int mask = CTRL_PHY_INTF_MODE; struct spacmit_dwmac *dwmac = bsp_priv; unsigned int val = 0; @@ -128,6 +130,7 @@ static int spacemit_set_phy_intf_sel(void *bsp_priv, u8 phy_intf_sel) break; case PHY_INTF_SEL_RMII: + val = CTRL_PHY_INTF_RMII; break; case PHY_INTF_SEL_RGMII: -- 2.54.0