From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586FD3C0A10 for ; Thu, 18 Jun 2026 07:08:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781766506; cv=none; b=NiggdOSuvj7onAbMlGvX4mV0MCY+GPIBWElN/UBCvsODu1yqfZ0NnI9T5yEOq6+fRaxyz7ygvxc/OUx1pQN6Io264laaRMJm1BeGIoKoObM8D1jhvznsk1S2C1UErmgD1AeqPb48SLe65kcbfjyvYDLZLFfcQZVo5zaFMXxdnb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781766506; c=relaxed/simple; bh=58uM3rtyTYGrJdql0JMPbfvW8pN6bRpzfwVAFqj/23A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GYKkEfTexaZ5CEPanlr6pZMhwKMXt6thYEbN2ME8rz04USkVZEjAy3y6JI9x4jUrcJ0LKEmLQ1l1COUJeJFhALRRBWmNA08JV2b7+Uum/5wh3Kjnd7nwazFk68dFVgEoIgRbvgbB7z1+kBjsc2gdVCefSTnwrVHhQBtAl8xzn7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DpfW2MfF; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DpfW2MfF" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8423610ec93so482619b3a.2 for ; Thu, 18 Jun 2026 00:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781766503; x=1782371303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=py7sFiyEu3cLvtrXZwVU5OC7C9L/ey2Xp/3aJ9X4rBI=; b=DpfW2MfFsoKFQNj79hnZd/J2SbGupBFK/98C5qsLA7G9L+tpVqgDO/kVflyRVQAWEt 2nq8CqXArnAC7Olk/t01L7PFEkT2VdLGeUlns9TUsTpTBDeLcFdIJH3Et8qdSDECKo9k VEpD75r1ZhsM0IRndNfas08hBDTVK+T3iRYh637JAfR4z/gNseyX30pLeFxQfcqeMtxf ZtJ6Aa/HYLUAdfImbfKVjeuWHOLWfajuGFI2E98XF/pBjC1qGAmqYMO5XZu+pLFC5Dat 1dWDJ78OCv2Md80wR+T3IWCKYqNFuTaYLALbE/h4sgNLyccCcED8jwb9pmL3WfzB9se4 Z02A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781766503; x=1782371303; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=py7sFiyEu3cLvtrXZwVU5OC7C9L/ey2Xp/3aJ9X4rBI=; b=LCYg1A++aJ6WwpoxVuiupGIM/gIQgddZJYhddq2Dcjj0rIxdyvUtU77P+mMyUHKEgG bz9UPT7lxNhKqYFLByvY36CORC1L0YsQGpDeQigSQYgxE6+52GIEa5gI2ZRe0ica5RFD 4nYlUIgqMr5PCv7lb1NAR1LMrHq3TH5FHoWeRaQ00i1J8Q5CZcpCzGf1556ohyrv6gjW wPCWWLrRyNIz13j3G2F8uS0UxQ8exhhW/UEDG15DPNLBw31ZbZxeAfV7M2BMjXR0pDxi J6b7eIN/KKyYuGMdXlDA1Ct4XbblZYZi5ar74fZC7VqUww7ProKkvW+LI2gHL0l00v5B KvKg== X-Forwarded-Encrypted: i=1; AFNElJ+NnmPemE8MtXIJbPhTRLnmssE9EWJQeAMBQ/k1Svwifv5IT1MkqVEhGNUI9WPJ0hLwQh4vMhpbTfhnGmU=@vger.kernel.org X-Gm-Message-State: AOJu0YyHxPAN5gcGi2pH/acBkr+VCuGC53pi6fWXw13oAHcoBIsmz214 AUsslkcUExO9D/TN7qWm8+kLPVfPQVQ6Xq1v3EzTvkOZlxAa6dYy3Yzd X-Gm-Gg: Acq92OFWn7jdarr8vyfyBxSWYtSv2I7g+/xlB5Gp1e3M9OgFpg4+DHDkFYIiYTY2mEZ poUagBCPHoUMQbnrDQWBsODb/jAm+d+YWrs6RkJ2Eyw5iEF82StS6auboU1MS3RuIK9xR2iqxJb vsB6YKtLVvd0uJnU2hkvmGZJ17V0YaJqCazYBtc0Qf5unWU+o/QmEzpYdUa8yKlirAnQd5FRBp/ PRFKvcZDtWobz5aE5RHa9p2KXoX72fHxOy7HfwYJWCvR61aDzTnQfNUcm7wum3iFbtQruvQknmU ziilgp2kWS26AwR5U6+i1idp+NbMs+z00mcahFNXifXBlN3tRFqGs7sDoW3v/jhu5eGojX4A9cU uvCfn5Kl9f0h1xing2KAUAFUDbyNwy0MKqIi47RN9TjKuTTV7tEg0DIJ8+qnKXQtNaLZVP5J+Rl PZlBHW93QTNFexUZknR+mniKy0WnvyrRpLgQU0jA== X-Received: by 2002:a05:6a00:298d:b0:82f:9407:d167 with SMTP id d2e1a72fcca58-8452457b4acmr7920016b3a.38.1781766503669; Thu, 18 Jun 2026 00:08:23 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84531dbbe7fsm3132263b3a.14.2026.06.18.00.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 00:08:22 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Kuniyuki Iwashima , Xiao Liang , Nicolas Dichtel , Kees Cook , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net] net: sit: require CAP_NET_ADMIN in the device netns for changelink Date: Thu, 18 Jun 2026 15:08:17 +0800 Message-Id: <20260618070817.3378283-1-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipip6_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate ipip6_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. sit was the one tunnel type not covered by the recent series that added this check to the other changelink() handlers. Fixes: 5e6700b3bf98 ("sit: add support of x-netns") Link: https://lore.kernel.org/netdev/20260612085941.3158249-1-maoyixie.tju@gmail.com/ Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- net/ipv6/sit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index 64f0d1b..a38b24f 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c @@ -1613,6 +1613,9 @@ static int ipip6_changelink(struct net_device *dev, struct nlattr *tb[], __u32 fwmark = t->fwmark; int err; + if (!rtnl_dev_link_net_capable(dev, net)) + return -EPERM; + if (dev == sitn->fb_tunnel_dev) return -EINVAL; -- 2.43.0