From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f73.google.com (mail-ej1-f73.google.com [209.85.218.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D386839989C for ; Thu, 18 Jun 2026 12:16:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781785009; cv=none; b=fXG3iO13M/2YkD6RcDiqZHg4aWflQoika1OMNsX5/AAkA11dHvcaqlI7V808AfxzJgUSUeLURXgoZqFGYhFq8Rt22HRAu718CeMxt6ahozEcpDo/UF9Q6OgWTYkCTXWPQUnghnhX9Yrv0RDFeFg9Lj3pT/jYF4tiFctUqsjBKRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781785009; c=relaxed/simple; bh=k2tUUrjaEOJSqLnYiH4trRmQE35YgYWiuUcxe3jHqqE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=jXj0Ti2elU+ofcujZ5208DTOJsdYZ7Mkx26Kkmr0720CcNBvrxDyuE3mR3l0i2gKDsCBr7Ou38xpRd9ZcmA//9vSzOM4sHoSWsnExMo00OH0mIQqb+iBRNwSwo8qF5zFqkY1YnJGvvWlnnqE11mG/YYBMa5B1Rg3BNO8eRxcUIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tabba.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CTMEYB/4; arc=none smtp.client-ip=209.85.218.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tabba.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CTMEYB/4" Received: by mail-ej1-f73.google.com with SMTP id a640c23a62f3a-beb6d964066so60415166b.3 for ; Thu, 18 Jun 2026 05:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781785006; x=1782389806; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MmD9Cr1xCcQkaKp0J7hG0PAULLmxV4B2BqTlvVuIlHU=; b=CTMEYB/43G1SReMwUJY3vKhUmNp4xfT7ltX5sOEGrubQcCWfOjaDuZIVzMPJX9UU7r av5Ome7yeSU265RNnZ5CYXGKTsRzAmPrmf9vNRmR2Raz023qJQYUmLvmny3Rgwl9+9af BXBcwPuYvjrk7V/iVPbWj7kWMd/hI+x05fAbceTXeiiSeMMW7EGWKtJ/pcIjnt3oR/50 mkDnbMFGjGRNtb6BOxX+6LxFtwvLT2dViljdREWIKmll66MwbYDNh6AFK1M/wFLGbn/u lppY0949LjV8Hj+UUqdIPAHIWKELaRDqVclBrQaUHSimWqgHFNSWmpoMfrO/bJjAS2Hf Iq8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781785006; x=1782389806; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MmD9Cr1xCcQkaKp0J7hG0PAULLmxV4B2BqTlvVuIlHU=; b=FxRIMFJNAwPeeIKvG7MLhTG2IpJ08L7lzKblgRcDaLPOFdeK+ITArmG4Pcsw9nEPqL 4vVI1uAuDs8etLpCYqmUoVwngM+YNHzHS/0PPl4YjlIukTrqkVT2G2lIXKZ9eFz/8dzR g5H4VmS2p568riLFpKiT2ORHg7ZSdN2B4gh71CVKKExCp7f4eo0vPZ8rdL66W0Nf/5XH XpyGPljWDKbYacvfpSL213MVGIdh6Q7TdE2KYZaDXP03mNpSznY+qVJ6k3vaxavQBF46 Sg1r0fbBHTnQM0+jxCwXp5S4ZBSUJ1xdkSbkb0C4u8z6zTbHv8u7HEfzmMIO+4UMHpZu /XbA== X-Forwarded-Encrypted: i=1; AFNElJ8qnXpFjZrtq9pUB3GvYF7/R+oRj2a/G9d4SRaLQwFBKFB7WLf4q7GK4YGCodV29LPPXYoNrJZXblZAVfc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5vh2YhpRE7KI3L7lWBePLytBdgXs3SSyHlO3g31a0O5Ie7WxW 6Jh6UX/Cq0lzdMi+VxX5b3pvwaQ0fDf06CABfltsKWTb6OKArcemRTpJlcT81isMfmgmgbiYDCq MBQ== X-Received: from wrs10.prod.google.com ([2002:a05:6000:64a:b0:462:b6f9:c0d7]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:9305:b0:beb:b53d:4841 with SMTP id a640c23a62f3a-c05a73a7992mr547603266b.35.1781785005667; Thu, 18 Jun 2026 05:16:45 -0700 (PDT) Date: Thu, 18 Jun 2026 13:16:37 +0100 In-Reply-To: <20260618121643.4105064-1-tabba@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260618121643.4105064-1-tabba@google.com> X-Mailer: git-send-email 2.54.0.1189.g8c84645362-goog Message-ID: <20260618121643.4105064-2-tabba@google.com> Subject: [PATCH v2 1/7] KVM: arm64: Set ESR_ELx.IL for injected undefined exceptions at EL2 From: Fuad Tabba To: Marc Zyngier , Oliver Upton , Catalin Marinas , Will Deacon , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Vincent Donnefort , Sascha Bischoff , tabba@google.com Content-Type: text/plain; charset="UTF-8" inject_undef64() constructs an ESR with EC=0 (Unknown) but does not set IL. The architecture mandates IL=1 for EC=0 unconditionally (ARM DDI 0487, ESR_ELx.IL description), so the injected syndrome is one that conforming hardware cannot produce. Set ESR_ELx_IL in the constructed syndrome. Fixes: e5d40a5a97c1 ("KVM: arm64: pkvm: Add a generic synchronous exception injection primitive") Reported-by: sashiko Signed-off-by: Fuad Tabba --- arch/arm64/kvm/hyp/nvhe/sys_regs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kvm/hyp/nvhe/sys_regs.c b/arch/arm64/kvm/hyp/nvhe/sys_regs.c index 8c3fbb413a06..9767adf1f73e 100644 --- a/arch/arm64/kvm/hyp/nvhe/sys_regs.c +++ b/arch/arm64/kvm/hyp/nvhe/sys_regs.c @@ -278,7 +278,7 @@ static void inject_sync64(struct kvm_vcpu *vcpu, u64 esr) */ static void inject_undef64(struct kvm_vcpu *vcpu) { - inject_sync64(vcpu, (ESR_ELx_EC_UNKNOWN << ESR_ELx_EC_SHIFT)); + inject_sync64(vcpu, (ESR_ELx_EC_UNKNOWN << ESR_ELx_EC_SHIFT) | ESR_ELx_IL); } static u64 read_id_reg(const struct kvm_vcpu *vcpu, -- 2.54.0.1189.g8c84645362-goog