From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CFF5286425 for ; Thu, 18 Jun 2026 13:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781788865; cv=none; b=bmQmYlflzcl4WoGD1LNz2UWdGi5/KZBo27m+QpxSqWZC9teQMI+PlrX9zDzgOLtBj3oiq4tlkSRLivFeNW63h+2z2ndnz8rBbVP38Z3ujJvcHvgui4z7TUU+iHLQB7+lgdAfL0AwmSdF+rDvyJ0yLyqj1xSrF/8Yu2tbccgD2M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781788865; c=relaxed/simple; bh=vNBdjxlU+ppYVxObjZABSBqUOEIF651kxgmpq1PcnqU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=j838SRjDx2l7jM7vLc3Ht29qzKot3YNCzPd96YDHQMi6fZcs2FL6bsVi04fOO1EOnKVDBuFyZq5J8E9W/DsyAvzvQzcq5bvA/iYgsiT6MbzxF8CVVR59mCM8NsUK503Pjaz9sGX3JLSDPGkBg+jH5ohjsVYyYg1mv9tu1kISeXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KfXKKsdA; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KfXKKsdA" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-36d98b68d68so526234a91.2 for ; Thu, 18 Jun 2026 06:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781788863; x=1782393663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iQcnBImPBTtnYmt9WXdAtfeZcsf+lPgDW7RAiTWI4cE=; b=KfXKKsdAbIW8msXI8bm7oncfKPtllmcuaTGN20eeD5EQdlcSgcWTl93mmuRCFEen4P WxFIf9C/SonYRBZMhMVtjcstUfMBmFJ76ehOYQ/inIFpULAlFXqfVf07Ikg1SGtbNNYU fNdH4kDIK+U5fBEMgxrPsgft4HJ8Y37iUi2S+lz0sD9ZgvmEmhoo9i60qnD9w3icM7VL WIiw44GQb4EWC7K6LIlKN+AFeMZFC0SnVK2e0tRGX+DSr3WwINIozAfpZ/TYm3NBhLXp Db0JmwGXd6alScTqn+QRCn7EEHeqGPkcAGqW7+/ciraUO/48l1PWqXmonDxr02cIIOcn sakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781788863; x=1782393663; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iQcnBImPBTtnYmt9WXdAtfeZcsf+lPgDW7RAiTWI4cE=; b=DrhCPVCNTXu4FoQkpUegs4rVEsFvQVCofaXWPnyqwh1L5CLN7zM2tspSJi4UKQUUFv qdMP+XcRzwX7SfKG5t2hUGzMedwEKhTRKjnT2djoxDxIaIdwWmNC1CpAX/T+u7k7G7bj YsxfzTmiOiS5wzExaZDNzpyFVy9b01Wi9aPIlG+7Zt0Q3TsZRntrXiE2wpzHnetaYUgS AZDCEV5cpDDuM2Cr+DDwz/QkdDYXpgmTnmnQnatsNiyHisBLhvRGULPSMxhzdMt0IfUc PVXh9kS8gDdImBwd3bMfGlavaGHTisgnqLkB+VDDLpA6ZpZOUFqU+Al5uYWPCICbcBWB yw/g== X-Forwarded-Encrypted: i=1; AFNElJ8CzW1K7cc1PoqeTdN4gheLjaN/HM/JyXKqm4DZaoPUsoCxjbs7ectEZ5/qwVmeoUW9DpGn+v9YzXtkdh0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmaFGCtqqN6FJ5nW1jGSsGlpAMo9LYCsj/m4PhR9ejORlnMOci xJrNbbCyHspRNbVDUtQDulWtGwFeVZ38COK5gQcDzz5qoR3uNdX/m1GN X-Gm-Gg: AfdE7cmjYMRMSFk0wNkhYvnRAVUKdsXtWs00OPsWHWHMXj6YZggLbsFDv74uAHf+Z+a dnmpO23GLKdvDbtGmI/wGiCXdPKfe2BVNZMOyruAyxFp9vnvhIrsroMhJtNsjIByqts27BsXJW+ zlI6j+nUAQRLzOs0Pn+v8wvGMgcX6ot2sUsaocNJ2Lu7/gOh3eTd5sAsr69LzkzD+OeS2j3j9T/ 9t8q4BvfipA6RE01TOI1nu411BADyi9SbDs+5hMagn4wpJZ/DLIDmCuUhwpZyMcDwUORXWAbymu cZhmNrvbEUX75Pga7XVtLGLFneWFud1fGbd2+t77CV6f2u/5/xvnN9gbhx0HH2gKCK0Woa8Pp2Q NRR5raAWfPZtJ01X/+MG69FK6SmjiiF/nb3iRDcW2P2wlKhFSg2icMF/TlN4/IwPO7AOfPJGKLc AvV/jHZJeN6CzkQ59CXu3fieuogsIphtR2GrKcAOaQ X-Received: by 2002:a17:90b:4f49:b0:368:6998:b4a9 with SMTP id 98e67ed59e1d1-37ce4537d59mr3751785a91.11.1781788863063; Thu, 18 Jun 2026 06:21:03 -0700 (PDT) Received: from steellegend.taila75641.ts.net ([2401:4900:1c19:e45:6f99:fe25:8bbb:3a22]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37c5b377e43sm8256956a91.10.2026.06.18.06.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 06:21:02 -0700 (PDT) From: Uday Khare To: andersson@kernel.org, mathieu.poirier@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Khare Subject: [PATCH 1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev Date: Thu, 18 Jun 2026 18:50:54 +0530 Message-ID: <20260618132054.11010-1-udaykhare77@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In qcom_add_glink_subdev(), the device node reference acquired via of_get_child_by_name() is stored in glink->node. If the subsequent kstrdup_const() allocation for glink->ssr_name fails, the function returns early without calling of_node_put() on glink->node, leaking the reference count. Fix this by adding of_node_put(glink->node) on the error path before returning. Fixes: cd9fc8f1b35b ("remoteproc: qcom: Pass ssr_name to glink subdevice") Signed-off-by: Uday Khare --- drivers/remoteproc/qcom_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c index fd2b6824ad26..8af90d4bdbdf 100644 --- a/drivers/remoteproc/qcom_common.c +++ b/drivers/remoteproc/qcom_common.c @@ -247,8 +247,10 @@ void qcom_add_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink, return; glink->ssr_name = kstrdup_const(ssr_name, GFP_KERNEL); - if (!glink->ssr_name) + if (!glink->ssr_name) { + of_node_put(glink->node); return; + } glink->dev = dev; glink->subdev.start = glink_subdev_start; -- 2.54.0