From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CD692ED846 for ; Fri, 19 Jun 2026 07:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781852579; cv=none; b=q0iRkO5bUU1LXmxWNVrPCj1cxkG8eNxUA5vswVd6wUHT/Br1+NKlGUVANbkYbydAIl//Wj7NQJV4DKLzONVjQ6A7KXHrP+77JyUg6orQN5QiQTQAQvkm+LW9ocClC5uiahiOxLLUQtnckpVTXPH0smP9sAi8y5SwMuVSZ1kld6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781852579; c=relaxed/simple; bh=vpWFELe0+d1i0P63tAcIfowWODUvkR9U5/n5BmjNL7k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=NcdW7ETVLcjkSqQWsaV0/AtUK1hs59f8Eaia6nVyi827JKmkakF/3liDueCJ9URf88KG3UoB//KvTVxjQ9quK01rqhiRiGzvb7km4G4eOLndAPpsJeH3xgqgKa0wUfN1Boh9Fs1S/hm0wTkoBRPYPgOnfsPIj3ura3ARgntECX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dCwaUDkr; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dCwaUDkr" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 91551C06CD4; Fri, 19 Jun 2026 07:03:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id BC442601AD; Fri, 19 Jun 2026 07:02:54 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6D28A106C81C6; Fri, 19 Jun 2026 09:02:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1781852573; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding; bh=b8jFrKfRx4ipfCPfX5aq84hRP0+B67EcAHf3pzQ4YTw=; b=dCwaUDkrLLIcRV9ZmJaM9t/39llO++sqZWMDkYbTebHJLvAiHWAwxTRbNOA3ozF8fjpduT sPwIxiNXrxztG8vW3HxN79sBPJUp2HUWJNfe7fF0uZ07Y5RIj+TmORxGI8GiBVYANoHqSS P7p4TR+V66s2VWZWiLQfGMS4h45NrkY/Z6+DcEYYOh8cE97qZ9pQn6SwLvy5BwLZA4/fKw ALR8pRpQFMaFAgyuYUoUf9ZpIdbJbUcmxLCp9V7mn8gOoKgZQC1tXtckx7+uQuEqlU3N0i l1fJp+0eWnCfiMr3KOkZiXuYahPtSiTDLc75nuiUT0Ty84SzYaHU3IEkNMKogg== From: Luca Ceresoli Date: Fri, 19 Jun 2026 09:02:13 +0200 Subject: [PATCH] drm/mxsfb/lcdif: don't hide lcdif_attach_bridge() deferral messages Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260619-drm-lcdif-deferral-msg-v1-1-ce2392dca985@bootlin.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMwQ6CMAyA4VchPdtkgziCr2I8sLWDEkDTojEhv LtTj9/h/3cwVmGDS7WD8ktM7muBP1WQxn4dGIWKoXZ1cMF3SLrgnEgyEmdW7WdcbEBum0DnHBv nI5T4oZzl/Rtfb3/bM06ctu8NjuMDqM9MLnoAAAA= X-Change-ID: 20260619-drm-lcdif-deferral-msg-e736d5fb301b To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Luca Ceresoli X-Mailer: b4 0.15.2 X-Last-TLS-Session-Version: TLSv1.3 lcdif_attach_bridge() uses dev_err_probe() on all its error returns to store a specific deferral message. However its caller lcdif_load() calls dev_err_probe() again on error, overwriting the specific deferral messages with a unique, unavoidably generic, message. Make the specific deferral message visible by using a plain 'return ret' on the caller. Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c index f5bb59cd5028..e2173c4d6fc2 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -186,7 +186,7 @@ static int lcdif_load(struct drm_device *drm) ret = lcdif_attach_bridge(lcdif); if (ret) - return dev_err_probe(drm->dev, ret, "Cannot connect bridge\n"); + return ret; drm->mode_config.min_width = LCDIF_MIN_XRES; drm->mode_config.min_height = LCDIF_MIN_YRES; --- base-commit: 98b46e693b912eef0e6d497327489113845cbd15 change-id: 20260619-drm-lcdif-deferral-msg-e736d5fb301b Best regards, -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com