From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82C1C2E6CB8 for ; Fri, 19 Jun 2026 02:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781836300; cv=none; b=KHRxoNX9ANAyeHmZwPNWEewAj8e5wjkbJWQAw4f/P4h+Linx2FpZp9rJkMcEAvgrkhkPcvXxSBJawA0grBxTq1ML3M2yTK9jqFX8skmG/f1wrv6kmbmtXk9T+Vu6o5GMw8gOQ93U1bsodpMPs9ZnRIFUrKZFLJEglC+GPFwPeYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781836300; c=relaxed/simple; bh=XTRiVofuuvURnPJizagKNJPpNDhEXFZPMrC8i1La1bY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UexWUpSqKKSFPVYSttE4idVxCcVUCDFxy349KUEEeHbnc7dmAJPr3AK430NUHiRTT9XoscQ4F+p8PZc4cCurvGn/t1t7+vO6ygpiIr1aKmTFssX0qyDYsZnm9SFUGmhMi0ohgWtMuEXU02aN9P5nLwUfh9pFsRL41dwwjnW0QIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b39big6a; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b39big6a" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490aaeabdb4so9273435e9.1 for ; Thu, 18 Jun 2026 19:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781836298; x=1782441098; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lAiZnN0PO6pqTF6376JT7WwOecYF/RxS/5CZpEWZeKY=; b=b39big6a0vzAgXE+YvlrMStaYc1FEcl02enTEf10H2OxB0zNeCbrSduIDrDh9DxAw6 7Ayse3MCRvqSYG+n3KPL2y+99HXC8EOxGooOavu9DNEXJmBoXvP6W6RKm6ZSZbBFSIsE YwxHsecjemOaC4h2GX4bK3GhFNHzueL5vReajEwDhjugtD5TGlN2ULg6nV2hattGTBlX HqUH6YYH4kDZvlHjIPHCWxd8RjJtqWT+tHtSsVoYT8iAfHUWgSg7qfitE/2R/UtoF1sj T+mnWcNCH25lpqysq0QVPI6JH5dRQ2v0WusJF8znLw3UupjUDezeLUOOg/6MJs0xwWvm rRBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781836298; x=1782441098; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lAiZnN0PO6pqTF6376JT7WwOecYF/RxS/5CZpEWZeKY=; b=IDnxLKzZhlZKNxa2RLgnAKd1bCeNNfAWvqdTjXtyNVYJQZpRQQCVHCIxQ33sBT15oE e8Z7AfQfI8v14uHbqCN75/JUhevAMZNnNQwoFenHWkbSVTWr8s7uJWSpYTw+bSmM/b6m f29alL/i1SKFz6pW5H4+BcnJs3nm0nop2BULTyFOSMY3HjpLBG00SurPVocWl48JSUbf Q3fVI4gZf2fegDuQ0Duw9Hf0xUmcz5B9yygBZkilulDy3H7x0p1Gw+PeYsvdE9L+RNLV 4LESuARlG+SZeTBceCibJNihNzZPHEe75G08C+UP+hOeYHmPpGSTGUCqeCcTajoPWbBs 1Pvg== X-Forwarded-Encrypted: i=1; AFNElJ842btqG0NgXRHYgdrrcj/+eaCBxtpa0MZFdTOGG20cTr1er+8jaxRTW5zpdrmwLmrPyONNnmzWn7L9LVs=@vger.kernel.org X-Gm-Message-State: AOJu0YxCOtoNxQIv6F3c70qxV4N950RnYRWQYVFPtTiB+wnv/6kFlU3I IUdBWvSYpHEPSa65eCDWzhLGKfsaf+YpNJzqQ53DuIMkxUNwB1D68zz/9e+gVi1MKwdOwPn5HCo = X-Gm-Gg: AfdE7cnNSLuUwbPTwSF35wS7FN1L49JiA3uZ1BBguZ/suGHBHJ7SkKwYziIXauVJgmb lTNhhX9udcb4+rIkMoFxkdowzoCI9C9akrTZnVvxsvksULevFVVdiBQ/mLONQZvRjbfBMV6BCTc PWg9HCXEZy39EHV+IXcJhjWUsQMcySJ5IgGlJI0UWNmGX9OLC4NGR+VaHdh/wrnB/EamVnW4I/v Y3gQkaGx7/bHB7tHwT+0BldLAFuc4rm9Gwx4zAeQVSAjoDQacOG7XfLbvUDTT3+oa1PJ6r6+/gm 1VsuK9ZI83wykCVWTM9h2bljRBYgVfscsEEGm17toK0tzgwdXyTIOYWYCuTJHxkR/mvjdmJRYoq JQsma4azzTGJD8UUkrVZnjSHW21mOiZU2iPOEzMbzkawCG+CcbbWsL7csdzc1bO66am+iNQGtEN 9IyNnxAMPV X-Received: by 2002:a05:600c:34ce:b0:492:4335:4d4c with SMTP id 5b1f17b1804b1-49243354dd2mr4346835e9.30.1781836297675; Thu, 18 Jun 2026 19:31:37 -0700 (PDT) Received: from adr.. ([185.252.220.117]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4650bc41d01sm3558121f8f.25.2026.06.18.19.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 19:31:36 -0700 (PDT) From: Andrezinrc To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Andrezinrc Subject: [PATCH] staging: rtl8723bs: remove redundant kfree check in rtw_xmit.c Date: Thu, 18 Jun 2026 23:29:38 -0300 Message-ID: <20260619022938.15691-1-andrem.33333@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the redundant null check before calling kfree. ccheckpatch reminds us that kfree(NULL) is safe and this check is not required. Signed-off-by: Andrezinrc --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 7bce0343d..92e818705 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1736,10 +1736,9 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram pxmitframe->pkt = NULL; } - if (pxmitframe->alloc_addr) { - kfree(pxmitframe->alloc_addr); + kfree(pxmitframe->alloc_addr); + if (pxmitframe->alloc_addr) goto check_pkt_complete; - } if (pxmitframe->ext_tag == 0) queue = &pxmitpriv->free_xmit_queue; -- 2.43.0