From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F40340D579 for ; Fri, 19 Jun 2026 06:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781850645; cv=none; b=u8nJw3u5qu3nbdLKBgyw7jIpCTsZoonKgpl4M3Pr3QwU0LtjvxfwbHyLORv8yLbca11BEWBMFZ9vSVfAMwDTvLPXUr0EiuNLnX94GubQ9U2DFlej8ygGwPKE9/ftqo1t3WHm4RuZpvRWS4j+SlQBPUdUw3klvdxxz0ipOjBzImQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781850645; c=relaxed/simple; bh=TqQB867N86wSav4oIi3xoeqdmuIgWtWi0oXKIdYe2EI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Oj057NV1pysrtQrxGpDx6u7kxQjHGr/LAXh1KNLRN84qePMp42u9nVMhfjJxUF7c/wViGCSN/z9D+KUF5svaL/1OfjfNlN4QXLqWyLmo9J89/lbBWXV5c1UUx9vJb1aFsfnf+xZADRqPQz6/jnuyJ3V0GcrNe6af+W91HSptzzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ca/8b/f3; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ca/8b/f3" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-842848fd613so1634165b3a.3 for ; Thu, 18 Jun 2026 23:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781850644; x=1782455444; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=h1/ArZBR8AclmPo2AgBuJ0LqA7c+rabIabH9ua++1ms=; b=ca/8b/f3/E8ohvuXtS3L5Hrv1r+ikHr72uMY3Q9DGv/viCyjrs78XSNaBRyFs+4/NM EHBLWEuEWP31lHXzMMDljO8fEeQ/fntQHRjhlfDMMloNL+51qLRKjwicGqtizAPx7lsu UxKCxxW9RFWoY3bZOfRs5eBD9AvHn7Cn0eZg75aGYKoEzNs9+xF/p/5Pwl0Im4HRz08O xWakTuJdEoEdcbtbiiBFAfInz/q4xXW7F4DMywZBllwhgSvDM6eDC2xWX5mITRMEg067 SP3p5LzxljLCVigXuVY69XFtLkjqFtQiHtsQe24ggVJBDqE/lwQ6giilFr1nUnQ38doG s4Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781850644; x=1782455444; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h1/ArZBR8AclmPo2AgBuJ0LqA7c+rabIabH9ua++1ms=; b=Ch7E3fBNkehVYronJHApr7aG81Z4EmifA2O9sVLtwG7QYxa3deJx+ZMKvLkoB+caVv G1IROhrjacr0SMEw6IfwTbQM7THsQN71OBAk2NMCzi5dtJpKSKlhnCCFFJQlyOlEx3QL jTwh/hj479VoxDnodsog6dRumwPxOr5Rr9oy/WT5EFfzOwq0d+VEGHBHvLGWwL2NdZNg 0H6pgVQSj3kTjMJ5lckaSubkFD4mO7Z6VjBpBIRbrlxyNwTdgjbfkr+5JP8KNNAu1Gv5 bVkka94crUKstKHyXWqAYNqhoGmBCwm6dCfTHlIp/DXpQ29KVBFg8CwU9VKIgbXc9Bmd +U4w== X-Forwarded-Encrypted: i=1; AFNElJ8k+Ft4gH+p06sQsvOxHI5AZeJVp7j5ejCWxEbjKcb0HpGnsVI3MrRY+4Qg9QvH6Xjs5IuXr53h5n0Z+SU=@vger.kernel.org X-Gm-Message-State: AOJu0YzXRRTqRvyXWDRkyRFkWx8kjESLjO1SD2/I3eD0h6ST6BbUWFtN gm1Wl3dRbNwXozMSnbWsIpjq2cwqh4Ce/87Nx08D5lsfXKZ0AMawxF+k X-Gm-Gg: AfdE7clXGwmjfyXw2HomucGCLYQeyVShgqaRtzef9hwc2A1uISLLWtb83PzaM2Qt03y z6XYoOto63H0yndhkVlRWsOTsGNf4cGGvcw5dqTgRuG+fuPot10B+QrKwePLY/e6jrj7rzfEhCp /C82X5PHeiR9DR4YF/IE8WMbZIvZUZy/1TUE23tr6dNM15kmYRTmL/IlaTvTqcJXfN3qYaWavnk LC0erbWZyLxsLaWgpCndgSkdrW2YuUtHIZrFCX9d8d6WiuSc4dSzgAjm3UlhecGP4G6ludHuiOQ LK3dfF027+uURrKJ1PqvCOlUaIwN1VFKmsWo3ztWShqRp0XPfB1akGlvHQGVeD4M6FeHHIICM8U gRAbnzRydW2gTXuXO4lMQiqDxrwUjUZ9V1xhoOqE2e3evbMOkmex1+/D40PkEbAB27H8/4u3wlD eqzIpwLkBpH4hzsGQN0gcH2Ta1tZg6GGboKXJWfyauKQW49xdR8UM= X-Received: by 2002:a05:6a00:1a8f:b0:845:3ffb:ac2c with SMTP id d2e1a72fcca58-845508d71bcmr2333443b3a.46.1781850643354; Thu, 18 Jun 2026 23:30:43 -0700 (PDT) Received: from cps-manycore-1.. ([147.46.174.222]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8455382b886sm1380096b3a.51.2026.06.18.23.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 23:30:42 -0700 (PDT) From: Sechang Lim To: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Eduard Zingerman , Kumar Kartikeya Dwivedi , John Fastabend , Jakub Sitnicki , "David S . Miller" , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Kuniyuki Iwashima , Willem de Bruijn , Shuah Khan Cc: Jiri Olsa , Martin KaFai Lau , Song Liu , Yonghong Song , Simon Horman , Bobby Eshleman , Jiayuan Chen , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH bpf v4 0/3] bpf, sockmap: reject a packet-modifying SK_SKB stream parser Date: Fri, 19 Jun 2026 06:29:49 +0000 Message-ID: <20260619062959.3277612-1-rhkrqnwk98@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A BPF_PROG_TYPE_SK_SKB stream parser runs on strparser's message head, which can chain skbs through frag_list. A parser that resizes the skb frees the frag_list segments that strparser still tracks through skb_nextp, leading to a use-after-free. A stream parser is only meant to measure the next message, not to modify the packet, so reject a packet-modifying parser at attach time. v4: - drop the Fixes tag (Jiayuan Chen) - drop the unsafe skb modification from the test prog (John Fastabend) v3: - https://lore.kernel.org/all/20260618102718.2331468-1-rhkrqnwk98@gmail.com/ v2: - https://lore.kernel.org/all/20260612123553.2724240-1-rhkrqnwk98@gmail.com/ v1: - https://lore.kernel.org/all/20260609112316.3685738-1-rhkrqnwk98@gmail.com/ Sechang Lim (3): selftests/bpf: don't modify the skb in the strparser parser prog bpf, sockmap: reject a packet-modifying SK_SKB stream parser selftests/bpf: test rejection of a packet-modifying SK_SKB stream parser net/core/sock_map.c | 20 ++++++++++++ .../selftests/bpf/prog_tests/sockmap_strp.c | 31 +++++++++++++++++++ .../selftests/bpf/progs/sockmap_parse_prog.c | 22 ------------- .../selftests/bpf/progs/test_sockmap_strp.c | 7 +++++ 4 files changed, 58 insertions(+), 22 deletions(-) -- 2.43.0