From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0964031E842 for ; Fri, 19 Jun 2026 08:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781856705; cv=none; b=Zbp8INJgkBnlUcycA48GRQZ90hEvFVY7G1KjId1fchyeqv6WweQVmNkDeOuPzRU1E2F82wAw1eGId4B5G2Wtyea0JwjWTz0FodhCu/7DOk8QXcvVPXWVs4y6qfAuq2PY2Cfq9xP6rOzb1sOD/kdTcdrV2VEw6v6aQRTXIaqo5BY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781856705; c=relaxed/simple; bh=NDbOLScMl0/An9PN63TkxGRmRSJ3jMWxr3my9fbJMDk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bqXgNemtr0f3de1Nsxhw4v++jolgIUY4v3aSvpc/PBN67WV0Z7+cQr/vz/zp+jIyv4NlBCBq2nAeEHRfBbK5zBm52EeX+SeZk9qJ7cBsLKEL4ffRnRLJc71cAwndmcBKMIbP95jvTra+BukKNh6TMSFnr7RffXpPrS0Pp2O5v10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HM/ppNXo; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HM/ppNXo" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2c0c1e0d00bso19902355ad.0 for ; Fri, 19 Jun 2026 01:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781856702; x=1782461502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kGXrYKZAprR/5Pxk3naVQXCF2pKtZKstOHwH49PRnS8=; b=HM/ppNXoRwJUyHerJoF5zhnG86GMeY5FJUm6h4v8tZz+otL2im7CZaHMpIgPmVnFK4 R/9Fkf7U9E9F9IMYgKFlo0e68/XlZB9yZ9nzk5fwhmRVN2JVxT2ZNb8pH37gpFDDorwW oGOFnZSUazABI8AVfr7qFLlbsCDCSx+g5DddSzz2qp8QuHfu02IVyoh3HrJRkOUXrn0L OW9jaaA2/WjXa4kB1uwRQMe9NLQN8Q18pvOsGZ1I/AN+dhVNFn115+hrAM7QS18nj4EH OT1ObqpMa7mN8h4uxoHQ5xRqDQghuwXRYYjHBsQr5MKbHjJ2sqAfdtdFIU9F+Jz+9ik2 DxDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781856702; x=1782461502; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kGXrYKZAprR/5Pxk3naVQXCF2pKtZKstOHwH49PRnS8=; b=VgZLEAb7w/SQrCiMW7FLwWu4FjoYFirz9djEN1eG1Ztl7KCz9m4vtWteTHiqLjr5HZ IlWr0JZe0npvgKOMnCX/EiTSgc+buOmj+LAl43NgFUECfKqcE7NnCZoH6OGcC1hmCefk h1HeBq8kQ8gSL/6Ww+EnnGYEw7mX58U93AFZqqUSXfk/kz14AJE78h6I20GsuuUVL4iv Sj2NDLQMw1vuOO99JAEwEa3U2tCONYEmvmdair6CIpuaXTBSesTfvy1fRdQgrNEGwUdo UGVSpumKIeXoK+VLiD+XT5Ui0rVVsHaArzcG+oj57m2ATRXD3ns+QvQVnDSd27DGD1/S ubQg== X-Forwarded-Encrypted: i=1; AFNElJ/Xrar43l2ocZPzLvmuM3vIqkh7XNNGJNfjsUb7tbOyGgPKKKGEdf8NqUQSuRR03S/grOHNLA6Kfc+b7Ik=@vger.kernel.org X-Gm-Message-State: AOJu0YyEf1HqchPoZsW0JBZOEJ75qayE+BZKKSvgoq2myZQ/YFY7bcL9 Huzd2wOTdUy3R8zGg/Gt3xe9b6PdiKN/Edni3syeRxFSonXFAOZEahF7 X-Gm-Gg: AfdE7cnmwoAvr78T5zNzxdU7FUbOYmgDgOfRvuRUHQ5X9wdqehb5J2tqtezD/04i7iC B2Rui/THuxk+drK26HW5nDlAbLYHD0MffQwSQUrRExaNlr6pX/s/7ewY+HVl01JRi+ZrM74BnsR qksVO8eP0I3/PUfwj9j30OwEAqyP30BqsGTGAvn1brwUpIbm4X1VoLpMUK1WwWwHgyejH3xJBrx /z80ChGR8jOzNhHNqxhWH3g3ho9vUxonJWYBSV+QmwkgW5uN0+snCMXD9mB6ZoTK+dCW2mLQHSu TndoTYlZpEbqSwm5p5v7u39PPycYvB+CQeOSm59OToYqI90oK9p2gw6jCKY7+KYVOl8OSdw0MMF z+HduUlA/PWyNq1Vx04HeJx7jijbP7jzK4S7Ly6OFHccFO9hu775cUdx/QASb/A016aqbXDXJNc xPNOj1JmpfSDU9T0pIFjAGsbS7gNO9YLfcz4C42DmwIA== X-Received: by 2002:a17:902:d54f:b0:2c1:77cd:fb0b with SMTP id d9443c01a7336-2c725df94d3mr17309855ad.37.1781856702379; Fri, 19 Jun 2026 01:11:42 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7209e2f6fsm14797215ad.59.2026.06.19.01.11.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Jun 2026 01:11:41 -0700 (PDT) From: Biren Pandya To: sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH v2] media: v4l2-core: Fix memory leak in v4l2_fwnode_parse_link Date: Fri, 19 Jun 2026 13:41:30 +0530 Message-ID: <20260619081129.18485-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In v4l2_fwnode_parse_link(), the remote endpoint fwnode reference is acquired using fwnode_graph_get_remote_endpoint(). This reference is properly released in the error paths, but it is leaked on the success path. Add the missing fwnode_handle_put() before returning 0 to prevent the reference leak. Signed-off-by: Biren Pandya --- Changes in v2: - Resend because the v1 patch was lost in transit and did not appear on lore.kernel.org, causing CI to fail looking for the message ID. No code changes. drivers/media/v4l2-core/v4l2-fwnode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c index 77f3298821b5..93ef83c591ef 100644 --- a/drivers/media/v4l2-core/v4l2-fwnode.c +++ b/drivers/media/v4l2-core/v4l2-fwnode.c @@ -633,6 +633,7 @@ int v4l2_fwnode_parse_link(struct fwnode_handle *fwnode, if (!link->remote_node) goto err_put_remote_endpoint; + fwnode_handle_put(fwnode); return 0; err_put_remote_endpoint: -- 2.50.1 (Apple Git-155)