From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05344330666 for ; Fri, 19 Jun 2026 08:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781857260; cv=none; b=PndZlpKtZfKWPdRcR+QjDDkgGAkr/V0f4VIlxRO4Qms6ulB1yB2RnXp/YiBphqIZ376PSsr4ZRENSoKP71MTYv7EkZaXEgXMkvsRX0y5+dz5h5eJrkwzgsHjsE2RqP2gRuHGc/qVxumgEnsZYM3ldO2AMGXSGujrmikAnZ4OdIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781857260; c=relaxed/simple; bh=ydiGOwSM6sCyeXvuigf+1Z/T6D1jYkwqpJFns/NdVUI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZT0C+7C+PrE/CRk+BePBji7tXbJsZ0qYCmcLRGdUpP0MdmHhPAVDb2TaRko7BSzKWWc5HkhZmbLkzs6yunrbF06bQ84z/cAqbMXjd30BD50kADT+WD0DAuxK98uLO/Cma3ic+5jC5z53+0jDxjawYHLitRfDTHXXPE1SUN39mz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LpfhouKF; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LpfhouKF" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-37cb36ca63bso1031535a91.0 for ; Fri, 19 Jun 2026 01:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781857258; x=1782462058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RNS6wJpP7LX6d8zPRDeMYS3lftvPnTrBkw5G+97IGIA=; b=LpfhouKFnmciwMh33nCinguK6xsfgDpCmJzgHbY1m/xtuhqJcOB2xCeGDUQH0l6Rx+ uYgwW2h0SMKoJeFcTPMMv5pUwTYWGhzP2c/I4W4+JOsx8gMyP7xyE2VKQPmWMVvwfyqI owVmXz/4qQF1LCvtxfKOoaaGPBkGORRH99ImZm53dE6u8xe0dX1Z/Q1/ayjd9XhY5hDR 7jZwQSf+iwFacYzZeP8kbQP2LaYCayr3llmTK8scXC7VM1ly/d9wuBPn+Abh3mSLuluy OLQ8+HAI2MD9EbaYv+rhK8RqbE2K6rzhtuuVCi12abOlL29otX6tXw31bj7wTJ2xzWht yr+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781857258; x=1782462058; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RNS6wJpP7LX6d8zPRDeMYS3lftvPnTrBkw5G+97IGIA=; b=B0JBOVPuSBVyyXEaQYEGMM2gTt/Vm/lh4r4I3bGmmIAKAhrDQUCFcJA0yqCVL495Im t2mtPOJ4k2k4QQKJvhzu3/tkrbjFxRUiXInjYkbxKsLfDPKHezNmPrDFFAYIk3JDwWj4 3K1u+f/rQz3JCMCUrs2PvJJKaWCdt1vs76xGb8rzsTrtR+kqP/jYRdb77CwYOjJzgWGl QmXFRtHY53noSbMmBuB2tPQZw3QLqhdh+X/1PLz0i96/nq2H/tLecsBXFJfWIlL6AKVI uHHIvnHJ+aO/ZH9pP2ppsLoKXgBr3SFQGowqZLJx34gWe/EtGB/i/HqqC+A4hHPjVeos PieA== X-Forwarded-Encrypted: i=1; AFNElJ/tY6I61aD4TNtlvCnnnSS+gOp8vL2i397tbFeH3jYDqzwHS5r4NmbrT+nHN4fMPnkwZEmz6Oc9X7NXvRA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7s7Eui9m2fma79YIpbKR0GHvj4525opMqbUis439mITuTDxs2 1or9qnlH3C2LwlzmPWl1oaSxk/amlOinuPTXdv34ZP5Jh/D2WX8mI+32 X-Gm-Gg: AfdE7ck33OlovLLHB7ZM6L31drUtJxe//g3XzjmY0TzK3Y1J5ARv+fsjuhmCDtjoabb H5s/XGOrgcdptOEDms2DdUKNxuto2STiJQqUYCnwZNW1fs8fNV8LjBP4QZFFwGCB/twqvjxts/F 8i0k8FZf2claianE0uRX6UHtVQkpqAS1ywTXgAWUyNtiWpr9uN7op47yFK1kdeEAtr1dssdxNsa KjJF8cI9NfR8f7gK6zzgEUXWgsQMEl04DDjviWHtVPJMs8fBJjxTiwuSOY2sMCkXkEI72Sv2eOl YYFtgAGHrMfNPZC6G57nauwEZRtOtGy3wjtp/029ZKBtGqEneO/Xmw7tjP1HVpRcchT0zrq+3+T Xu7sHKimzKB2EZW3COw8B9yLkgLXBWOtF7nlaI7k1mcVgeAeZSZB0wbNLZf6ckr13PAGXTGMaQb IJbNB17IHg8tG6H24KkPhb9YL4wKq1GxFOi9ekzWOVyg== X-Received: by 2002:a05:6a21:6e88:b0:3b4:7c33:296c with SMTP id adf61e73a8af0-3bb35648fb6mr3237106637.45.1781857258021; Fri, 19 Jun 2026 01:20:58 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8a88dc66c2sm1791968a12.24.2026.06.19.01.20.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Jun 2026 01:20:57 -0700 (PDT) From: Biren Pandya To: sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH v3] media: i2c: mt9p031: Fix Use-After-Free in mt9p031_parse_properties() Date: Fri, 19 Jun 2026 13:49:27 +0530 Message-ID: <20260619081926.18855-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The mt9p031_parse_properties() function calls fwnode_handle_put(np) to release the fwnode handle. However, immediately after this call, np is used in fwnode_property_read_u32(), leading to a Use-After-Free bug. Use the __free(fwnode_handle) attribute for the np pointer to automate cleanup. This allows us to remove the manual fwnode_handle_put(np) call, ensuring the handle is only dropped when the function returns, thus preventing the Use-After-Free. Fixes: 8d4da37c3006 ("[media] media: i2c: mt9p031: add OF support") Signed-off-by: Biren Pandya --- Changes in v3: - Fixed the incorrect commit hash in the Fixes tag that caused checkpatch to fail. Changes in v2: - Utilized __free(fwnode_handle) to automate cleanup and safely fix the UAF as suggested by reviewers. --- drivers/media/i2c/mt9p031.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index ea5d43d925ffa..3b3714b0ef8f3 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -1067,15 +1067,14 @@ static int mt9p031_parse_properties(struct mt9p031 *mt9p031, struct device *dev) struct v4l2_fwnode_endpoint endpoint = { .bus_type = V4L2_MBUS_PARALLEL }; - struct fwnode_handle *np; + struct fwnode_handle *np __free(fwnode_handle) = + fwnode_graph_get_next_endpoint(dev_fwnode(dev), NULL); int ret; - np = fwnode_graph_get_next_endpoint(dev_fwnode(dev), NULL); if (!np) return dev_err_probe(dev, -EINVAL, "endpoint node not found\n"); ret = v4l2_fwnode_endpoint_parse(np, &endpoint); - fwnode_handle_put(np); if (ret) return dev_err_probe(dev, -EINVAL, "could not parse endpoint\n"); -- 2.50.1 (Apple Git-155)