From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4FC3EED8 for ; Fri, 19 Jun 2026 09:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781860428; cv=none; b=nmglTOsUWXxgu2g/URhdRIFouc0nOdq96YcWqr8wiMd8Tyipc6At852YGjBUELPzqlq2iO2e9WyZFevNXDPJILEVBXQnyy9urd+NB7QM5hYNCkuZk8Yal0Njz1rSjHjzhUo5ItHrtBSI0jke1DxdYBVWKENHHTDDmeiQCbCsM0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781860428; c=relaxed/simple; bh=A4R9hM3zphKIlQy7fSKobMGGuksvhH2HVxuiJVlmIPE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YKy/W34cSFRvpFJduIib9VrxoVrJeR8OEY5eYSS2S0VdaDbpvtCvnLNbjOcb/JvY2Zfv76tPrULV0UZdYySrzYP1xKJhuWdn0MZQ5T4EOxe7hHwDQ+XPgnptsAOZ8M+CRC4MK6GYK24HjoioTsG+xVA4t0LaMW0Cl2n+JuO5frI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j7AvMIWB; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j7AvMIWB" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-490b9318997so12873615e9.2 for ; Fri, 19 Jun 2026 02:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781860425; x=1782465225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IAQ5csjl8oxIj8s6D8Km4LqE5SyKx2h6r4DVyh0qIFA=; b=j7AvMIWB1jJ4WC2Prm39HGJ9k7qn0II+GE74dUgNsD5kMCvve012R6/Mgd81rOnbrY +URJzYo6rGBfZqawrUPoETfE2DrL4pw3PfrgJsNsg3Wt3x6AoDscvvUrDecoI8uJ90Vb 4/nbpp9fdnu292EPP99XA0gTm4/V276vHiRKmqtFjCPGb/5fkIGbtJrLw8qKMb7gSZjs +d3oNuNcoHEu5waam+nl5nO+QcRMcY0JiF+cP56/9q0Po8NxHndA9s2QIwZoNAg3ORUz 4RBHgtn+fPbTq4XCMkxlcIdj4fxn4to/7t8t9eloDwkIO9r7PsHvPBvWZgKyp7Ebq+OW GUGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781860425; x=1782465225; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IAQ5csjl8oxIj8s6D8Km4LqE5SyKx2h6r4DVyh0qIFA=; b=lFAEn2ki7DnftWf8elgJYzC2uq16aKNVxzkU6L5TZQn72HHYVYs9XECEYE8ELug9+u LchfSYQ82JEJcSSc2i+c/lD1An5Hx9YNyuO6AQYpzHktOd3BnnF2lGO5r+Po0RVCe6OL kRdf+1eVx9fnqNlflkiSKlE3VUUgB+6m1ZuPtzsJqSzQefeE976ZKHYXOTOqIf3JwqoN D2tfrAm3QY4hSU2PVGr2j9T5QmAGy6DDoSasavMWOC7IIO63bvRrk0Va/+dvNH/v11kk CeqNraYyOcnzAyvPVWZup6qhWJ3OHyWYj2HN2Mu9xe88pCgljiAUVvTbdj/nFJ1jmhrk 4/cg== X-Forwarded-Encrypted: i=1; AFNElJ8KT62EIiczVvfBqo1rrfp0JLyowm6unyP3g1Q2xzJm54tBT7tOsYSH2DB47h/HkTWjNEnPWk7pHDZ8uHU=@vger.kernel.org X-Gm-Message-State: AOJu0YwqlrHuUBHKI53Pq1pWWN4mMwV3zjId7f5YMm/nQzj0p+mfsn+8 5qBVU2KJYSckQ9mOmczE4XWwpH1uOTfMTh9qtSwZGed5ZYmjzs5VTWEqZ+7C96DS X-Gm-Gg: AfdE7ckQf/t1LlaD4AOxS296k5rogxhs9FMKP63XxT/9gSk19KNn3zz9qthTkpxkdYX xMdZCNLdSNuQqNEJ3ND2MCzpbptE/j1ypZNvpAbih0VZf8QxTnAUSQRJeM1DDkZ0pFxwWxL1Oid G9LaPOxhUKPflz5Cyj4J1odIH6AimdJIl8A8Y7kf7GTOunCgxcAqDT4wieAMxrDJ+YkwsqnSK7c uZLcX5hi7L+gGjIE3VZmUeQ2yhnsBhLgHbTUo7oUkjfu57HQ3hoeRqnwXj8GkPaEchFMWZOXw5G vLjm1+njrK/1ZqYG0uUnVeH2Rz3hK8fFyjkAXL5CgGqxZnfdBliKM+aJ5FenApggM2fc8inA03W qI+TdYk+LDqXtVXwJsH5d7NP6UT/zr8h+uZyBi1hp8JwYgrZsVMxrs+4bfKhpMNW25tObZ+360F zmnT/waGWOISd+7+FWQt7tv31/LiTXpCMTSBgitJ1vTx30+ATo2KPpat+pxAe+77pA6VmFofRJI +4xwQ== X-Received: by 2002:a05:600c:8489:b0:490:d354:bd0a with SMTP id 5b1f17b1804b1-4923f582d5bmr49182045e9.31.1781860425104; Fri, 19 Jun 2026 02:13:45 -0700 (PDT) Received: from fedora ([196.112.134.221]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4650b67a3f3sm7077826f8f.20.2026.06.19.02.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 02:13:44 -0700 (PDT) From: Jad Keskes To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Jad Keskes Subject: [PATCH] staging: sm750fb: rename pvReg to mmio Date: Fri, 19 Jun 2026 10:13:32 +0100 Message-ID: <20260619091332.622116-1-inasj268@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename the Hungarian-notation pvReg field to mmio, which describes what it is (memory-mapped I/O) rather than what type it is (pointer to void). This is a purely mechanical change with no functional difference. Signed-off-by: Jad Keskes --- drivers/staging/sm750fb/sm750.c | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 89c811e0806c..2d6b4bdbbdd8 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -743,7 +743,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) * must be set after crtc member initialized */ crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024; - crtc->cursor.mmio = sm750_dev->pvReg + + crtc->cursor.mmio = sm750_dev->mmio + 0x800f0 + (int)crtc->channel * 0x140; crtc->cursor.max_h = 64; @@ -1047,7 +1047,7 @@ static void lynxfb_pci_remove(struct pci_dev *pdev) sm750fb_framebuffer_release(sm750_dev); arch_phys_wc_del(sm750_dev->mtrr.vram); - iounmap(sm750_dev->pvReg); + iounmap(sm750_dev->mmio); iounmap(sm750_dev->vmem); pci_release_region(pdev, 1); kfree(g_settings); diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index d2c522e67f26..f4dbe161bc56 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -97,7 +97,7 @@ struct sm750_dev { unsigned long vidreg_start; __u32 vidmem_size; __u32 vidreg_size; - void __iomem *pvReg; + void __iomem *mmio; unsigned char __iomem *vmem; /* locks*/ spinlock_t slock; diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 34a837fb4b64..bebbd50db7ac 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -23,18 +23,18 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) } /* now map mmio and vidmem */ - sm750_dev->pvReg = + sm750_dev->mmio = ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size); - if (!sm750_dev->pvReg) { + if (!sm750_dev->mmio) { dev_err(&pdev->dev, "mmio failed\n"); ret = -EFAULT; goto err_release_region; } - sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; - sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; + sm750_dev->accel.dpr_base = sm750_dev->mmio + DE_BASE_ADDR_TYPE1; + sm750_dev->accel.dp_port_base = sm750_dev->mmio + DE_PORT_ADDR_TYPE1; - mmio750 = sm750_dev->pvReg; + mmio750 = sm750_dev->mmio; sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid); sm750_dev->vidmem_start = pci_resource_start(pdev, 0); @@ -58,7 +58,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) return 0; err_unmap_reg: - iounmap(sm750_dev->pvReg); + iounmap(sm750_dev->mmio); err_release_region: pci_release_region(pdev, 1); return ret; -- 2.54.0