From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5463438F926 for ; Fri, 19 Jun 2026 12:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781873866; cv=none; b=FW7GrpGKaEwdgBHuufIsPa+gJEIbPOTTNKz/i0oTm2dZ3EcQo1OvdBp34zMkk9iPKvjvVQRA6MgUOpzczZtESOXRfWlSDp1Jr78e75sat3fcDK5dLNg5AvZwvIvsQX7XUHYIDhJS6qThV44oYqfNngET1cMtrJDifCG+8M0Luls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781873866; c=relaxed/simple; bh=FPZif9a5GmTnm/62hnqfygACCCc8bn2pR6BVrs98zns=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rgdVnWF3dTesWRq9ERilxvE8vak/xM4Y3d+tNdDCPmFiQBMZUEOat6SfTqzOue5TXnEZch/sGrx5DA7eoavqp7ng0SsDx1fll+zMPV7t2ln5iEOjU3qQ+dTf+C0ktNXz0L7NboK3UsLwJ8oKf2IMJB3OnX2sAyfFU1uW60VXUx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l/tkA/qI; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l/tkA/qI" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2bf3781ca51so19883675ad.0 for ; Fri, 19 Jun 2026 05:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781873856; x=1782478656; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s1y2ZaxWX8Bc+DUJ39m/wzgx7kt+rtVLY75LVTT9X6w=; b=l/tkA/qIU/dqT+7c92d1tWJeUPANZHI0ptsZvEKxBTaxGF4hdIW5qyqpPblcP9fKOI LxpXvtWOjSagCshg5MVOyJIWxivcDRyz21cG8ex8QtsZy1+NBrUMzXCAYdP/MxZOJpiJ XZ0n3C9Tg6IFTkmaYD8AFrZ1KuLvR34MobGl128iFa9pUVe9K88T42RJxZMSdtEQyoi6 KJ9nXjIcNOw7u+7m/5ZJj5M7E1fPl3TUM60q0p1JZuzr5FPB84yJ83xo8JNb0fv144wL d6u2nMh/ZeFLqBrcWN7xoJM1tijdCuvdb4s1Uakemnd2u1y7PRb3gkgFIMJKwjQCoTMQ AytQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781873856; x=1782478656; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s1y2ZaxWX8Bc+DUJ39m/wzgx7kt+rtVLY75LVTT9X6w=; b=HU1wrYdnNu2Y1JCX+s7GRsd9KG4svggpLaGggjgRAgqrBP3d3RmPO0Xz4K8dV3xZ1Q utcED8Gg2znu1ZuVv368fcEpZciChmKUfy6JOWPNZxqKrscgLaBtrp9A68EHnnQISiiY NDmlP6BJ9l+/UTywcH1Lj90ikQbZBkHyzSkju05Lf0+AyuuFQUMeMaODzt/nlf5OKiDX YwGLYwgi+KtV2C5kY+nUaNmvMOKcntIgp/yQOE0obIfURO5CqF0oEK0C+B7+0prHOvNS aC463Nkk5IH6MhhI0n/UnFefho7MuFwrgz79wjpNgdt3uKNj8tfRwi1AhAaKsshtf7wQ //QQ== X-Forwarded-Encrypted: i=1; AFNElJ99QkaySD7yD+Yshkue2l2FaHra+lqzhWWkLMmGcJzTZxidYwi6TjiS+hABALoxItLJ2/wmJtynsFLrX8c=@vger.kernel.org X-Gm-Message-State: AOJu0YwF1DH1micRiozwLE73ocRBSrSF9kvkyeTRMh0CHrGHPX+NS9HQ CyFaiSmHqemiaeL7W3S5YlXFYot+OY+2fDwOcDJh3NKUn9kJZCz95zyAsDugVQEvTlY= X-Gm-Gg: AfdE7cnCUsnFcUnlSDxd0HioO7d31QUBsVggsUlNNttCE6sJhNLGAPa+a5SQEjg9b1O 9gl6LvQB9OarsoJI4eIsJTYlIs7Wlvyk31nrMjfEQkt4UPbfh97RYWp9bMErtRpKeBHKR7vysyk oFezJfXdhCtM2nOg23EFJ4A/LPwbgjC6m+Cw1/rb9m/kYJ2nFLjhoLInrXeFXKzCSPZU8hURjfj /A1W9PnW4TYmGYR7LF+f2sbuAm4eqNL8ag2fP33P6HOINAqvIGAPkWfCldfywRxDhQyUB1yZTw/ EfGWRvEp1zjlBUIfWqtr8LrLwTAffYDcbVa5V38J7P3CRq0u+PZyOfg+czbqLqXWx/bFooMbStH w0TTrP4xIu2t2lKItxyVo/gI6z5adZrLoa+A5TNT+OFucf1+VUY7wQ5SDBEbokkd8XpFTfLVRkT a8KSEk91n9NX84DMylhVnhNtSyYAvz2l1TPrQrb5bP X-Received: by 2002:a17:902:f607:b0:2c2:27be:39a8 with SMTP id d9443c01a7336-2c718f45c53mr39622625ad.31.1781873855911; Fri, 19 Jun 2026 05:57:35 -0700 (PDT) Received: from localhost.localdomain ([103.87.58.149]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c72089a6besm24338785ad.6.2026.06.19.05.57.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Jun 2026 05:57:35 -0700 (PDT) From: Devansh Soni To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Devansh Soni Subject: [PATCH] staging: rtl8723bs: fix missing unregister_netdev on sdio_alloc_irq failure Date: Fri, 19 Jun 2026 18:27:24 +0530 Message-ID: <20260619125724.12458-1-devanshsoni874@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In rtw_drv_init(), if rtw_drv_register_netdev() succeeds but sdio_alloc_irq() fails, the error path jumps to free_if1 and calls rtw_sdio_if1_deinit(). However, rtw_sdio_if1_deinit() calls rtw_free_netdev() without a preceding unregister_netdev(), freeing a still-registered netdev but leaving stale sysfs entries behind. Signed-off-by: Devansh Soni --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index d0feb28b7..6ddc08794 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -359,10 +359,13 @@ static int rtw_drv_init( status = sdio_alloc_irq(dvobj); if (status != _SUCCESS) - goto free_if1; + goto free_netdev; status = _SUCCESS; +free_netdev: + if (status != _SUCCESS) + rtw_unregister_netdevs(dvobj); free_if1: if (status != _SUCCESS && if1) rtw_sdio_if1_deinit(if1); -- 2.54.0