From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E8DC3B6BF1 for ; Fri, 19 Jun 2026 16:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781886096; cv=none; b=BHdC7AUoktTMqsY8JwvuRkK8sJWPghijaUNThmQxzarwTEFNBmBTVavkcqBSYSzKSl0+6Xf9zB7FfiZGh4wydoBtIesTQDiZEue6CQMLOJukWA8eC7K1NilTcJ+j7cLSIYomUpqydIp4Ai7m+FPkHviAYOP3i9cgjMeIdolnhms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781886096; c=relaxed/simple; bh=U2WAIKvThUojolYwSCVcMGa5Kcqxc1gTXqpQ6Egod3Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iIFPtFSMbeZA3I59n1Q8cZp6Ki3fAbgZiZ+EwlHTO8nOFDBzfGRyrpXYOjwRONwQO6G4Alnydc0sMKqKyjqc5drv5gG/GpRO03OfNzbsx1TUVPuafesMTB5jo8ya1rHagDu6kRRAVBjUiYotENVgM0e54WLz+HbunMD8HUxsZhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SXFEPkAg; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SXFEPkAg" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-490b8ac62baso32466145e9.0 for ; Fri, 19 Jun 2026 09:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781886091; x=1782490891; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3JLehku4Fkdexd+dqxNctEZTCkpHEg/7niz9TvmxWYQ=; b=SXFEPkAgL+w6QXLFYJRXSAfTLpiwJl/fXVYe72cyILXgVM+J9fZGCwHvQbaML5yyl9 whqAc/znKi4dh5fAWVwHQOXFNjKjYrwYZptK5+gqQgPWdpYRwP/GQ/HIcb+ZMPiKjBsk FFkNMcNgVosSKMRYHbWEHUsU0QyITGM9wEZgTQZm484zjEyAC8dyJGw5agOFQcOz3mf6 GrPEMlkvp/VRxHPaC50ZMnKC04Le/NpAgA1hPhT5+rvLyFBt325fmGyBPDN7Y4sl3+Jv rpbVKWdnwaqhpUwkWqLni8qXItmPps1IZC4pPGNpUAJWI3f//e+vYKgjyRD67HQ3aEWu OxQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781886091; x=1782490891; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3JLehku4Fkdexd+dqxNctEZTCkpHEg/7niz9TvmxWYQ=; b=QNRGXsmzPnoldW9/EcE6rN2uiKO8qlksneMobjiykrRugOIpKcCr+j/o2qkGR6u5WU AQ+Zq+3hVnvAx0IzOWteZs/TLqz1jdEuy6VECFYtotDDkmpCfbPG2yjrEjL+DwXepQGM d0xOXYaljz9a+e8pMrDWf74eTk/X1D31R88tLu/OutGkOcdzvg/A/Uih5S2sPaYB6g/C 6n0YL1CBmDVbGDMqF6kqGetPZ7kDavM63OWO0CyiXtdtGmxplfJmXf/gljX79NQMBowZ 2d5ZEXD0Ck4/3YQ4pVrxZhIrk0ZQgj14M3rQt2jFU5UBr6RIJRYXVEJjhpEnES2tsMsb 5hxQ== X-Forwarded-Encrypted: i=1; AFNElJ9zxqdI/oaN2edBaybfs4arF4jwTyGboMXitWrIVT4krSUu7h9nd9RcJoaFBiFwe8evrF2Uz8OBNtWVMOU=@vger.kernel.org X-Gm-Message-State: AOJu0YyoqLP+czZITp2UfAkGa9/fWY4VEfoGUVCw/4YVmYIUdFfs8GG1 Ww524lYTky2exUHd7WER/XGMdY4M++Si03takcQcLTBe1Wm61RZBDTVn X-Gm-Gg: AfdE7cmW4EpPRV90FkJEEFbZqljmSvYCXNqVvk+h2PlzPf9kmZM5MwQPR0v3Q8XaVko EkDTAUxQkJw9+pWoUSmabprI6w/maUwmx3g7twFEsYhvua6qJt6soRoT/15zij1AnrSSDmR9iIx 4lerF4pxDgzTywOAuNNz8jnziQt45VPL0/Db9J4TeLrBv7nphRSu30qJqEpN+J5LKye9T+oZ0Tz cuddiNxKiODxYMrxFYsC7AUiuGks+9LZqexkkPt1UAfrFT6vg62rmku4Mr8vcChSAZn2jAWfVwP zSHjjUjM6pwXpQUDh0UgME7YBvVLUusxXdhOB+P6AiF2TRmRn/ZPhwq1w41Gu1oAr4VF8qXQzle z1e3OQ3mwKPhvlus+2O2RHzEkPRPoEcnzQnUIf8OBj3IIIBbwnK3B2eUZYg/pmGMPhWZWCK88X8 4bjKwcbBdY0c2j98qf6dhhR7a1Jdaszz92aWPHbcox+1W0UuqR94fte5L4EhJNwlg8HawKrvwUv JCVkXEKld3fvIU5jw== X-Received: by 2002:a05:600c:5010:b0:490:e19b:9632 with SMTP id 5b1f17b1804b1-49240a59ademr57329915e9.17.1781886090506; Fri, 19 Jun 2026 09:21:30 -0700 (PDT) Received: from workstation.speedport.ip (p200300d507395ed9440fa268944f0f11.dip0.t-ipconnect.de. [2003:d5:739:5ed9:440f:a268:944f:f11]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd30078sm80399585e9.7.2026.06.19.09.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 09:21:30 -0700 (PDT) From: Mert Seftali To: Lee Jones , Pavel Machek Cc: Kees Cook , "Gustavo A . R . Silva" , linux-leds@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Mert Seftali Subject: [PATCH] leds: pwm: Annotate leds[] with __counted_by() Date: Fri, 19 Jun 2026 18:21:13 +0200 Message-ID: <20260619162113.416864-1-mertsftl@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the __counted_by() attribute to the flexible array member leds[] in struct led_pwm_priv so the compiler and runtime (e.g. FORTIFY_SOURCE, UBSAN_BOUNDS) can bounds-check accesses against num_leds. For the annotation to be correct, num_leds must reflect the number of allocated elements before leds[] is accessed. The driver already allocates space for device_get_child_node_count() elements up front, so set num_leds to that count right after allocation and fill the array by explicit index, instead of incrementing num_leds as each LED is added. No functional change intended. Signed-off-by: Mert Seftali --- Build-tested only (also with FORTIFY_SOURCE and UBSAN_BOUNDS enabled). drivers/leds/leds-pwm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c index 6c1f2f50ff85..4c99a07da576 100644 --- a/drivers/leds/leds-pwm.c +++ b/drivers/leds/leds-pwm.c @@ -36,7 +36,7 @@ struct led_pwm_data { struct led_pwm_priv { int num_leds; - struct led_pwm_data leds[]; + struct led_pwm_data leds[] __counted_by(num_leds); }; static int led_pwm_set(struct led_classdev *led_cdev, @@ -82,9 +82,10 @@ static int led_pwm_default_brightness_get(struct fwnode_handle *fwnode, __attribute__((nonnull)) static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, - struct led_pwm *led, struct fwnode_handle *fwnode) + int idx, struct led_pwm *led, + struct fwnode_handle *fwnode) { - struct led_pwm_data *led_data = &priv->leds[priv->num_leds]; + struct led_pwm_data *led_data = &priv->leds[idx]; struct led_init_data init_data = { .fwnode = fwnode }; int ret; @@ -167,14 +168,13 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, } } - priv->num_leds++; return 0; } static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv) { struct led_pwm led; - int ret; + int ret, i = 0; device_for_each_child_node_scoped(dev, fwnode) { memset(&led, 0, sizeof(led)); @@ -193,7 +193,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv) led.default_state = led_init_default_state_get(fwnode); - ret = led_pwm_add(dev, priv, &led, fwnode); + ret = led_pwm_add(dev, priv, i++, &led, fwnode); if (ret) return ret; } @@ -217,6 +217,8 @@ static int led_pwm_probe(struct platform_device *pdev) if (!priv) return -ENOMEM; + priv->num_leds = count; + ret = led_pwm_create_fwnode(&pdev->dev, priv); if (ret) -- 2.54.0