From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC48A2F0673 for ; Fri, 19 Jun 2026 18:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781895498; cv=none; b=iw93xDEi8PvSpW/al1d/17GApdq0dHeLmRovwpbYNxo9C+he10h0aOpf6JHoi0q/KK+jfOL+Mu7yUqUJVp/1/jPEwVnaoSvps5JNgjOhLcuX/os3OdW7clGMGiXe47WxUDhx9BpfzMMFVOei5vaBMLWkwejdNpiuuL+9UC1pqTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781895498; c=relaxed/simple; bh=/f8uNOEcRrZgrqhTwZvtXBapAl1hih14J6qjAtxMrG8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sfNyOmkrOj+NzdtAXQ6viJMDznPoHLTBDxEtuOXHXf0ALD4qHv6AkTZ3WasOTDGShJmagqA+A2h1CexjSHnb8nX/ZnhR9ZL//Sf5vTBqsDgjTRCCRLYFNv5G5HblaZZGEAfPSsJ0UwfojPVfmP0k3k3RgKeZ951SN7d3+RD3GRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Iv/3vC6G; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Iv/3vC6G" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-9157b94a07aso254436485a.0 for ; Fri, 19 Jun 2026 11:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781895496; x=1782500296; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VMizGUh+POPbF7otugfIKTfkSOnb6axk8qMjbvMG90U=; b=Iv/3vC6GKZMK35wMHAmx6z/qn9ORVAkGkoFsFB927q9Ja+IMf1QcLWAJPonzUTtvb1 S2wvgMpNZjHcNDXLReM3BWhk++CrM9taP8G2yklBCP+wCtz3JN286zgBGXxh2KQPDeTh 6W+T293WMPpFe5uJXUkDz/1tU5gqAmzXve/lo3IRG7jh8o7BKPkt93KFUhL3gazjOo3W X0gDAB7e1WtrDvjaxOlJ+zU9tEw16/JQpRIsKggswjA6hafVJucXjaP8kAju9Xofq/xt WPQJIHnCu0XKrGoXyaHzGW3t62nvTQ5f08QttkQ5vwoQjEAPOeYjvfND3bndbfGfkgrY 2dww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781895496; x=1782500296; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VMizGUh+POPbF7otugfIKTfkSOnb6axk8qMjbvMG90U=; b=nWpgtal2oU4pz2d+G3N67wPgw8NbJkNU8mqhLFmtVLOf8MkTjhqtvPM9SnYCga1AsG KLLlgfPr9j6Ngyi69waSKfAbVMgr3ofeV/w7XFTH+uIrrg5CprKJQ98uNprzXwXfEsRs QmxrqLt2GE0wYKTjINPAiFRPjOucLnQVu8Z1FkWI+zTlODzFfIMjDM3xdL+KXExPMBLZ luhh1PGWTo1sr94iLOXekcpOpSdMzUMc+RItPyD0LyN/i6Dlh2mtvupyG8NTF0q/Ttgn 2gyg3W/79z62OwShUMj06L3mkPWtPNkczZbaFvBV/JsptaRiztGDK6UFq4UnlRbNMbjP s64Q== X-Forwarded-Encrypted: i=1; AFNElJ9Iiil0oUAUBN2yVYT5svYzud49Ii26L9PPN26NLCAlGvJxaeaPooiemkAYQ2Oz1CKmnUvRwIBtQ5Oz090=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkwxit+NKuk633TeaW7N1pOQpf6QdtTP0SQcLNRgjuSiaNqdsk KOIaP+2M44yOW+x1mIbqUzjxyw51J+hl6EZwr/Eir8ey9NZouLMZ74hO X-Gm-Gg: AfdE7ckaIP6wgjSi/3KXr1YjyRrFvWneiEEKr8oy/eWc6YRQOro/hS+B7SoNvQCZ5wX xo5K3KsR8z93RzVSU4+sVOEkCalgLLDJYivibssMHgE+fZx+oLmWierfZXMzkA5/bkAUn0r94AP 4S7bq9SyNbfWv4xTAHOB3dTcP6ri3j5VLkQ+2nY7E4NUnWZRdohTF/CU6BIBmiwOMoNy/7e1JND FY0PPm7Qslqpd6Yv+LIRhc+Y6vfY0N1NpqXBOkFpU9lCsMjdvwZo9q5501Z0d4BjkLY+INES4R2 zi7itEHZo9bBnrT6x/bzYuY//K+J7xZ4pqMIntjJl2LX0wu0f33AMhLueHQ7OEIiwNbEpWpFOgx emVyHm/WUNralHSDeXxHqTMtT0Cxu0tHgwbqCzLfsaXh/a9ELDdwC0qcVLSeL5oIzs+pEv+evlO 44y0N3TEjF0cxmraNYoDltQbeEv1V5kQ== X-Received: by 2002:a05:620a:4483:b0:915:cda5:2805 with SMTP id af79cd13be357-920d53d1cf8mr573961085a.52.1781895495737; Fri, 19 Jun 2026 11:58:15 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-921d7f46046sm75947185a.15.2026.06.19.11.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 11:58:15 -0700 (PDT) From: Yuho Choi To: Marc Zyngier , Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] irqchip/gic-v3-its: Fix OF node reference leak Date: Fri, 19 Jun 2026 14:58:08 -0400 Message-ID: <20260619185808.1090575-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_get_cpu_node() returns a referenced device node. In its_cpu_init_collection(), the node is only used to get the CPU NUMA node for the Cavium 23144 workaround, but the reference is never dropped. Store the NUMA node locally and call of_node_put() before either continuing with collection setup or returning early for a NUMA mismatch. Fixes: 920181ce8469 ("irqchip/gic-v3-its: Add ability to resend MAPC on resume") Signed-off-by: Yuho Choi --- drivers/irqchip/irq-gic-v3-its.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index b57d81ad33a0..f82035eb77e5 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -3291,10 +3291,14 @@ static void its_cpu_init_collection(struct its_node *its) /* avoid cross node collections and its mapping */ if (its->flags & ITS_FLAGS_WORKAROUND_CAVIUM_23144) { struct device_node *cpu_node; + int cpu_nid; cpu_node = of_get_cpu_node(cpu, NULL); + cpu_nid = of_node_to_nid(cpu_node); + of_node_put(cpu_node); + if (its->numa_node != NUMA_NO_NODE && - its->numa_node != of_node_to_nid(cpu_node)) + its->numa_node != cpu_nid) return; } -- 2.43.0