From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9C23367F39 for ; Fri, 19 Jun 2026 23:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781912800; cv=none; b=uCZcbfmVfls24HxHFNST2ONnChd5Xz+bZUYaP96IoAGvYS2llvh1neNE/4e/IlABnFvnDHlozj+mS7DGTM2jHBy3dY/JzjthQovOA0fIvlXaJgj8DslI3tJ6jEiEGOgdnk4/bFsG2MvNY0EsxnzNuhFgoec8oZbPTg6SwslJ4eM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781912800; c=relaxed/simple; bh=HSveILt5Om2n4JdSv0BlFEuq9zXMD6Vwc3O+JvgbGjE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XXjbUiyoyLhOqXsEcTXPKH/m9GnYFgNAlL+2t+ylSy+ar160VEID6+Tj141K2ZQfM/MVPV/NZqcLTjNJ3cK5oOnjGQ4iCUIA+Qt3fScM4DDyAL33w6YxNYVZgactOGs2fEtI4dvqA4F4eZXcCBdIwmt6qquttkPjrXjR+CWOdfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o9s6LixC; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o9s6LixC" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-46255b269c2so1955882f8f.3 for ; Fri, 19 Jun 2026 16:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781912797; x=1782517597; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tCxtqj2d33zC9laceeIgBMjjDczDED1aRQYh/m+NvNo=; b=o9s6LixC3ZXHNkaMAzk34RBI+jj6bnT0oTuhxLmzUCalApPg8yCTsiesgIHArSBFTC 3ZR/JVr/K053+zGxAeX7wCQ74LYlWQrLXsgeynwgfL65ULCYR528xiMWXz5HY6BqEsXz qQJZkM1lfoeSmjmEbQY2rEfCU3V+nGEGRH/NBFxsfHpp2zmd1jKhUHlpAo243wAaehbC ydpFFYFLOHKCHSIm4aAbI1hzMQ/H+acBckjvhxq1gLmtdI1wVBAI4a9nQdpnzxirO6pd Le3O5LLg6U/WEA3t4PHUxCVNjTpdSWEWA2kGMGD4Ugl9PjI+AOPHX76cZYJ7Wx97H0ck lRVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781912797; x=1782517597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tCxtqj2d33zC9laceeIgBMjjDczDED1aRQYh/m+NvNo=; b=OWPK1AmDDK7/930QODXixE5VfUYkSjrugjOE3QwFrdulLhAYZEWuvqEbe+CxHD1SRy 5mmSKn75ATEoPqpYWhTVjVwx96isLdi4T5MLiqF5if7TE/zbGTWIpZ6k4e+lYA1wLXEF zdRmV+SpzIXqU42i7vuQlssNVk1+Az+Szi0xgsuMo77trBF5J5q+r00iIqtJxs1rOeUi g9FFCM0lp7RpyFCN5hcaGd0hi0lcJ7y7qnNf0pnOm5tl6KAwVHwzR2DWssAuKLpoEBgh uOyc+1ymn/FCGZPtGlIzx/VlLwLS3gC9QeZvfgSDhIQt2KOQsHUw+ofAH1PErM8JvjTl poVw== X-Forwarded-Encrypted: i=1; AFNElJ+AcBC+s1mGcea49RXKC0ecVLCJBRFmoSg9+PFthoSDG01OSIIUpqblyUicDPlK+jAGSeg4o2XkZIvLO7s=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8jxbda1pF4IOX2smD2dd7GPndtU5j/3VoM302TSHBMFSf5vvT tH2JZVuee9NfaDNRSrgvBPUlLqFMmOQlDMhHmmwetGQd0scTHJw822cJ X-Gm-Gg: AfdE7cnwxMxmsBEsvxjbVet+zSaApa0072IZTEbzknhZ/1zZs+fS+nQma1ukStl9Qc+ d4qfoNRFI9CqozM/y0ChGBfjhd5j7FU/bW/Xe1Ks/6zkGtv1VyFBOFr4EduPHdFoUqxDt3T7vS1 L13w9Zh0buRbULXbRI3SXRC8hqD1Z+9HtqkkrmczA6MNnE0y6Te+NqawI061TmCNrx6xQE8Dg8a pUexivYOvz0CenQoCktzx5OmIG3rzV6ctgSs8QJHmaLgXfVTHDN/e/Li/eipMHyP00pgBZ0j3AC NFBUr667PrAIrjd3P3pMQ5rhdZMS1+LO6Bpgj7W54U7LFF19FU/cxRZzRCmRAVxB6xl0JqcPQyN JxiVNjZLDaNq+v6GS0GO4YOfj29YcYlldG7dUktd2Mhf01X1hcw4Jo11L12dOnhhCYWdp1J8GIE PQLRCVpLA6Taw= X-Received: by 2002:a05:600c:4584:b0:490:4e3e:b483 with SMTP id 5b1f17b1804b1-4923f573129mr96809455e9.22.1781912797246; Fri, 19 Jun 2026 16:46:37 -0700 (PDT) Received: from user ([104.28.163.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-466667882f7sm2868027f8f.21.2026.06.19.16.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 16:46:36 -0700 (PDT) From: yahia To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yahia ahmed Subject: [PATCH 2/2] mm/damon/reclaim: fix potential memory leak Date: Sat, 20 Jun 2026 02:46:06 +0300 Message-ID: <20260619234606.221163-3-yahia.a.abdrabou@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260619234606.221163-1-yahia.a.abdrabou@gmail.com> References: <20260619234606.221163-1-yahia.a.abdrabou@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: yahia ahmed Fix a potential memory leak if initialization encounters an error, ctx won't be destroyed. Signed-off-by: yahia ahmed --- mm/damon/reclaim.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index 15bc06ae7505..dfe52717d92c 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -481,6 +481,10 @@ static int __init damon_reclaim_init(void) out: if (err && enabled) enabled = false; + + /* Prevent potenial memory leakage */ + if (err && ctx) + damon_destroy_ctx(ctx); return err; } -- 2.54.0