From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDD1B1CEADB for ; Sat, 20 Jun 2026 05:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781934495; cv=none; b=BSSVzNKRvbzRu0NOSNQTdH3Gq+8VOj5JmAyK/A8mrKb40XerNtRHlDIWdan4DNdaKHFWYsURFrJaJDlqoZ2+4fBT8j/Cpd/qWA+WmUMWz5tA2cdHjjn11/I+O4giOo8hFTUUQpMRhQNxSR0pS6PLv5fqsgWISyHWHTK7wR9+EXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781934495; c=relaxed/simple; bh=XjyJT5W1WsG2MyfZ7fnuUwzGcUGg4Y6+iUVCy+1ozYY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=SaDa2wDZhm8JxuT4GbXJtWbRFekHT16mgVAq2qBLp0qn3uZBAo06xt3v1MnFYOoVSkOHQRjG5LzzNpvSDC9b+931LN8CeEoQ4uCJ91Z7TYPa/y+5smx530qbiXrX7DwdjdT8LgnEuiJBo7PJRhMRzXKkW6zDBHPu5XEH3u3DyQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H4v0mbAb; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H4v0mbAb" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-695f6438518so3569013a12.0 for ; Fri, 19 Jun 2026 22:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781934491; x=1782539291; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ed3t8ZxAhZ1D0n+cEn1P+22l2LNZt23J9pURBwnxtfY=; b=H4v0mbAbEV8EPkK1Xp5YAW9qHmAlaRuQhXm6/70bgOvNI21BcU3L2WXbKuo2ZAbWLp s7/e2ibOUD7eiK9ZI2fh9O05vMZMXgGud919/s2ORB6bkUTnSMvE55K7UbIoF/mn9LVJ gOnYEy+1g1KPq0Hkut1ZpuRyTAJcoLTGkz5BwEeD5PW4UXhXjUVZos7t1pz2+S4K4rZe 7Tr3zaxEyP7w64l6icUXvydnTtGBUFHWumDikxAgwxO7xLl7rTjRPDDfQq0wb3WEj+uA Jk2tJEGB7xpRTK3ls6eb/uZ3IezFxuzcTN6kXCFknKvH6VfOkNOw7jX81tPwgvVpBeH4 o7Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781934491; x=1782539291; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ed3t8ZxAhZ1D0n+cEn1P+22l2LNZt23J9pURBwnxtfY=; b=PPxBzSA5rAACtXNttkpL2ogIydP79SiPlhPita3PEVkZ8sNjBvOQvOYEoCpFmMTcOW s0rBUKy2Im1xYddXX5kAzggHGQ1ds0AKoqOZ9MGV22jlViQWiuOQQi0qll294rQB0sGB Ng40kPmGd7Ca3+UMJODhBCfcOsJK4nx7Jb0b2CZbjCzlxvSeph58dwsffvhYDCVe7rQk KEBeI/4+DW0vRigI8A3VR0uAvIo9ToeXAKN/EmqdU2cJqt3abmpTvB0X3WaSbE+ACh+5 7/F6lKohfklp3fSSQsp5GkMTLWdoKiO1849iT5EVSm58tN8Pydkc1tm0LadRDTAJDbUV RIyQ== X-Forwarded-Encrypted: i=1; AFNElJ8nL9EIJKuKexL9nxOqZmQg7azj6vXHqL4ukEu1yLrQRVRspyUx/YEdkbX0mUCtPFtcQ2dBwoDZgz5vx0M=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf6BQU0TV31TT1khiMrYS8MC9vKFvQZaEroB0ejWX1+BfvfGIP /4Xfjqe6L6kAR/5ReZceKRcIEzI5kR+QcflaW9j6PtZvlPQawBnN78/y X-Gm-Gg: AfdE7cmBV+6Rh2ogkd9xaeqNRgjx9iDqy9FKfgHePWyMnhV7/mJcSTPPbX1AKeGyVyW pTiZWvLBnRVFo+BB/G07PpeO6rpigxsIFOiAeFpWUUdyw+QH22rqFR7cqhcz/w0nAXpzxVItI70 WoSQXs65NgSkXesnHrpWRZHOG5G96PG+j1O7gEKvIqrPW/Y7P1GBnU1lHpN6UTZWq7z0ABJNy4X NW+V19/2fZJUvFZ+lmaQOdOEavbzyHefsTgSZOY4PhMu6OvkpPYu7ZiDEt5VXzkK/lX83lzd8NM ac39BY0euRjwzqJlFPk7UAAM5ra2ZOaZEEsIpn2l55ocSFLhu/7pXUupSgr0r94kUpNmFjZfF2q 30OskMIs15jWpAn7EZnVqnUTeCbCYQGVcsji2hbyw84sJm/yylUF89Bj7ofOe X-Received: by 2002:a05:6402:5243:b0:697:64ba:bb9b with SMTP id 4fb4d7f45d1cf-69764babcf3mr2494576a12.17.1781934491202; Fri, 19 Jun 2026 22:48:11 -0700 (PDT) Received: from adr.. ([2a00:7c80:0:3a8::14]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977be498e4sm353440a12.20.2026.06.19.22.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 22:48:10 -0700 (PDT) From: =?UTF-8?q?Andr=C3=A9=20Moreira?= To: mchehab@kernel.org, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Andr=C3=A9=20Moreira?= Subject: [PATCH] media: av7110: refactor deeply nested PTS loops Date: Sat, 20 Jun 2026 02:46:54 -0300 Message-ID: <20260620054654.122464-1-andrem.33333@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Extract the deeply nested loops handling PTS flags in the MPEG-1 block into a separate helper function `av7110_ipack_m1_pts()`. This fixes a checkpatch warning regarding too many leading tabs and improves code readability without changing the underlying parser logic. Signed-off-by: André Moreira --- drivers/staging/media/av7110/av7110_ipack.c | 35 +++++++++++---------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/staging/media/av7110/av7110_ipack.c b/drivers/staging/media/av7110/av7110_ipack.c index 4be6e225f08e8..a3e69a737e97d 100644 --- a/drivers/staging/media/av7110/av7110_ipack.c +++ b/drivers/staging/media/av7110/av7110_ipack.c @@ -136,6 +136,22 @@ static void write_ipack(struct ipack *p, const u8 *data, int count) } } +static int av7110_ipack_m1_pts(struct ipack *p, const u8 *buf, + int c, int count, int max_which) +{ + while (c < count && p->which < max_which) { + if (p->which < 7) + p->pts[p->which - 2] = buf[c]; + + write_ipack(p, buf + c, 1); + c++; + p->found++; + p->which++; + p->hlength++; + } + return c; +} + int av7110_ipack_instant_repack(const u8 *buf, int count, struct ipack *p) { int l; @@ -335,26 +351,11 @@ int av7110_ipack_instant_repack(const u8 *buf, int count, struct ipack *p) return count; if (p->which > 2) { if ((p->flag2 & PTS_DTS_FLAGS) == PTS_ONLY) { - while (c < count && p->which < 7) { - p->pts[p->which - 2] = buf[c]; - write_ipack(p, buf + c, 1); - c++; - p->found++; - p->which++; - p->hlength++; - } + c = av7110_ipack_m1_pts(p, buf, c, count, 7); if (c == count) return count; } else if ((p->flag2 & PTS_DTS_FLAGS) == PTS_DTS) { - while (c < count && p->which < 12) { - if (p->which < 7) - p->pts[p->which - 2] = buf[c]; - write_ipack(p, buf + c, 1); - c++; - p->found++; - p->which++; - p->hlength++; - } + c = av7110_ipack_m1_pts(p, buf, c, count, 12); if (c == count) return count; } -- 2.43.0