From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1AEC1A7264 for ; Sat, 20 Jun 2026 08:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781943518; cv=none; b=EA5t/DWKqVh9d/NmmXeP3zh40QA48HzMRYOiDds5VpDmhYEF0QESF/+Caod8Knt+/KY7pS6DSGd+RQRvK+Q1tpEz8MZCP+5kXZ6Yz0PAXDO9pZwXBM8flJxtU44RAEvWVhxmRFyz9vdinC339PmVq7rJe9GEtmBURq1jyXJdsak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781943518; c=relaxed/simple; bh=KaLjfjfbLDSHRTKoFoH2WWe25lyGwHdfbMBSOjNwHy0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SJm2ipHFWKxR/TgHuLZ1LHlG3zUJLb8qLt2UVCc6jOs0b8fIh16StIsZ2hnL6Er8n2RvuIEmItl6uRUzwEVWs6zUy5arb94SRCqIYfb2Hc+U68B7++TthdguIh3XAwvNHXQA3kysaj7yBW7fUfZ9yfGEROYV+1JLSfpTVXlLYEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PhiqAlkQ; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PhiqAlkQ" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c88eb5e7713so1111558a12.1 for ; Sat, 20 Jun 2026 01:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781943517; x=1782548317; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e++bMBXpFk2AJ/tccOpQWH2jzKOW4DGp8RHho6XmHTg=; b=PhiqAlkQRxeOUj/06Vw5pQiaT+qnxe4ddV8NnO+A0lFnPMudVRNUMqUDWL0+fnEFV4 03/2/DA8Zuwy+JPuCLkgVJJUsdEcOm6fA2Drop8o32n8Tif8aj3AESsmKjZLNCWmEc3p 0+NPZ7Iok3xpldLIp1BrobIRepJzkM5Zqpi/LU8KNweeWJ/DSTzg6KZ9Xntajp/0TQYc yZ1O06CcuvtL0ZQDnzlzDrX7hIyEsfE/UTxXv4pXTae7Fe9SBCuSkoK/fXlKIVZqx6qt DbvLznW47XJD+YqIz4DxyGPPdWjVq91RTYzxDLxJ6bCcaVVzw4BlPbzqzbwV36fVT8j2 2qbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781943517; x=1782548317; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e++bMBXpFk2AJ/tccOpQWH2jzKOW4DGp8RHho6XmHTg=; b=awTvbHNjG8KRXLvq/pTq0Ei3rOIxnnqzPkqjo1Lx7xkPN9rt4gJwRmF9POxpBY/Mkh eel/YY4cbDqFyk275rZURE3bUUSvt0Fql11W/kqph7qSzcK0Gm3fCx5Xg9OQX0LAZVb7 MgEoFNVXiGvmeMG+FdGtu4uRRq8dMdZmICv4vj+MVqncfLz/LtNCgwDbaLGKnzvU55FL 6kq4ycmm2dEH0YZ6arkRFp2AJI5ElGVCKfuuyBkutdhJ6EY9C9CAheKXwLzo2SMttUUq MQg9PCtNILRVX//Cy87L7twF8391zzPtzWu314dj+OM0pJ0KJ0hd6rDo67f83BZBAfWg rkNw== X-Forwarded-Encrypted: i=1; AFNElJ/j4LKlj8yTi9wGYIQYm5oXetOfL5avw7FJh6zf/v9PTBtrHrGIg9vkbwhL5bGDXiIoDRknbV01pGghmqg=@vger.kernel.org X-Gm-Message-State: AOJu0YzaNlpVxfKMJc2LujjVCD+01bd7AinAY2o1NsDSkbhMvu4B1jUa yYxVAGV4uUm/KFxpsGVaysYTGKIeaUz3CrFiahwehEoVH6x61hzpt0zVTv6ugkeU X-Gm-Gg: AfdE7clKbSny9C7ONHkz4HHbpXCOy4z38y+s7rSFKHFMDv5EUThmbANfH7ywsLAa0Ir NAShSyzJKslrDT++TFbAg/3co6VPd9hQSNIyXCJIb03wBrS82hbstK4Va9nKDcl6njmpfMHhZKK TyiS+aqyvB859E7qPQVl4yUwlOObiupBRTqAvjDWghzu8rpOaD72AUCkqFF/y3rhEtDjSh4r2Ah /3vj1KC4iVRwBU0IBrfCjO/2NRwimxloJrfUWUfciRdo73+yTrpX90pBWtG1/FlbMVKr1zSu9Uo fCfJDIahaLF463QRQEfVIlM9mX1mhke5bQpqwslsTKgIQ2dSjfJWiA4vS42yAAkZe+IaIXT11ue qw71bX+8oOjC158wpX61ykGN6eeMCVS+58rU0M10pey0wOX4IFiOYlWIqM/SYPEw= X-Received: by 2002:a05:6a21:7018:b0:3b7:d9d6:9fc9 with SMTP id adf61e73a8af0-3bb69ab7504mr6681154637.2.1781943516828; Sat, 20 Jun 2026 01:18:36 -0700 (PDT) Received: from qby-laptop ([2a13:edc0:18:16f::a]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8bc374375csm1768098a12.13.2026.06.20.01.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2026 01:18:36 -0700 (PDT) From: Mingyou Chen To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mingyou Chen Subject: [PATCH v1] platform/x86: bitland-mifs-wmi: Fix NULL pointer dereference during suspend/resume Date: Sat, 20 Jun 2026 16:18:04 +0800 Message-ID: <20260620081805.63773-1-qby140326@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver registers two distinct WMI devices: a control device (BITLAND_WMI_CONTROL) and an event device (BITLAND_WMI_EVENT). During the probe phase, the event device handling path returns early before initializing the platform profile device (data->pp_dev), leaving it NULL. However, the PM sleep operations are registered globally for the WMI driver and are triggered for both devices. When entering suspend, the event device invokes bitland_mifs_wmi_suspend(), which passes the uninitialized data->pp_dev (NULL) into laptop_profile_get(). This leads to a NULL pointer dereference inside dev_get_drvdata(), causing a kernel Oops and halting the suspend sequence. Fix this by adding a validity check for data->pp_dev in both the suspend and resume callbacks, safely skipping profile operations for the event device. Signed-off-by: Mingyou Chen --- drivers/platform/x86/bitland-mifs-wmi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c index b0d06a80e89e..3a373184519d 100644 --- a/drivers/platform/x86/bitland-mifs-wmi.c +++ b/drivers/platform/x86/bitland-mifs-wmi.c @@ -300,6 +300,10 @@ static int bitland_mifs_wmi_suspend(struct device *dev) enum platform_profile_option profile; int ret; + /* Skip event device */ + if (!data->pp_dev) + return 0; + ret = laptop_profile_get(data->pp_dev, &profile); if (ret == 0) data->saved_profile = profile; @@ -311,6 +315,10 @@ static int bitland_mifs_wmi_resume(struct device *dev) { struct bitland_mifs_wmi_data *data = dev_get_drvdata(dev); + /* Skip event device */ + if (!data->pp_dev) + return 0; + dev_dbg(dev, "Resuming, restoring profile %d\n", data->saved_profile); return laptop_profile_set(dev, data->saved_profile); } base-commit: 1a3746ccbb0a97bed3c06ccde6b880013b1dddc1 -- 2.54.0