From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246B2331EC5 for ; Sat, 20 Jun 2026 15:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781970808; cv=none; b=GgO/QtTM8FQSiaiWC8GmHppcwGJPgpAHw1IR7R5Ya5pKT3pLIA32pcLvAjA+PIeclzwO+DCFkb6NjWFpMpiJp85GwcPt5vl68BD9flXQ88THWMusMlArSL73auieKUVhuCV95YYtFp+REvrV5E30F5XhR+LpfEJr3Ar+5Ikrhwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781970808; c=relaxed/simple; bh=DlgWLEzGgG0nUyN9ICtW/q8163w7vFFOvs9xVKURyBo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Kwzm7j+K/L9jfdKqvStBsogiHhgHOX5x/WlGnEeByGqdxCkI06Mo6mMjUq+4FLoB0gm9qEr+JYiPC/mbZUvDZ0Bcu77qGucojwTyaHqY3FzIcFk606LWMfPNAktNWP1XmFE3rGozy5L+VcDptqloh8yRTHieQna+pTKApLv5M4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PF7bCSmS; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PF7bCSmS" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2bf20f6be6bso19895415ad.3 for ; Sat, 20 Jun 2026 08:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781970805; x=1782575605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=99ux+NmuUXucZal6I4fcMAQAAFgyJ7Vb7HpRZz/S0uk=; b=PF7bCSmSV2CZvnExFontBouG8n2GZkngd7/UWYRnwsbmc5k/Xv0JV4DoKWzIljUAS7 prwisRt3UPjcBpai2nHL0CV4SJCMNYmDwV5foWR6nZLN88hmOUu840+oodqo/mcoqngV Aqdq0YUnQdETMzTSGIJ1GL+yIrX5IT/SbTUZXhPM1JIQz0h0ZaVM8LvfO8AaqC7DNlSm 5zfQG63w604+UUOJrAGirEuzVB5Q8QYaPZkTJlIOUf6uhmjI3xLHO/FRyJCSmX6yencG LI+jV0xsURJtoP+gZZN2O1/Kx5bT+SvZT/s8xrW7pUvXyPxP6nh22zBX2TpHLWfV9yPN lrxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781970805; x=1782575605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=99ux+NmuUXucZal6I4fcMAQAAFgyJ7Vb7HpRZz/S0uk=; b=YIC/etsa3S/7sa47g8NcenQ64q9iwuQFvQbCY4Pm187GRsj/kYCQz85zxLuamypcLo N/gl5U/c0ey6aVPICmU9+TDaZrIACjkRoI4+2+0PfCL5o4foP2m8gbzCv4jMYtBU42Wj C/pV8mTn9jZZ+4nX6mQWfhiO5vK0/9c+7dnYXzidBsQnMMgrab/dmEVXVqK7pJocmtEE p/yeK1LBPc3+LdYE75iq7GygQuMwFd4AbCGvtj+o5xfK3BQ0Br6hHww+TG8ljKnbbkKm UpsTg7RygA1GMQhCRLjoa9/JFBm0kfv8YKLXedfF76t7bdNn4SLAaXYstKnEFuxHjRcy sMig== X-Forwarded-Encrypted: i=1; AFNElJ/i6vVvF6sZjtkJLEjjKondoo2oELp32TAV6AvLMXmMlCQ23IXMvqI/2z+ly9Z9AehQ8Z3TrFErZf5rLfU=@vger.kernel.org X-Gm-Message-State: AOJu0YyEMLU4TnBAiSdJY4yqgo8ToiyPwoHtywM+Strp4ZB6mgHr9JFi QZ0XfnVyAc+9dwUMhQ19EO2u8IgP+N4E8Bcw0qNSKndn/J/ZW+MZ7zgx X-Gm-Gg: AfdE7clFaOB7xcZnYtKzPbIenBmrnF9qdRm8KS8DEgkIsKKadhNYApb5E69hxrBRb0I XocqftWE9+pvkUvX1kaK+foLFpz7iDPiQH09Zdz2wJUWHHMd4eNY2u7k9t7Xam4OkilHe4i5ADN sBa2euJI+uok9Olyp8jF0weQ3211iL80aZy1samV4DTOcPeEc7fZF2pAefvb37ElF74gj/TgJ0T y0JYOXgUxKHRm7gEpT/liM8w471lZjxoTK6fzjMINa1f0OM61QAK+KamRBT06bqgyr/RCJO9BzE HnNBVsIbUBT5DH0OdwIZL7aQir/gXBTa19BMWAm52Nc1pJ4dsLFwqK0FbMuC5ZVm1oRTRWA8L5g gFJd1+U4FnqR41Ecbr27v5XrnnMUMEfx4f/fbqlp8kvuzh/sg3EjbBmJR8PcyWJ0Nj2pTlqVukm frC6JMLr+YxKDSRsmTFAc+XPjOThHtV2pdy+aMslZdMBY= X-Received: by 2002:a17:902:f688:b0:2c1:f262:494d with SMTP id d9443c01a7336-2c718f622d4mr84491185ad.19.1781970805414; Sat, 20 Jun 2026 08:53:25 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:8e0e:956e:b09c:23cd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c743bfdcb6sm26221285ad.57.2026.06.20.08.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2026 08:53:24 -0700 (PDT) From: Ruoyu Wang To: Linus Walleij , Bartosz Golaszewski , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] gpiolib: initialize return value in gpiochip_set_multiple() Date: Sat, 20 Jun 2026 23:53:19 +0800 Message-ID: <20260620155319.79994-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gpiochip_set_multiple() falls back to setting lines one by one when the chip does not provide set_multiple(). If the fallback path receives an empty mask, the loop is skipped and ret is returned without being initialized. Initialize ret to 0 so an empty mask is treated as a successful no-op. Fixes: 9b407312755f ("gpiolib: rework the wrapper around gpio_chip::set_multiple()") Signed-off-by: Ruoyu Wang --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1e6dce430dca..cd2a619da456 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3778,7 +3778,7 @@ static int gpiochip_set_multiple(struct gpio_chip *gc, unsigned long *mask, unsigned long *bits) { unsigned int i; - int ret; + int ret = 0; lockdep_assert_held(&gc->gpiodev->srcu);