From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C2E78F59 for ; Sun, 21 Jun 2026 09:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782032560; cv=none; b=V1mMWkC+RNeeXh4SpaJ4wAEc6wDawJDKPx9U2NzT/0V2ya9k5g1QZJ2S1wvF4g9d72ofQvDK5x3Wu9NYa8PqaRxCFAuoZzwJ6aY1O22iylMn0WwZwpCT79M1JPEmyh0PPPVHhCoZRAlKGPidrHGMVzTflwl49Daesh9M2H7ivW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782032560; c=relaxed/simple; bh=hpH/nll0NwJ73Hm43LjAwtFvfl3h/OEHflXWsS9Vr4s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=isCbzXPuiBripakQiFTGr0XAK2TufDw5KeiNsuNxdI9rSc7/HvAsQXbF4NT4dmAev/atcfLMWEQh3aww9ssGqTp4St31o4c8Nx97ZBdtOtaQRkHP1xKFhwAcY15p9o9xLlHj9vBXqPR2XDPM8P6qTelg6Fq5FylSxo0etAQfZCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f5bQrcNx; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f5bQrcNx" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36b8d414666so1817101a91.3 for ; Sun, 21 Jun 2026 02:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782032559; x=1782637359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VrFSc8Rsq5ZiSM5SQJhJ/5/RkCPU5Th3OsJQ9UzvMSo=; b=f5bQrcNxSmzW5nMNQhNu5U0W0YqXusC6ziyWnI+ZZalRs3M1o1uWfvs9J8eykimQBB OUFjAzTN+g8hr5S8/C1ssGBczMle0w64EHXGO0v4fR+eYeh3jHT6MV8NNhBeSjTGzLwJ geoMt6EW5RxR7qpesq+68iFk1KW6jMykeeZhgqv+1vbny3knBV/aCihFPtEhF8jlFmDl A8Qx1ftdqra9ox/mPQ3YkMD6iEZtmCW/e11n9coxm8uvLp7zCGxyib+w+RGL4LmCRS4e tbXxl7eXNgN9Mww30Xj9K73P8T6W9gXRtRbNIIShwr7TYWcVYWk7eBzUG/ONaGxENKoK r8EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782032559; x=1782637359; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VrFSc8Rsq5ZiSM5SQJhJ/5/RkCPU5Th3OsJQ9UzvMSo=; b=VOZWmuhJcny/o0fW36SVIhEkM5C6RNqULIJDQ63483Exgstx+AQOwvYpzhPB7Qo3LF ei6YddWzreNtO/qVqSUt67+gOqvpO8eoHv7d4r3xhe1OC2aOhBZqNuqPFCSYrl0iWmoH uIu40ocPzAOjqEi2u9iOCk683eBT8miKnuqDbiPtYpay6BgTvkmJMYsiqRp5c2sW4+G1 R21K6NR3xHdb/2oSI/0UOELZ6SqHrabwhOt49YkOo49CPbg/M6BiQi2Fe/QScrt/xH0Y 0g4ptY4xXL16ZGgh/afRwBUbEMlJKS5hyzBJEfgLgt3x3elmDMOwkyJ39CqHENey5wSv b4VQ== X-Forwarded-Encrypted: i=1; AHgh+Rr6Fmcho0SAggghC0vSUyl6J4KOG+5t43Ox4vaYaW2Ghoi2+4ViM5i9KhOnusbh6ZFE9DrldplPNdxbq+k=@vger.kernel.org X-Gm-Message-State: AOJu0Ywek1U1gE8EGKQo8Z0gGBLPBno6O68vx+zljNVNpmbD/ZHHHUEi BvDnYHXfYlEk47LqWzwoqRcZ4Q4WWXtge44VTksHbCN+u0JPG7l0NLJ4 X-Gm-Gg: AfdE7clu4tUThzmePAgBS1X7VgR0tvBtNC1v/eJB4XeS18CibveJfcu5e4gXyxjXODM IMMR4BT9vnpG06ZtDxXCpqlkJhlxq+StFdrkJ2IciJn6LLKLkJArMTESlnQom5lk1eZtxZu7t+H 033+ka0TQLIWZmZqHsqlJRFJ+LEDk6PETmsg2RTIfMCntQKLrOxYEfLsDy7QBHeLj2o5ksxcHbW Ox6iGyRXmhk3LVL/uL5fA7sUbIGEhh8wlHKp16B/lhL/ihHfYv3YhQ73jKsPIMAiD7AX3tS2/fx f4wZIb6U1rXKNDUngxugpuzmgLtN+/W/X7uIicDjj/kToVKksbZr1gkBBOPZ/2oQfOGWMolOc2d gKnaymacdnEBQjLM93mtRXGsn9dxwgNZkKmWwn+fOJQUJk0xfdsTOL8OXi8yDf8mVPAqaGvQUSW FGPFzIFfyMl++r+f7XstOyKr339TEmWYfM X-Received: by 2002:a17:902:d547:b0:2bf:379b:53f5 with SMTP id d9443c01a7336-2c742b1ce7bmr64315145ad.23.1782032558834; Sun, 21 Jun 2026 02:02:38 -0700 (PDT) Received: from thefless.lan ([171.246.213.55]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c742fdd411sm46958055ad.0.2026.06.21.02.02.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2026 02:02:35 -0700 (PDT) From: Vu Nguyen Anh Khoa To: Alexander Graf , Arnd Bergmann , Greg Kroah-Hartman Cc: The AWS Nitro Enclaves Team , linux-kernel@vger.kernel.org, Vu Nguyen Anh Khoa Subject: [PATCH 1/2] misc: nsm: require CAP_SYS_ADMIN for raw ioctl Date: Sun, 21 Jun 2026 15:57:42 +0700 Message-ID: <20260621085743.76329-1-khoavna.tin.2225@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit NSM_IOCTL_RAW lets userspace submit raw NSM messages. The UAPI documents this ioctl as available only with CAP_SYS_ADMIN, but /dev/nsm is registered with mode 0666 and nsm_dev_ioctl() does not enforce that restriction. Reject unprivileged raw ioctl requests before accepting user-controlled NSM messages. Signed-off-by: Vu Nguyen Anh Khoa --- drivers/misc/nsm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/misc/nsm.c b/drivers/misc/nsm.c index ef7b32742..52790df7d 100644 --- a/drivers/misc/nsm.c +++ b/drivers/misc/nsm.c @@ -9,6 +9,7 @@ * space can use to issue these commands. */ +#include #include #include #include @@ -361,6 +362,9 @@ static long nsm_dev_ioctl(struct file *file, unsigned int cmd, if (cmd != NSM_IOCTL_RAW) return -EINVAL; + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + if (_IOC_SIZE(cmd) != sizeof(raw)) return -EINVAL; -- 2.43.0