From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12C1631E85E for ; Mon, 22 Jun 2026 14:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782139950; cv=none; b=MLQbZpVJxK4YMueCz/AW3ggAET4Z/HByDENQNVfFRlwbohhHT1JTRVkxm5eR3ydSJadVRLRCZduptB71ZANXUlLPhsqamuJPa1ql0Gd/0M6zFHp2M/HJ7x2Q73qhp7L665fgoZ8hM/9HMeJgJZd9yXlVwxXxZ2b15bI05iqGE7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782139950; c=relaxed/simple; bh=NLLKBnu6lqSK3tKr0zf8Ol0FHau/ZsBEgltC9ss3I24=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gq3oYeDl1x1dSBZ56B3rjosm1Hd5PwaY+kuU1Y9obCebVh0BAn7+Kd4PTOpTyb5oScF7hhs6mO++m9T7KNrxM4wKtOB2iD+VfCgWahO0aINWVT5F8puSqYyFINpD6Ul1d7lg4plkcC/Aqr55V9MLorLjyR1o5Ip2sFyag7XxTGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G6RTs88E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FCuP6h7H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G6RTs88E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FCuP6h7H" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MDFkjC701456 for ; Mon, 22 Jun 2026 14:52:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= m8oQmHlpKAP6CN522kTwBxFXdDgRU5YMpmBBrLHJmkk=; b=G6RTs88EJTSwo3Du 8ECKPNc55uT0zcnwwBTIGpQ9UqG+RFrOWM9agJnxliUG5hS466kIZg1dlS/5z4X0 8zQgracSCqadof8EoyOIpgxTJlNiNFKysjR2ATyAIdqE8XutEP4m/lIcEIfQzD8x Kcsd+oXhqdx7k+zAg2Oh0fRzPzBtgGaR1BNFKvz6QUoDU6/hd1XSIkRmd1dTcctF r4QgaZ//WFyIUIdIpNZgFcG4ybHpienip2gtKpVbgbbIJSj330L2k1gZbyKQsqJV n9EsDHq7HsCHI1XqIwcPlRJ73gFUWfW24HRN8YIR1Ndc2qg9A47h9Fsa8/x2Gfn2 qbNE3g== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey3a0rwqn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 14:52:28 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-139a4ac937dso93350c88.0 for ; Mon, 22 Jun 2026 07:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782139948; x=1782744748; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m8oQmHlpKAP6CN522kTwBxFXdDgRU5YMpmBBrLHJmkk=; b=FCuP6h7Hf29J0HBiEgqAqks69ncOQ2KxNaxh0NwOEYYqfMqcf67UY6vsJkaTHcvXOo 4cGTe1ye1B/zEicRPPxOxezqVAzhduGDAJW485L1fwyZhSFL/E9idyTWYrdo7Z0McJ5w oTfpGDT7c4tDVcqWwn/RvLiBMFlB+L/QWdM8Vvo67evew6NXeiq7LOYsL0zLJJNyvKAG ZOhJpPJPO9Mgxixs1u/ggbvM3VJIN0cAFHkNydijwW/6o0C3C+3hdI2/b76th9SE14tg /QLmA1XcaoGB3UcAuJ7tz58TEhQMpnHEFkt853go3c8O1sTiD9/6i2y51zxNcrvi+tKe Qx5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782139948; x=1782744748; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=m8oQmHlpKAP6CN522kTwBxFXdDgRU5YMpmBBrLHJmkk=; b=e4ck3QRsqmcLIj3PB02lX3HP2utMVhrxCtrkT3HwpwdDmzNmjMBjD6LsJxpMqX4hs9 7jup+3B5DZ9AN6iySqMubrYsmet1Vxltz31ERvpe2AEzGttESRRjJ7ouneEi0EmOYdfk mxwWIbO2bm/Cg4rXTJ2jTEF4IHELqTz7O0efcfDC4scmEUC8nVE76wW3+BVea4nC53km pputWXek0g3c1xHz7ZxKzwS5hCTU7lUhi6UU7OASAr5wMMTTMr85QEG5i16awygNDCAv iNbujhB0TSWuB5wHjEO29EAwrE9HD79UhFbouekyQkz3BK0AZHPukfHvjbzPl0+SrjW4 U67Q== X-Forwarded-Encrypted: i=1; AHgh+RqH2HzLS3OUQf6n3/eRjv3KNnz0qPN0KjIYQBfpPRHe1jTfO3AehoNoez9Pa2zzbs3aL2Mds1rO//la9XA=@vger.kernel.org X-Gm-Message-State: AOJu0YwPEp8phgYlhC3a3C7PYZWm2SsE8Sg0J5nfqcei0lT7RcFARUKh 20NcgTt274O+hZvZnq4DhYBet7VZTXs6y6Ibf5RDymvkCmUxheFudIxO5GAGVxqAKijX0ecQhGC ZGi6xtNgJ3LOgd5GZLTp6Nlrw8aXsymQesHEGApbjIFzAw7Gcb58DNl4qG8tly0UgfzA= X-Gm-Gg: AfdE7cmUifSeDYKbc76020SJECJ3jiKf9CFi9YztDiWJqwfcvxzAVI12s28d58GP824 CbHPYQAfk+DewHwkdVIP4Xvq9iGumdrFU1jrorYa+dfLFN1tMp8940hPLqN+u9AGnR3vXlwhWYg SBUgR48+ArGqSNDcuY0L0uGuzQJHJBkXOXMhQ2fFEpDAgCMoPwZTtkXVx0o2tl3UDV0kdWNCW5x LJk3lGDSnh7RurDI/He2sdoc9c4poYAGlRdE/IpouKc1crfu7iw/85nmAFFP5yOonme3cbLkcFJ ZPKUDAwhY2IM3iu5/aZZUrxvc/LP0J+kywmXqOEKU3BIfHgz2JrOfHDZhtpVgBMdGmy0/ztzssJ pF081gjiaQX+1q3ntUvxxqNQcOscMoLWEkWxGjyY+ZiWzoOmQN9KD8MTnOw== X-Received: by 2002:a05:7300:3b03:b0:2d4:62f0:b2e1 with SMTP id 5a478bee46e88-30c51fc533fmr234941eec.0.1782139947660; Mon, 22 Jun 2026 07:52:27 -0700 (PDT) X-Received: by 2002:a05:7300:3b03:b0:2d4:62f0:b2e1 with SMTP id 5a478bee46e88-30c51fc533fmr234925eec.0.1782139947125; Mon, 22 Jun 2026 07:52:27 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c1bddfe34sm12025561eec.20.2026.06.22.07.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 07:52:26 -0700 (PDT) From: Zijun Hu Date: Mon, 22 Jun 2026 07:52:25 -0700 Subject: [PATCH 12/13] Bluetooth: btqca: Fix undetected error HCI status in qca_send_reset() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260622-bt_bugfix-v1-12-11f936d84e72@oss.qualcomm.com> References: <20260622-bt_bugfix-v1-0-11f936d84e72@oss.qualcomm.com> In-Reply-To: <20260622-bt_bugfix-v1-0-11f936d84e72@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Rocky Liao , Bartosz Golaszewski , Ben Young Tae Kim , Balakrishna Godavarthi , Matthias Kaehlcke Cc: Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Augusto von Dentz , linux-arm-msm@vger.kernel.org, Zijun Hu X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDE0NyBTYWx0ZWRfX+aUvFqv+ABbM SJW7e25K2PluFI71GVYIkUYVc/WQKzl7rVASrxY5P76Ay/3JpfWlOGUdOmbXtaplGbJV5Girdfm TDNlmlzEawFTsehx3OfUwpB1a+TeIMs= X-Proofpoint-GUID: WRNQKbDV_G6hfzx0F9J-MKrybMxUh6x- X-Authority-Analysis: v=2.4 cv=UJ7t2ify c=1 sm=1 tr=0 ts=6a394c2c cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=6o5SJCVUQus6q_qBAWEA:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDE0NyBTYWx0ZWRfXynE85pM0sFSu IYh4tfLskRzDFYMNlcGkIfjpt9Fpvq1pKfSOkfBcEhXuJtww6/fT55iLDh4oMKc53+yLXpsyD11 tzZ7AGkC0Ei9atJjjmHVZoj0Ldd1pt5ZQE8+ccMKTBnr1fi7K82hK7ZdJIs9s/6gKpBSBhkLZUX AY5s2cyxYvgN+BqsFcAh8ZMUC4gX6MzEVI2lDS7CljGaJr8wH3YW6VDfOMa6LsW1OFD8WfSD884 lN2HCdW+VLf3jQrn+B4jQ+hmvNf2u2FM4eEXUQLb0OSIPnor0hTKYEPIlhdHz4VSuRmp8Fz7TH9 uLdIos2kLi5CPt/NncERuj4iZ0bzx7eM3sdfH7Xkr/FT6q1oawj/RhNCw4tbwc9UCscpuBD5kpZ crutfxHWs0KgYjcvLd8yYkPdmIf8sSvupB7fzsbbmhjmLHR10k4OYSdavhF/cuXou/1iu4gRRgR M6oF2c7JM49FYVQ/DrA== X-Proofpoint-ORIG-GUID: WRNQKbDV_G6hfzx0F9J-MKrybMxUh6x- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220147 qca_send_reset() uses __hci_cmd_sync() which returns an skb but never reads the HCI status byte from skb->data[0], so a non-zero error status returned by the controller is silently ignored. Fix by replacing qca_send_reset() with __hci_reset_sync() which properly extracts and converts the HCI status byte to a negative errno. Fixes: 83e81961ff7e ("Bluetooth: btqca: Introduce generic QCA ROME support") Signed-off-by: Zijun Hu --- drivers/bluetooth/btqca.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index 04ebe290bc78..875216e15603 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -190,25 +190,6 @@ static int qca_send_patch_config_cmd(struct hci_dev *hdev) return err; } -static int qca_send_reset(struct hci_dev *hdev) -{ - struct sk_buff *skb; - int err; - - bt_dev_dbg(hdev, "QCA HCI_RESET"); - - skb = __hci_cmd_sync(hdev, HCI_OP_RESET, 0, NULL, HCI_INIT_TIMEOUT); - if (IS_ERR(skb)) { - err = PTR_ERR(skb); - bt_dev_err(hdev, "QCA Reset failed (%d)", err); - return err; - } - - kfree_skb(skb); - - return 0; -} - static int qca_read_fw_board_id(struct hci_dev *hdev, u16 *bid) { u8 cmd; @@ -990,7 +971,8 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, } /* Perform HCI reset */ - err = qca_send_reset(hdev); + bt_dev_dbg(hdev, "QCA HCI_RESET"); + err = __hci_reset_sync(hdev); if (err < 0) { bt_dev_err(hdev, "QCA Failed to run HCI_RESET (%d)", err); return err; -- 2.34.1