From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D871210F1 for ; Mon, 22 Jun 2026 00:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782086581; cv=none; b=Dtwz5HoPCJKW+xqVz38utUCMU7f/Qu+SO7YlCguMK0S34W3Y0yKjhorAnb9PvvAOK2RGBwVwdIZFI5Jj3wLI+HPFv0djfosQ0P0CwgM2nTthel/ld3K0gMRRlSsnynher0MaugE2d5BYtd3J8HuL3XHgEg+MKk5JeuAfIvTs7WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782086581; c=relaxed/simple; bh=vpifS3qEEvwq2pMRImRPNb2WaiLOsD7Qfy8ZnKJWyQw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FGb1KVZGnW+8Dwy59i64Dr/C580SLk8e918LoQdg/kMX24sv2qDJohypuRPzGXlJbcGzg+NNDdhZuNCdS7uyLHoiBRXVNwjVbF3umdi2r/zW4OWVOEcDhc01iSmqFu6h8JSeu2jmgE2jUG/OVLlinXtIQPuj3Kf+M0rmX+lZLAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=evpVm+jF; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="evpVm+jF" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-45eeba68948so2850955f8f.1 for ; Sun, 21 Jun 2026 17:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782086578; x=1782691378; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=idLGngy4EJ9FPBvOW6cDJ7qwnwSjyLk7Zjw6tlhJ00s=; b=evpVm+jFb/eFzS2mOrmuNXhlCdsRuFsO1JZPnxrFu7s1z64xOHE6Na4W+pDqiFsXyu GVw/MjpsNu0PSrewwJcWdkOqRAQHXcv5QYwTQCNV+PbO5ZX6b94/RmzYPE1O/SSdL9KO u5TLyz62VvcS/fgeBklw/iS+ZWxsnj8+nNTmd2HgPAo3ZNBaFc9S75Ep7D6E4rJL16jJ Ztxrk7n70Yy3hkcc+7J/1lBcnAEHJDP/ze0OIv9TZYY+7rbmUcHm5fa2In2ba4UK0cA6 yw5HIMVAw+UtmoTnvPO/WED9RA86pVFn2lzpfgj0WMQK40g20PHtXQzUrLJVLsDy+bZp tn9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782086578; x=1782691378; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=idLGngy4EJ9FPBvOW6cDJ7qwnwSjyLk7Zjw6tlhJ00s=; b=nnZJmdRkgAVjQbjl2eRznngElEsm+uZtIcg7D2rX+2zRu3qgjTnnMBNHlFFa0q/S0A /u0W8M0+Sn7NfSVDWgFoGnakfzRUM6zqLTSV8GRxIDjWVAY72ONVNpnLUW3WGNfSMHZk J1Y7+WWw27MkkvbNxEIZD0QvVAL2PNPTGYJXz0mO3Y/hy0LBB2IYWoBb8gBbl65aMiHw yjmyhwRbsFr5u30VPlIaY64iQLq6pJXOF4osxsom+hrVBWP9whcWz8Js4oBlOZ1QLPMa uwTYCKRcoe/XcfBL8lTenBeku96mMhGTuPEsNkOe/d5SzSVAA1cLp4Q0Jm88XrDk08CX M6yA== X-Forwarded-Encrypted: i=1; AHgh+RrvToSr2dj6/QP8IZYE0WspdHsTLao6ATsX2TzM7fChG0iwV695Ul9xec0+PgPuD4VXWfI/HiBnYhlzmTE=@vger.kernel.org X-Gm-Message-State: AOJu0YwLKdNmbkAtxT/4q9Ds9r6MhAsuKemwfb63khxTApn96YcTgnB1 gQNvVQnap7cwyZu6z/BKmYeXWhuWVnyHmm4nVcHW1MuaiZiCV5HVecUC X-Gm-Gg: AfdE7cm5PKKa9+ToczDIZW1BYhwQsrSM19rNCxCSeYipCYlxjaA0BXVaZmlhevqc9ZJ PSzxN7qN6AxNILFPA1aS/MSEHr8JAWTERxt9pBgyzJEnD/KdRhtrSuNN79pRqXcWEo3uRjp3YeE Sdwqdgpv6KzwbSgxjNgBX9cTC7APER3+5ezjhyI2c5/68lp8sLyEFXwyCt+QXEdN73v0SO2PRUG V8HSeg+q0Lqde1dp/aP/0BSId9CwixlIoOxoTgQtyjkp2rz1s8WPraTV5XvWD25T+NcPPD3BHyo f0E20I6zgVJEf+lZescZBso38YmLwycCNENE7kd8myBE7Ff9b5AUnUQRNb2cxJdEw4KDdB3WvdE 056Y/p9Ix7J2JjQ32/l7TAd/QlaEz6pgjhSv3myGjTBv5t62b+nRhEROAuU3ygpZtxD9ElhD0cW 6LjucPd3d0BV3mzpdThbmPig== X-Received: by 2002:adf:e44c:0:b0:45e:d3d4:c230 with SMTP id ffacd0b85a97d-465090c5701mr15498971f8f.38.1782086578196; Sun, 21 Jun 2026 17:02:58 -0700 (PDT) Received: from user ([104.28.155.143]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-466648c5ddbsm22090260f8f.12.2026.06.21.17.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2026 17:02:57 -0700 (PDT) From: yahia To: W_Armin@gmx.de Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, yahia ahmed Subject: [PATCH] wmi/core Fix use-after-free in parse_wdg() Date: Mon, 22 Jun 2026 03:02:53 +0300 Message-ID: <20260622000253.210491-1-yahia.a.abdrabou@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: yahia ahmed Fix use-after-free in parse_wdg() function by setting wblock to null to prevent referencing freed memory, if wblock is freed in the if (retval) path and address a minor typo. Signed-off-by: yahia ahmed --- drivers/platform/wmi/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/wmi/core.c b/drivers/platform/wmi/core.c index 5a2ffcbab6af..9b5bd9ef5ba2 100644 --- a/drivers/platform/wmi/core.c +++ b/drivers/platform/wmi/core.c @@ -1328,6 +1328,7 @@ static int parse_wdg(struct device *wmi_bus_dev, struct platform_device *pdev) retval = wmi_create_device(wmi_bus_dev, wblock, device); if (retval) { kfree(wblock); + wblock = NULL; /* Set wblock to NULL to prevent a use after free */ continue; } @@ -1418,7 +1419,7 @@ static int wmi_notify_device(struct device *dev, void *data) return 0; /* The ACPI WMI specification says that _WED should be - * evaluated every time an notification is received, even + * evaluated every time a notification is received, even * if no consumers are present. * * Some firmware implementations actually depend on this -- 2.54.0