From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: trondmy@kernel.org, anna@kernel.org, linux-nfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com
Subject: [PATCH] NFS: invalidate i_blocks after COMMIT to fix stale block count on NFSv4
Date: Mon, 22 Jun 2026 14:00:38 +0800 [thread overview]
Message-ID: <20260622060038.13731-1-jefflexu@linux.alibaba.com> (raw)
NFSv4 COMMIT compound does not include GETATTR, and nfs4_commit_done_cb
does not refresh inode attributes. Meanwhile, every WRITE marks
NFS_INO_INVALID_BLOCKS via nfs_post_op_update_inode_force_wcc_locked.
After COMMIT, i_blocks remains stale until the next stat() triggers a
full revalidation. In writeback-heavy workloads where COMMITs happen
without intervening stat() calls, the cached block count can stay
indefinitely wrong.
Mark NFS_INO_INVALID_BLOCKS on successful COMMIT completion so that the
next nfs_getattr requesting STATX_BLOCKS will issue a GETATTR with
SPACE_USED, fetching the correct value from the server.
This matches NFSv3 behavior where nfs3_commit_done already calls
nfs_refresh_inode with the wcc_data post-op attributes.
Reproduce with xfstests generic/694 on NFSv4.0 loopback:
Server:
mount /dev/vdc /data/test
mount /dev/vdd /data/scratch
exportfs -o insecure,rw,sync,no_root_squash,fsid=1 127.0.0.1:/data/test
exportfs -o insecure,rw,sync,no_root_squash,fsid=2 127.0.0.1:/data/scratch
Client:
mount -t nfs -o vers=4.0 localhost:/data/test /mnt/test
mount -t nfs -o vers=4.0 localhost:/data/scratch /mnt/scratch
local.config:
export TEST_FS_MOUNT_OPTS="-o vers=4.0"
export MOUNT_OPTIONS="-o vers=4.0"
export FSTYP=nfs
export TEST_DEV=localhost:/data/test
export SCRATCH_DEV=localhost:/data/scratch
export TEST_DIR=/mnt/test
export SCRATCH_MNT=/mnt/scratch
This fixes xfstests generic/694.
Assisted-by: Qoder:Qwen3.7-Max
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
---
fs/nfs/write.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index d7c399763ad9..88c5c9f7434c 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1851,6 +1851,8 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data)
/* Latency breaker */
cond_resched();
}
+ if (status >= 0)
+ nfs_set_cache_invalid(data->inode, NFS_INO_INVALID_BLOCKS);
nfs_init_cinfo(&cinfo, data->inode, data->dreq);
nfs_commit_end(cinfo.mds);
--
2.19.1.6.gb485710b
next reply other threads:[~2026-06-22 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 6:00 Jingbo Xu [this message]
2026-06-22 13:56 ` Trond Myklebust
2026-06-23 4:04 ` Jingbo Xu
2026-06-23 4:51 ` Trond Myklebust
2026-06-23 4:54 ` Jingbo Xu
2026-06-23 13:40 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622060038.13731-1-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=anna@kernel.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®