From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E67D1233943; Mon, 22 Jun 2026 07:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782111890; cv=none; b=CyUiUFzpZtuqWbbCmXOHIeaNwKFHOPhpFzrk8KN6TGIHLSPWdemnDDQ6a4CyVmMaieLJ86RGQMHCE9BRFvIR7C8rwLik5oATD+WGk5nMtmY6pkDIXNHw9AxwO880RSt+3qlCLweQuDrS2VAlytCVKDYLFUh4RLOevWBMpg0XGgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782111890; c=relaxed/simple; bh=94ffQZN5smXw4dtist2N6Ff1+673ITZAbyoknLT5Ab0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZiSmab7i1pW2KEaApMnjm1RIMZT5zrs4auwfK+oDvEFXZeosiK5fwPQcdDF4SFe4s0JEoeabMphtVSBoKMOQhMPiUDLkiuaygoWeIKQAGcS2o1hq1EZ4wB52LLyNezr+dVMsvsrkFjG7ZPizca8m9f9IRIN4/vmjqjvZxkfxsqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=d32aRLLb; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="d32aRLLb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=LC l1kE52dxJs4SrnZw4dUUD9eSLe2/W5walU+U+dJtc=; b=d32aRLLbJF+QRdZWKO rRwSLOhr3AQjf7Qp5mgqmRJBAYFGgO5KRQzuvOWyJoTR/TCjTAs7CzkquZy9VJ2H aWtdrP65U92WVHHvNdiQPe4jrryBx7/Yhcd4+LmwIjDpwLiHnUrnR8Xqa3IitBc/ LH3wSP+rcRHVp4BPRraerMxe8= Received: from ubuntu.. (unknown []) by gzga-smtp-mtada-g0-0 (Coremail) with SMTP id _____wDHAhdZ3jhqsX6EEg--.791S4; Mon, 22 Jun 2026 15:04:01 +0800 (CST) From: Ma Ke To: srinivas.pandruvada@linux.intel.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, sumesh.k.naduvalath@intel.com, mgross@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Ma Ke , stable@vger.kernel.org Subject: [RESEND PATCH] platform/x86: ishtp_eclite: fix ACPI device reference leak in probe error path Date: Mon, 22 Jun 2026 15:03:52 +0800 Message-ID: <20260622070352.689982-1-make_ruc2021@163.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wDHAhdZ3jhqsX6EEg--.791S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7CryxZrWUuFW8WrW7Jr1rXrb_yoW8XFyDpF W7KFWrKrW5GrWfK348Xa18Z3Wruw1jv3y8GrWkCw4Uur45uF9aqayIka4YkF1kurWkJa45 ZFn7trW8AF1UZFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0piJGYdUUUUU= X-CM-SenderInfo: 5pdnvshuxfjiisr6il2tof0z/xtbC1AF4g2o43mHegwAA3e ecl_ishtp_cl_probe() acquires a reference to an ACPI device via acpi_find_eclite_device() but fails to release it in the error path when acpi_opregion_init() fails. This results in a reference count leak, preventing proper cleanup of the ACPI device. Calling path: acpi_find_eclite_device() -> acpi_dev_get_first_match_dev() -> acpi_dev_get_next_match_dev() -> bus_find_device() -> get_device(). Found by code review. Signed-off-by: Ma Ke Cc: stable@vger.kernel.org Fixes: 7b6bf51de974 ("platform/x86: Add Intel ishtp eclite driver") --- drivers/platform/x86/intel/ishtp_eclite.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/ishtp_eclite.c b/drivers/platform/x86/intel/ishtp_eclite.c index 93ac8b2dbf38..bca7e217878b 100644 --- a/drivers/platform/x86/intel/ishtp_eclite.c +++ b/drivers/platform/x86/intel/ishtp_eclite.c @@ -600,13 +600,16 @@ static int ecl_ishtp_cl_probe(struct ishtp_cl_device *cl_device) rv = acpi_opregion_init(opr_dev); if (rv) { dev_err(cl_data_to_dev(opr_dev), "ACPI opregion init failed\n"); - goto err_exit; + goto err_put; } /* Reprobe devices depending on ECLite - battery, fan, etc. */ acpi_dev_clear_dependencies(opr_dev->adev); return 0; + +err_put: + acpi_dev_put(opr_dev->adev); err_exit: ishtp_set_connection_state(ecl_ishtp_cl, ISHTP_CL_DISCONNECTING); ishtp_cl_disconnect(ecl_ishtp_cl); -- 2.43.0