From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7506439891F for ; Mon, 22 Jun 2026 12:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782132449; cv=none; b=edGJu+sJtpR76hXoRQHNqPqtK7NBRdR1XlEetHcOpnoovxpfVfgDewlczMRPsvlDsC59rjiZ/AWt0uaBsbvFoB2r3JMbpTuBKjtM+3SqxGPuhYHCoIn4zz7SREukslGwcY6VbLM+djz8SAsX9Odd1HP27KHgpz+5iO1xq3/NSKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782132449; c=relaxed/simple; bh=r34tRwutIEae76Arw0v4tM4Sksm6M9CnligQ4NA8L88=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BR647MOkrvJ3DLaVsQiNYqSODWmelahQP5muT1nygo+rvYgXyzdDzo9kMtySbAfrmj4WYeqpY74M8ok+WL6U7weQU13Q88tASdMzQHcqLeEnstAwbc7CVHqe89CGL7iE4vbtdHthDirJxfSmw0O3ePmYzraGMMLGRZRgiD36eKw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e49arQxp; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e49arQxp" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-9159477c893so518802785a.0 for ; Mon, 22 Jun 2026 05:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782132447; x=1782737247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GGaHlJZI0vCQSUxuwTTR6AioiUbLtcDhm8SXi6UjURE=; b=e49arQxp8Dw6Rkx6jx/1Y8NVSfSFAKNNecpdJNrdnwr7ZwLM95NLfUo9je0NVfzjio 0BxHTZmX33mqFKSdImB9bGoy4GlM2U7wGqRGXPVk5AFxjyzvrUxvNWsbJsgznL+/6E11 F25UeCOKwB7ehdXkNaIOAQXuyWT6Hdqm90iaa/6PgkTVtZgJQktpsW32LRtnx4/kjdaL UixhQlNYtEMdEqudvVzhXypHrrReAScNG5Cb1M7FvWOWf9VGBXK4G9hGsbc/uPVAzbI2 s1NYohucN/iORjLQt88SHqyptegUEZ3324gYmAl9v0C38g/Pdp3Cvi2FUPQ86iXmKfLf A+hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782132447; x=1782737247; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GGaHlJZI0vCQSUxuwTTR6AioiUbLtcDhm8SXi6UjURE=; b=WTJqy9DklDA9EJn3DpfHWSakPs3XzgnuT3nSXiLoJzOEslRvV4RJu1j0xQHnSk27cP Xe9MjLPVjLLTw5O1fp0ksJD/KEQmTZMIrJwOjX3mlnqSiFI3Wwy7W+UN+jRVpIexK7Zs OzFJw/ZduQkCaRyFGxvjhfvgaTQQhoCApgpUR2DwsoOrMvbVRw0fD+BCA2werC7YMqUO g+APBIPd06ctknr0tLH3Nqm95T2g+KcOU0sf20Gpx05/7FrwoQrFR6ehlMpf1mPpAhyU VqVCXT+4dpvnz6OSkVCivfX6Qjw3kfbawLGm0toxRJGk949ucDEaghBnit4H54KmEUPz /G5g== X-Forwarded-Encrypted: i=1; AFNElJ/MJhc28JrSPyFuHX2P83s/LWMIYRYrIkgsODAfsrMWdx3mV2ebX6dZ9d3OFvCO4k23Ki5QRMuiY+vfM/M=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8oceZOCeNxHIgeoQUuzyjTRf3b33xVlzltE82ClUdRyhkRdKE 5hKPRgCQeghYHcwhBt2tArfO9qxE/e5TpZljWNkyCBuxw0yK8tqg013C X-Gm-Gg: AfdE7ckmyQyzEn/4f4Jo/iDvWJAu0w3/5R03gO6xMfauW62KahSv8DRTewrNfOUpnw7 pwELP50yO3DZ66vLeOJwoNl76xczHpJWHbn2rbMjMeZ0KbLbOMb7oS6ITTa8joq2+LrAekIpuc8 bklAU7Vt5TyI5qxJeY8+h7r+6/aF65/sP1kVLFIx7Z/BTRohSDvzw9e9U8u0ty8+tFY5mM5Js76 q1D01WPLAcD2ccVQnZxfwtU03qIBpX0QBp3lcxiImxJ8yS2y9+qe73u1iBz2paJ/XVVh49H5j6M TyQqQYkkSjWzrDQeL6j6O8PNP0M1yW99xHMJ6t2B3Y5fkcM4lDd4CI7Kdb6k/z1SMfPobXWDYry 4AC6FGs+tY5/+EC/HSsaRGAX+VB0J1sID/sE7KM9D5Q2LN1tX3zxV7IlN5YL/q5MbYu9SHZ9lVo fuYu9f2lwDTx+nqSFlgLS51WJIRbCyphdCzqN203pZurd6Wo4pxX6rMPEl7b/UTH3CDxywTPVtJ ZRQRlYotHCWEAG7HT3B3ib7TFWreDXc X-Received: by 2002:a05:620a:258a:b0:910:bb22:d426 with SMTP id af79cd13be357-9209119b748mr2207051985a.33.1782132447374; Mon, 22 Jun 2026 05:47:27 -0700 (PDT) Received: from server0.tail6e7dd.ts.net (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-921d7f4b409sm923056985a.16.2026.06.22.05.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 05:47:26 -0700 (PDT) From: Michael Bommarito To: Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] um: vector: fix use-after-free in vector_mmsg_rx() Date: Mon, 22 Jun 2026 08:47:22 -0400 Message-ID: <20260622124722.1694157-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit When vector_mmsg_rx() discards a packet whose overlay header fails verify_header(), it frees the skb and continues the loop: if (header_check < 0) { dev_kfree_skb_irq(skb); vp->estats.rx_encaps_errors++; continue; } The normal and short-packet paths fall through to the bottom of the loop body, which clears the consumed slot and advances the cursors: (*skbuff_vector) = NULL; mmsg_vector++; skbuff_vector++; The verify_header() < 0 path skips that via continue, so the freed skb is left in skbuff_vector[] and the cursors do not advance. The next iteration reads the same slot, gets the freed skb, and frees it again, producing a refcount underflow / use-after-free in the RX path. Discard the slot the same way the other paths do before continuing. Only transports whose verify_header() can return negative are affected: GRE and L2TPv3 do so on a cookie/session-id mismatch (raw/tap do not), so any peer on such a transport can trigger it without authentication. Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Michael Bommarito --- Reproduced on a KASAN + refcount-full UML build: bring up a vec0 l2tpv3 device and send frames from the host with the right cookie but a wrong session id. Stock kernel logs repeated "uml_l2tpv3: session mismatch" then a refcount_t underflow / use-after-free in dev_kfree_skb_irq_reason() <- vector_poll() <- vector_mmsg_rx(); with this patch the mismatch is logged and the splat is gone (0 underflow, 0 use-after-free). Full dmesg and reproducer available on request. arch/um/drivers/vector_kern.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c index 2cc90055499a5..8a70b3a625537 100644 --- a/arch/um/drivers/vector_kern.c +++ b/arch/um/drivers/vector_kern.c @@ -995,6 +995,9 @@ static int vector_mmsg_rx(struct vector_private *vp, int budget) */ dev_kfree_skb_irq(skb); vp->estats.rx_encaps_errors++; + (*skbuff_vector) = NULL; + mmsg_vector++; + skbuff_vector++; continue; } if (header_check > 0) { base-commit: ef0c9f75a19532d7675384708fc8621e10850104 -- 2.53.0