From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap4.hz.codethink.co.uk (imap4.hz.codethink.co.uk [188.40.203.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053793988F8 for ; Mon, 22 Jun 2026 14:24:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.40.203.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782138250; cv=none; b=kDtVs8k/+Rp6AYpBpYYWyB+JD/bXCnDDaFh7ry9KcWVLf+prhKb26+CiyQeiX6DV+K2c36EndLzd4e7fE3R49CLpE8FFqZW6WmcJMSvSuP+q7iABE/bYHX33jjVJjkb6T2lz3Mx30TAtg2go6Jbw/6F+gCNE/M1D+QD2DG1aZPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782138250; c=relaxed/simple; bh=UqOko0NaIYOVIp1swccSiWA0nOjkEpxF1zA0o/iWRyo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Fxaf2l+FDeU5kjB9R0RZskOd3fMAl720XQyy441uGLhOZ35pFpex5mVbF3ls1Sl70OgiXYbYIBlL7MKNqBL/WPxdaIuAG0S1Cp4jaYDPV3JzZspHFqdA4F78EBgmP5t9r+W7iPnoBym+eBz3KMcztFl5fwjyxiNVO7U1H0C96AM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.com; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=leumnoGD; arc=none smtp.client-ip=188.40.203.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="leumnoGD" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap4-20230908; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:In-Reply-To: References; bh=n4dcnQDRYO7g/pijledoht4bAUk0uf+z8Em1nWTfv0s=; b=leumnoGD5LZ71B pHBi2q92ciQtCwK5pV2KwHivpCcR3MFR6kQM33GX6+IMp7uRo9y9Sdz/OsF+oWn1k80KTy/SrONM5 8zdNiWPtISUz9xUGtzkrNNB7ueuiqPf0iBHOJz2gCE5vctQMXTXVvdwCtTN0+G61Le48Pn0sTVBdQ 6HVVivdFCyEvHebJTg9MKkAGsVfWW/6i6V2N+QzOZKa+TTLFHcMhuHHzpPJrIwQPhPORFiRpiH/vp HdL9zZskLrvO60bWvhnecEDFeXHGZWi1IAlwKBtGAEY/D27CpWsROMxuKJfLxgLals46jXpzqwStr ui8iNHPxBYzuBXEEd0XQ==; Received: from [167.98.27.226] (helo=rainbowdash) by imap4.hz.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1wbfZ8-00EpVl-Lg; Mon, 22 Jun 2026 15:23:58 +0100 Received: from ben by rainbowdash with local (Exim 4.99.4) (envelope-from ) id 1wbfZ8-000000024i3-1CN0; Mon, 22 Jun 2026 15:23:58 +0100 From: Ben Dooks To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Ben Dooks Subject: [PATCH] nvme: make unexported sysfs structures static Date: Mon, 22 Jun 2026 15:23:57 +0100 Message-Id: <20260622142357.494750-1-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.37.2.352.g3c44437643 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: srv_ts003@codethink.com These sysfs attributes are not exported out of sysfs.c so make them static to remove the following sparse warnings: drivers/nvme/host/sysfs.c:397:25: warning: symbol 'dev_attr_io_errors' was not declared. Should it be static? drivers/nvme/host/sysfs.c:444:30: warning: symbol 'nvme_ns_diag_attr_group' was not declared. Should it be static? drivers/nvme/host/sysfs.c:1150:25: warning: symbol 'dev_attr_adm_errors' was not declared. Should it be static? Signed-off-by: Ben Dooks --- drivers/nvme/host/sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c index 933a5adfb7af..75b2d69b5957 100644 --- a/drivers/nvme/host/sysfs.c +++ b/drivers/nvme/host/sysfs.c @@ -394,7 +394,7 @@ static ssize_t nvme_io_errors_store(struct device *dev, return count; } -struct device_attribute dev_attr_io_errors = +static struct device_attribute dev_attr_io_errors = __ATTR(command_error_count, 0644, nvme_io_errors_show, nvme_io_errors_store); @@ -441,7 +441,7 @@ static umode_t nvme_ns_diag_attrs_are_visible(struct kobject *kobj, return a->mode; } -const struct attribute_group nvme_ns_diag_attr_group = { +static const struct attribute_group nvme_ns_diag_attr_group = { .name = "diag", .attrs = nvme_ns_diag_attrs, .is_visible = nvme_ns_diag_attrs_are_visible, @@ -1147,7 +1147,7 @@ static ssize_t nvme_adm_errors_store(struct device *dev, return count; } -struct device_attribute dev_attr_adm_errors = +static struct device_attribute dev_attr_adm_errors = __ATTR(command_error_count, 0644, nvme_adm_errors_show, nvme_adm_errors_store); -- 2.37.2.352.g3c44437643