From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 033D233C19E for ; Mon, 22 Jun 2026 18:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782152930; cv=none; b=T4KtYUqO2bDDFu/ybdbse7YBvoxuJSYKylT9MbnPiOz94lpbUv6RRP/wH1e3EGELWHctld4bqpChPaQl7WjnlFZ0z3mWcvOeVltq4XheNvyiaNNP0dib9yRcmeUvS80lXhO6gqbohTKefPidQzBOkcfSeFOsoB4n45fAdNQxEZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782152930; c=relaxed/simple; bh=Wajygr1xCS88wkbiv/zSCcaFCBJpsJIo8gHJvXgnJM8=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=ZpmXTUd4Rg8GRF1wZRS73PDJcdBRuRicbdPAr99oSd4bNiDeX1JuzFd+v3l0nWgvXDxX+8c34gq36lqRA4gksFA7xzFqxyjLTG5AY5BjBDMxkCX9nJ/WvAcigUMk3Etg8JXHiEjnnF04H1usdxDLwsMmX1whukHTTxJAMIsiwsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tadamsjr.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UR22GiXA; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tadamsjr.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UR22GiXA" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2c6af282daaso70713575ad.3 for ; Mon, 22 Jun 2026 11:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782152927; x=1782757727; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=lj/E13CApRr+dPq7lmFxUlfkRFlNtYVmYJyKopNC3jc=; b=UR22GiXAC8Ah9ErwIoEu0zrKwL5Mr12ffJkHsNLxBeI9sLYawgh6tyDfGxnQd+Rfq8 oy0kF+wKBgfpXKLemV7bozRqBdBqJar/J1xFdxNksF5aFc+ClV2BufDYIwKNfhdooYJx Kf7YdgGxiLJy56VTusD7S1wkS9r0+S3i162OhYjWu3M0CU6Bp1G7deUyNRU1BcaTFqeo rdf8oe5aSImL3zTinvCtXDb956frxxXJKSdCs5dFUXHw8fCiZMq8MqvsWxmGTIqizQsn P3JdqWMBQa6jtvtLNVbsJDL71N2FKcntJhYQvm3RoZquIs9Kk4S7nB1sWqoNoksprD/O PYKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782152927; x=1782757727; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lj/E13CApRr+dPq7lmFxUlfkRFlNtYVmYJyKopNC3jc=; b=qc/CUxm4rd/t2ZUI65EuUzGsUJ2OJo1runyi/ibr4inYBiyXJ7c3KVSL6nEkJU1m1l caA9n7npMO4z4zHnOSwfr0Zn3m/med64l/lzZL/ScTr2CoIJ0OIi5f19Icq8eNYhRYjI zFXrAu4q/G9NS6rUG20Jp0XPsB5ZXjSrUuOV04DCrnT7eTbVzYuZZqWJ7K3i3z02QMVf tdMzHGCVfD1nj41c5bRWnez5+Ct8l9MdZPsNjKYhAxj5lvFN9xr6yWJMCMOGQN+GmI5f SQjLH9fDeEzbXi1bAmExdTbU1+dmBHT3rzwKNRHvSGpzOK411n9XFb0TSmwu2TLo9VwO D2EQ== X-Forwarded-Encrypted: i=1; AHgh+Row/yaf87Y1BVjqywJrOXWZNraNUvoi22QYbFpjwzYkWks8ekEuaaNoYOC7gGWOShKXbZXdN1SkKyvI19Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxdHZzyToo02R8M+vXA/cVsOLqe7j/c/EE/ov+0wWF66kMcW/Yh BMS5+5AtGnWC81SLvzYvns+Iozgegwkc5Mfs1PHyeOdIxF19/AyYAPaIDyKOxFATpI0T+BG1Nqy 2oV0bRYCQzIipTQ== X-Received: from plbkn11.prod.google.com ([2002:a17:903:78b:b0:2bf:b2c:fa1d]) (user=tadamsjr job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ec85:b0:2c0:db23:4c1 with SMTP id d9443c01a7336-2c718c77ec9mr165834465ad.5.1782152926903; Mon, 22 Jun 2026 11:28:46 -0700 (PDT) Date: Mon, 22 Jun 2026 11:28:44 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.rc0.786.g65d90a0328-goog Message-ID: <20260622182844.2795777-1-tadamsjr@google.com> Subject: [PATCH] ata: libata-core: Allow capacity transition to zero for locked drives From: TJ Adams To: Damien Le Moal , Niklas Cassel , Hannes Reinecke , "Martin K. Petersen" Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv , Salomon Dushimirimana , TJ Adams Content-Type: text/plain; charset="UTF-8" Commit 91842ed844a0 ("ata: libata-core: Set capacity to zero for a security locked drive") introduced setting the device capacity (n_sectors) to zero in ata_dev_configure() if the drive is security locked. However, during runtime revalidation, ata_dev_revalidate() compares the new capacity (now 0) with the old capacity (>0) and detects a mismatch. Since it does not consider the locked status, it returns -ENODEV. This revalidation failure during Error Handling (EH) causes libata to eventually disable the device, offlining the SCSI device and resulting in subsequent accesses returning -ENXIO (No such device or address). Fix this by allowing the capacity transition to zero in ata_dev_revalidate() if the drive is reported as security locked by ata_id_is_locked(). Fixes: 91842ed844a0 ("ata: libata-core: Set capacity to zero for a security locked drive") Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Terrence Adams --- drivers/ata/libata-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 3b6243f0f91e..d090667979ca 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3974,7 +3974,8 @@ int ata_dev_revalidate(struct ata_device *dev, unsigned int new_class, /* verify n_sectors hasn't changed */ if (dev->class != ATA_DEV_ATA || !n_sectors || - dev->n_sectors == n_sectors) + dev->n_sectors == n_sectors || + (dev->n_sectors == 0 && ata_id_is_locked(dev->id))) return 0; /* n_sectors has changed */ -- 2.55.0.rc0.786.g65d90a0328-goog