From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81FE5346E5E for ; Mon, 22 Jun 2026 18:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782154146; cv=none; b=Qwl1R/N02/UDm0X9xVSDztsV7qK7e53Tsm+A8smjmQTL162DZxIBWST3XpwVkzjoHv/npsW8VH/qjxSO/4A4V0IDmqA1JqNRy5rp+4YdS7vDCsbuQoEwu+hF9+ZodI3K0VKHzR3dX71211tst1nuyInbiDpEQFBJtidwohYpcKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782154146; c=relaxed/simple; bh=bRZRmeuak8UGKeftukzPu9pf5prdsKVf2Hg9qG80Lio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sxARb9QDuwfUN76RAEJqjBZwwPMV/xWi46SJLOnDyQGxzDt6akoxA4RWWIFbvLv6AIQC/2UE2Uz9zP87dzKIc+4/o5nf2h07l9OE17Xv7sLBTXrqzO4uLXE7dzDb8xTE4t2xuiXhcIL7M3mbEXgTQACpoCU7hd490m8piUZZuzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZZTHm9pz; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZZTHm9pz" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-37d70036426so1072539a91.3 for ; Mon, 22 Jun 2026 11:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782154144; x=1782758944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I4LF8M4ghb+YPtxRjEmX1qyfcwiqHlXNeKROLqcS8Yw=; b=ZZTHm9pzpXzUNX8fIVqEEGaMoVgaaYrS8WTDL7czx7Z9Y0lvozd7nNxvFmiIFtsHmI Ecb7GVcedUu8UBejC0Ze4lTeLzmozvXqSlaye58jZndpA009clvH2GlKR3XFIDnnjJv9 p3XuI3tjcgiJuZc1PKABbUKa7pKcf6i654LJBwUplYIob5NUgAA/FNqnTC+g78UlUsMG KYtXt8/OjbfSPsFpZKU7iL77X+6lLsNjmq3o7U+NH7t6cK7M3jJUxHz7+W9P/kqsMAW4 MBTcVE/mUiBm4Gf5Vm4w1hHnq7Rflh7f69kcE381kkPXNuugA1G3WYhOsRwV3TIluHea p32w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782154144; x=1782758944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I4LF8M4ghb+YPtxRjEmX1qyfcwiqHlXNeKROLqcS8Yw=; b=sDOH9i1v/SILyPtjcx9CVWvsL3nKkoGlsZYVTkf6FCyhuEDYzbJVNq/DTT9WpbKto4 XQArc7m+4WJuPGOs4y9+JjfHJnxs8zm/H+u09wPEi25ppC/UUhPvz1qFUtPRQ8aF7Ru2 XA9P1pTAjUxmz7BwqbfFOAbvNIVcA01PvoQFYraQaNYXlzLTBXjWNM3BeO6s77DE4hAe Nnkr9GE3zKXe6UxqK+otc9dAVwKEmEYQkQjPkjiVJc33ZI4yqaH6SUqVQs2KuT5IPoof FzrQ1pbH3PiBaIB175ix/VtB1qqB5wNiHVze7qdwHQBy0NZgUT8YU5n+S0cS4Gl19B4i Yh2A== X-Forwarded-Encrypted: i=1; AHgh+RqThG1+OZNagU/UrpqK0N1A5br0e5IoQvM8pJij2p3dBp478fBA37MSZER1snhF6CLV6mHXNx4K9hz80wQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx31yCGgFLpexW/c1coIn47/1xrztfTfiRyJgcDNCDGC7ltIDTU iEnN3pAKbHIPTwt5r+C+i0UkfLx7z9JeA4gGjMIQWpXgpElEHdHqRoQc X-Gm-Gg: AfdE7ck+FjV04q4iPLbGavl1Y1NgMo21n/p9rsmZsOJiXSPUMDKhDyizJoZgaJmO/UQ LfQ9V7ZUBftsLo5uVkLiY5pabeRxYiqPfYbgJuicj2LOn2jcp1TT1nF9w/nI5H4lsD1tnO4TIbb 28g6KljVWgMbVwfprm8wx0T4OCJhmrxPiwgdVvCc3jribwd9ebrsAzstjfuFMjxEvSP5tWVKpMD 6yJ+5VHN6ZenCy2cxGjfTI7Zvjh8cNc1TXVWs7W3ZgD+M2xhjJUtETRGd3qN0d3Qfu7jKBRw5aO SEFohfQBkk0Do2l3zDDKdbH37XUL0jTVQeWl7uhQQGp6XJLlTzgYMCWh4Qd7w7CAsm5zaW5mNq/ mpvLXtRmeRor+9qjwve8fhCwqV3A0IG0B/MflTdUjAO+azIKsa2zUe5Mtx0BmQwYshY8HC1pIcE NHbYNFD+Oo+Lka5tN2fwPa71ISR3soxZ7K0IHR02OKnA== X-Received: by 2002:a17:90b:2687:b0:36d:b818:f848 with SMTP id 98e67ed59e1d1-37d16005c06mr14592066a91.5.1782154143209; Mon, 22 Jun 2026 11:49:03 -0700 (PDT) Received: from localhost.localdomain ([49.207.234.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f222bafsm7780517a91.7.2026.06.22.11.49.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 22 Jun 2026 11:49:02 -0700 (PDT) From: Biren Pandya To: Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Sakari Ailus , linux-kernel@vger.kernel.org, birenpandya@gmail.com Subject: [PATCH v2 3/5] media: i2c: msp3400-driver: Add missing media_entity_cleanup() Date: Tue, 23 Jun 2026 00:18:44 +0530 Message-ID: <20260622184840.66226-10-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260622184840.66226-7-birenpandya@gmail.com> References: <20260622184840.66226-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The remove function and the probe error path are missing calls to media_entity_cleanup(). Add them. Signed-off-by: Biren Pandya --- drivers/media/i2c/msp3400-driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/i2c/msp3400-driver.c b/drivers/media/i2c/msp3400-driver.c index 4c0b0ad68c08..48c60050c5d7 100644 --- a/drivers/media/i2c/msp3400-driver.c +++ b/drivers/media/i2c/msp3400-driver.c @@ -717,6 +717,7 @@ static int msp_probe(struct i2c_client *client) if (state->rev1 == -1 || (state->rev1 == 0 && state->rev2 == 0)) { dev_dbg_lvl(&client->dev, 1, msp_debug, "not an msp3400 (cannot read chip version)\n"); + media_entity_cleanup(&sd->entity); return -ENODEV; } @@ -812,6 +813,7 @@ static int msp_probe(struct i2c_client *client) int err = hdl->error; v4l2_ctrl_handler_free(hdl); + media_entity_cleanup(&sd->entity); return err; } @@ -865,6 +867,7 @@ static void msp_remove(struct i2c_client *client) msp_reset(client); v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&state->sd.entity); } /* ----------------------------------------------------------------------- */ -- 2.50.1 (Apple Git-155)