From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0819134BA28 for ; Mon, 22 Jun 2026 18:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782154157; cv=none; b=hbPBjLufv+NNaPu7753DoBKn4dGkIHzZN2PZVdxbLip+bNMWY6U9ns1QqgLKQx22dyLKyzK2LEL/6iBzzMJy9VptUaOZfxUIRiV+CZaJ/w73giyaa0lbXCHOhkRfb2cwPrf1bEZbzTyZM8cvMh38rlOVgsVOzvTpEn09B4YZ21A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782154157; c=relaxed/simple; bh=1OJ+icYvEUWlm8+gkxpBRGkF6MURV1kBnpa24faYVyg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fm3XdA7wuRUIaz2j4scu68ywFCNXExoCByk0NL9ttXg4yaW4gwkt5G6uvuQgXoZl+rS3hzU5ITUUJ33nRUeJYHFmI06fT2JheoJZCdllIB9GghyXX1qM9CxqTXmZoUcodkMgfD71FK2Ss7j6M5SbNdfMQjt9PsXiNg7FShyBhMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cWMUdoOc; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cWMUdoOc" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-36b9ec98144so3315728a91.1 for ; Mon, 22 Jun 2026 11:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782154152; x=1782758952; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EyiROYORTtKO75BwiwBGsAV70dzUHKAaS+4RZHI8OfY=; b=cWMUdoOcAd38/ybyZmdyyFS+wKolNGLNwpiKICgTksJQn9OwBc8V8Ck10E/LjMSiMU sHS4n9VnM5W2CQr5ZUV2eIspaau/ltoBIISYl9a+G2rmVhXBiHtVBcFcC8LmwFo+E1QO m7/GivdYIV698x1hc8KR9HbeNf3HP9GlM5YM/nvFSuaE2e+J9mGivPghsEXy/4gTvAIf CC4ZWyXe4/2jGJFTvgKUxG19cEqq+Q8P3xuBUytM8yLmE/W8Ht/MUGDkcaXhMUzXUqKb nfkE/hyA3+4qTSCbmf2jqVty/cQ6bsDPoy8t4XGs3GoWB6hI+a0awKvtkQM8OWHYlwDv 43VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782154152; x=1782758952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EyiROYORTtKO75BwiwBGsAV70dzUHKAaS+4RZHI8OfY=; b=A1i5MQb3F2raaGR44Ti6s2ohXT+08Vssac1hDoFinlORHpVCyaLgnJrMjIV2vS2eBa 95CRUKvUY14ePR7Y5Hekii8IHNiljlBjNDhQTl9pY2DQ5o3aCvO/USHj9I/vN9uPzZbg iuDMg+yFWk9yibRQMicGBeHPS93WgwsmhQjW+EQcX/tDnj+TQ2DEkKb6Wxa7cFVPSQgR MEZl5DAcXO2FV5DyWz/f0qcf04lHrY5ZGBHzyHjY+z5eREAXQ1iS3hg6LEBNkRy86rXJ OV4z/YQCSOf/6CaXpy4cnr3136PhCRvUBGMnlc5zK0554QhkIPIcQ51e1xn/eru/QY87 JDxg== X-Forwarded-Encrypted: i=1; AHgh+RrCyZeXKPU3XdhvxKASIYFKdw3epfodI1miGUPqiUPKOUyNyxaaE4q6dLjDdY/ys7gwsgbHPIRC81WjVEI=@vger.kernel.org X-Gm-Message-State: AOJu0YzeKvGLtY2edRTZgYsN3Fz48hsSSTPcoWobm9o0oCph2dP30mcm TiJVvBhVs/aRLCn+qoPATdWeYAsXD6fCWSUDVwTMcACAbOookhWadeir X-Gm-Gg: AfdE7ckN8Lf3f6HDRspsomGyXS6m4IPKxYVS8clA73SCMQl6FIv7fdT2usFT/4BkZDZ T0kMVBrubV+jNw4eVYo4MTofF8rOFjZx3FG81oRdv2YeaBO2hq50weKRmhaGm5p0FlFkrF1T4iE 0HMRHPwWkXskWKsDlF2PCWxwPRgwbyZWY5eFAIAReCtI71IiN/zS/e+XwNUKuG8AVclGyT9qQLm toNdADofRyTFlbTZHD2xYLMdWPY/kCBqafRKNo4Sn7LEssFXtWXoZXrcZMrvmDcJrPuSNKUbSd8 7oCAJVi1DFhtatnFP576MuWD+14FzK2cTIjXopo3WkcgvGO3m1/D4PA17/hkHLdlnvmw/vbi0wx TjnzkiVGZX2F5Fh4QZ/P++3akEG//bGMt6CcN2fOuQLDFaMWnyNLnnlkhsdF8+1SNE0be1TsUXE 3eJ+rhdODOTCFYGyH4AFb1wahSvhvwu1R+AvJlWQY0Vbij5r8UTPpb X-Received: by 2002:a17:90b:4985:b0:36a:fcf5:64d2 with SMTP id 98e67ed59e1d1-37d4e438e09mr10719512a91.16.1782154152143; Mon, 22 Jun 2026 11:49:12 -0700 (PDT) Received: from localhost.localdomain ([49.207.234.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f222bafsm7780517a91.7.2026.06.22.11.49.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 22 Jun 2026 11:49:11 -0700 (PDT) From: Biren Pandya To: Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Sakari Ailus , linux-kernel@vger.kernel.org, birenpandya@gmail.com Subject: [PATCH v2 5/5] media: i2c: saa7115: Add missing media_entity_cleanup() Date: Tue, 23 Jun 2026 00:18:46 +0530 Message-ID: <20260622184840.66226-12-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260622184840.66226-7-birenpandya@gmail.com> References: <20260622184840.66226-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The remove function is missing a call to media_entity_cleanup(). Add it. Signed-off-by: Biren Pandya --- drivers/media/i2c/saa7115.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c index 48d6730d9271..64adfff3001b 100644 --- a/drivers/media/i2c/saa7115.c +++ b/drivers/media/i2c/saa7115.c @@ -1867,6 +1867,7 @@ static int saa711x_probe(struct i2c_client *client) int err = hdl->error; v4l2_ctrl_handler_free(hdl); + media_entity_cleanup(&sd->entity); return err; } v4l2_ctrl_auto_cluster(2, &state->agc, 0, true); @@ -1925,6 +1926,7 @@ static void saa711x_remove(struct i2c_client *client) v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(sd->ctrl_handler); + media_entity_cleanup(&sd->entity); } static const struct i2c_device_id saa711x_id[] = { -- 2.50.1 (Apple Git-155)