From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90B21314A73 for ; Mon, 22 Jun 2026 18:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782154137; cv=none; b=avUapdNakuF8b7lz0zCST6JtD3TTdlQehbZFstn/5PXYS6gm81So+XeI1MlZI7vpwfk7BTQg0hlGjyqKon2e+32+GoIWToIG0Q1/xjEoIbu+RQWzeVRCil+QR1gJwj1baBVpaqKXu3RSy9gvciRVbJ9pf1z6Wv9bc74IiZAu3Ck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782154137; c=relaxed/simple; bh=kTxcJHE6iVe6RfB49bXDbrA6ICjAjhcYetRvA3pBtHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aSRY0tZDMZK2RdtwOrD9cGh8QxBv2feMIwGEO378Zt76uszs0uQR1d1E6yfIRywORe/zzPJOwd9gnkexEVWMjXDJTnEcDCIvN4y4m+TT2bHCt36RNrI425vzozUFutapdhfAOTc27A+/J8d5YTWsXdUDbrITo5lhFYU8H7qPJso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DGQPBxus; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DGQPBxus" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-37d826e9811so825905a91.1 for ; Mon, 22 Jun 2026 11:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782154136; x=1782758936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ctC2FHVouwwXy6nRKJZij8fpoFOJxlyQsKFiZ9amI48=; b=DGQPBxus85Av1lGB2K3X4VXwrRDsrfSPIWBtaXq6FN4aIRxrpac0ZTHoE6QRcYFL0K YuGpf6+JxXuJWcs6Ir19CQvLoLWadnNrydwBVuCPp67Oq7an3XTn/IqD9IB0Yx4mseWE YRG5drbnAsRkKK9Y2y0XnsZVJVguXbeOqTVemiYebOyNSZrEgDonTwdJTZn10OifG3us 5ELMFEcwH4tcDAgie//W9hwiH0u+3Y+TF779vRlwnfCKIg8BDfeZp0TEVS8OUVquaUyM QsX+KZDwZH/JkkRk+QsMR0vSaRhoclsKXiifmemD32mSdJQkUfrYbw1J3Cgg20/gM5GX eqZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782154136; x=1782758936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ctC2FHVouwwXy6nRKJZij8fpoFOJxlyQsKFiZ9amI48=; b=jWAiK1RjYLE4e+CwAJKmhLVSKNX5cDQ4P25LKYYU3okz0QpioIdei6ky7U50uEOcUJ r5gOjl9gFGvqE619/SxSl1hmPeNZeQ4GPD/f8cfSmFyTb2Pa5tjTkm9k1aBR5H1aQ8MQ th+fQuavEXqPvVcYhytyvyJ2xw7ljwzJ9gLnwWxXucn8ykuDTlzShPszx9DonMLNHcCi 9V4s3Mm4grBR/J3NdI/IcDoQnelYPoQ5/06yOmmEIEciLMPUKBS7WESUjkZvleL4IKxc n+wOPPbc3xVsCyd5OILQ8lrt8QvqISl+XgsTO5enfG69Q7HnF3IObAiICXRu+2Cuf0Fh sz9Q== X-Forwarded-Encrypted: i=1; AHgh+Rq2iNNvRVl9gUQXAsOJpGwsm2YCP+1l8VCVrQTozNZD9t6/XlpLH9u651X2r4DKPh2SWQCzlXYiKPFaS5Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3Eeg4UPzoiutQc129hJhxJfhII+IBF9vZ6YRVrceZ/3iyLGYO q/ui+ldoJFxbphYc/ix9ubncZ2OoH/gnqJspC+xtj373tCZoJPIOHPfy X-Gm-Gg: AfdE7ckOEmxIiAISJyd8Uh0nLtmu0bCDoWPOi8tiYF3hPqgGYjTv8x7O39Q5sWA31eR 8MOOWSVXP+MwNMcYJkAMzDEwsCQUmqARqrmS5o9iADma1Ej+BS4aCUm/gHJZaDt8d8tjIRR40ty yxEnkL+LnIESt+tRRiCTSxDo0Y09aI58xYTtXxQHwv25NKF2wpK2TJUx3XVXKeCcag/UUCsPqig iNwCfMBGkyc+UCBuoPKuV4WPon9MmQdb1BB4YBndJPDjovfjdHRyZuPw3ejjtLpAu9iELlN8UOH y1S+WYNB8Vd8cre+4oTI+M4nDzWEg2tAFxg5bm7T4OAoGyeNQnHtTS2omaFD2iLR9weYmuMZDmg q3h0Vw43W5nA7r39o0eYLVOL+yhedVAs/yYdhf1X0lPzLDOHfpWxEAxtIDwXW8XCH+i9oOero9H oz5Sf5zmZ3AphzytRfwRV9+gRQjFN/BWakZJlocxf7qQ== X-Received: by 2002:a17:90b:4fc7:b0:36c:e254:4db with SMTP id 98e67ed59e1d1-37d15de2dd5mr14416797a91.6.1782154135814; Mon, 22 Jun 2026 11:48:55 -0700 (PDT) Received: from localhost.localdomain ([49.207.234.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f222bafsm7780517a91.7.2026.06.22.11.48.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 22 Jun 2026 11:48:55 -0700 (PDT) From: Biren Pandya To: Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Sakari Ailus , linux-kernel@vger.kernel.org, birenpandya@gmail.com Subject: [PATCH v2 1/5] media: i2c: cx25840-core: Add missing media_entity_cleanup() Date: Tue, 23 Jun 2026 00:18:42 +0530 Message-ID: <20260622184840.66226-8-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260622184840.66226-7-birenpandya@gmail.com> References: <20260622184840.66226-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The remove function is missing a call to media_entity_cleanup(). Add it. Signed-off-by: Biren Pandya --- drivers/media/i2c/cx25840/cx25840-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c index 69d5cc648c0f..a3d7473854a3 100644 --- a/drivers/media/i2c/cx25840/cx25840-core.c +++ b/drivers/media/i2c/cx25840/cx25840-core.c @@ -3962,6 +3962,7 @@ static int cx25840_probe(struct i2c_client *client) int err = state->hdl.error; v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&sd->entity); return err; } if (!is_cx2583x(state)) @@ -3986,6 +3987,7 @@ static void cx25840_remove(struct i2c_client *client) cx25840_ir_remove(sd); v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&sd->entity); } static const struct i2c_device_id cx25840_id[] = { -- 2.50.1 (Apple Git-155)