From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E6DB157487 for ; Mon, 22 Jun 2026 18:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782154141; cv=none; b=Bws+b9cG8xwmewZoM4uUS9gLXmcUKr+/5LKcxOtPov+hM8hTE9RLsqNC1OLNe1FMJx4VtwSbNfnQMCIOK4a7Oz6cpng4tIIQgByDRQK4iVJzZIqRr0RWKg9XJHcnjTQ+ZtYvzM6hGXBn/NMoFhlsv4MsGmq3fYxX0bvOjhHtYvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782154141; c=relaxed/simple; bh=JzjOso7/wwynAxHjmTNccaM/1TFx/LTbSs5RRtSmy/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M7MKkEG1cTmAkGruyeM86Bp0GyeDIKFJZGh5ftkmDXIZkL+W1SzgLKK4r1ehHab6mwlUmPytT0tZaP+FZsjb+M8VSkUArVqaOu8hCc1u+2AQt/1YhBI6VDvyn3xdrz7jQP6QwxVLoNghdzL7i3qYrCz1BXKZg6ObwDukgbFagMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SX6pfWmo; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SX6pfWmo" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-37cae998401so2149948a91.0 for ; Mon, 22 Jun 2026 11:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782154140; x=1782758940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NC0uBNFhos9Xnquc35vsABLKrcnqiNY5ZuQAYS1JZAo=; b=SX6pfWmoneTPI+VmKqRzEJV8DkrXbNHaIc7AD2HAr5sFbw9nKXST7RQmnrQwGvf6Ap vS1LMJhBbOSiE5J9YjXYdgexSVJuIBk0+rkDClPnowfqxUBbvut2lrRPq5Qrj9YQlS1S 66buH7UGZDzeq3ujFIQx199qIIgni0sEkVSv6hw6DDIRzrXWIbHbLyPbvIbc48m9eE0U wH2bJ5fk0Lz88i+k/Su7WDbPRIIIdya8UfZVbyPaDGRUejKwWvUSM6ioQEfZFuwfo7LM jeQgXVOnmpvG9KqB/Bch1amxJ9X5YhKtduTdU9e636LnHqOQc8xbB1WEB8nj91MBscKi DPDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782154140; x=1782758940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NC0uBNFhos9Xnquc35vsABLKrcnqiNY5ZuQAYS1JZAo=; b=eafJQnTz/83iBsYz6lz74Ll8xyXStZZ7a6jQo+Mi8CE8I2yiB4NVd/L9OQoUmgLD9C 1r8QKiRjkpf/vW2qhcq+AU0TszyAdZjkmkaJdEnhdzaBZaAFqCezeomus1SrS5EPyDdT jkmSo3DFKrW5KnwWTZwlk4AG1QDyXmCw8XFk+3SljZuiWcZ684GgqHtI2xwOlG1rVgbL vT1pjKKfIxHZR+/hB1EVkdmAMZ19RJo1YPZwYlAmx3FL27Ovb+sXhnYJlXKmcggjAwbM K9EuhOQqOQthlODlW8UVwTht9dHYIyR3Iyey/ku8jdY210LbDWbm3rKIKoFzWQwFX8aV DlEQ== X-Forwarded-Encrypted: i=1; AHgh+Rryl1meozivhhYMVDWY4cZoSv8jSsYJOXZOzRSWtRV9dP+eOwmNWgPxNHy10LiRp98I4vC1ImU1rK2bv1s=@vger.kernel.org X-Gm-Message-State: AOJu0YwgLyBKC3bCEakiOqM65lzterlgLCRiRXVuP0VjhOGWAXjumJbM HDCNPbPKmm1JK/hwJTJR7e83z/igiw3284yYa6BT8IYsESCVUcrJImHb X-Gm-Gg: AfdE7cnI2j/iuCcjZDq1jTH2JpA/FDAFJiaK/9TLLqgx69yaGLmPZPXB2PUt3hjZJrM Cjh8XeBKPou5J3xZG7ORoQx1vV7S/aifWm59ezbRpfVRByXyc7tN1tfrkSLpiZ6tTZ/Z4JyBCbO +ndCfsUMy1oQLd3HqdIHqKe40eIcJLKYe6jdbEsVHLuPZpe1rAEDirEzBo77AdA2WjY8Lscn2fx bP/U26bLlvYJLY6diT9J+PWHO7pquJJfBAOQqjhBVyCggCHJ6j7OPZ6zsbS0X864LD7kZQA7tBs S//n5Q3VTjv7aKZosBNivnAdmCbnEXSuUZMmnvjS22hATEdgN3ANplylmjO36p7tsDKOhKAYpQx OCeHxhfISg7c/IgDR3e/kILMPKj8rn4sI9A25id4xlVtwO1P0Hdo2CTZmrCIyaKIejFxGvTxhui lUKsTau8LuMXtFRNT7iFnIu0saiMQo7Fy2a6NEFfiZSg== X-Received: by 2002:a17:90b:2d84:b0:37d:afda:faeb with SMTP id 98e67ed59e1d1-37dafdafb5fmr2996097a91.20.1782154139657; Mon, 22 Jun 2026 11:48:59 -0700 (PDT) Received: from localhost.localdomain ([49.207.234.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f222bafsm7780517a91.7.2026.06.22.11.48.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 22 Jun 2026 11:48:59 -0700 (PDT) From: Biren Pandya To: Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Sakari Ailus , linux-kernel@vger.kernel.org, birenpandya@gmail.com, Jacopo Mondi Subject: [PATCH v2 2/5] media: i2c: max9286: Add missing media_entity_cleanup() Date: Tue, 23 Jun 2026 00:18:43 +0530 Message-ID: <20260622184840.66226-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260622184840.66226-7-birenpandya@gmail.com> References: <20260622184840.66226-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The remove function is missing a call to media_entity_cleanup(). Add it. Reviewed-by: Jacopo Mondi Signed-off-by: Biren Pandya --- drivers/media/i2c/max9286.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index ac0712ce1e65..79eab9045e24 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1062,7 +1062,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv) priv->sd.state_lock = priv->ctrls.lock; ret = v4l2_subdev_init_finalize(&priv->sd); if (ret) - goto err_async; + goto err_entity; ret = v4l2_async_register_subdev(&priv->sd); if (ret < 0) { @@ -1074,6 +1074,8 @@ static int max9286_v4l2_register(struct max9286_priv *priv) err_subdev: v4l2_subdev_cleanup(&priv->sd); +err_entity: + media_entity_cleanup(&priv->sd.entity); err_async: v4l2_ctrl_handler_free(&priv->ctrls); max9286_v4l2_notifier_unregister(priv); @@ -1084,6 +1086,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv) static void max9286_v4l2_unregister(struct max9286_priv *priv) { v4l2_subdev_cleanup(&priv->sd); + media_entity_cleanup(&priv->sd.entity); v4l2_ctrl_handler_free(&priv->ctrls); v4l2_async_unregister_subdev(&priv->sd); max9286_v4l2_notifier_unregister(priv); -- 2.50.1 (Apple Git-155)