From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B84E0351C1C for ; Mon, 22 Jun 2026 20:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782159919; cv=none; b=q/iTSe9rJofBBOgOxkz2eklS6SMWJaOX5PGdeVs6frDHyspGEJfmYgKRN7gTNxFO4dCdqDbGOvEfgmFULHnTfAcshPe1AoL/z91y1E/FsFxSFgrkQHVXYCSK1QSj8SB7n9FXD5UN6j9L8kNe6ssnyO06SNB5uOdj2frGCb/bEDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782159919; c=relaxed/simple; bh=ClrZrjxVwXYuXS4Ew8V1x9Vq3DZCbpN6sFcZJZNzDxA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cImt8E0XjAcA3LKDWLtw0pMGLzWMUUqImHuW+A6kcmaCfGbw9yCCYTH5a7ETK9Komwbh2NW83hMHzch18592L4HIjgg6teJwdB2f5TPZRydL7gPX4ec2B3tm0Gq5J7uNjWPx+PlDm0MjID2Pgun2rP/UdrrEE51i5nTkoGkDYJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HU5/rgdi; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HU5/rgdi" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-463b2f6fc9dso662707f8f.2 for ; Mon, 22 Jun 2026 13:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782159916; x=1782764716; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hyKtbDLz+CZpHdtJKCRG+ThMRKtcjXWTRnrYGreiWAI=; b=HU5/rgdi6w7GoP52j+chrIYDQxm/eTZWMitUB7amZ+USNEOYeMAlALVjSK6TNasAYh NjPyCjw2ZHzDDtOTq8TaKs73zzikNELn4bCy7SaFeDc5wEMnFZ8BWi5L3qih/4UIgwBo KxnlOJxEhJppO4+dPE3UlmgJPGO+oltwERuqZNppVG3/EgJUApZuM/OFbHDHmzPke7+f 2ZuXfjuxt5ibVZgT+QbRigtUkZLs4JCRmUvaW69KeBzfLAiNPRAW1qvAaxH9S2vzvlXa yeQAXJbti1rz8Im/gfHpc1iOWC7eK2NK3lqYogeJiCQaAlqMb4dUYAYse8K2qPwf8AWp gacA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782159916; x=1782764716; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hyKtbDLz+CZpHdtJKCRG+ThMRKtcjXWTRnrYGreiWAI=; b=FzzeWGc8Dvtr6IOVnHuTKQg7ZB2N26UzW3zOguXHMA0V7Hq+jePTux2yMPEXgEXOdG ECNJvw7r6JwfWtpag3rH4CkvtDGsX25ztAsEZeXEcgMTarv7UQZ2ZGdUh6K5C1Xak7+L O9ygjgZFJfuVsBumGSLupwxIOZ3qC97HWyo0xtERJmws0jvWmjEUI3v477aWlnCas0fR sL+1rg44YBZNC7a9cC97napZ3kRFVKOP6xITJlOPrrdRM3lGZ1ywWcps6qJMreFiessl Swxw6l8CQPegF80GWe0S+zJrz6WX37VItFsUOWEXcdBc2vnEt3ssSsMPf/bQSjEClWkl WR0Q== X-Forwarded-Encrypted: i=1; AHgh+Rp3lCQazaYZ2s5m/xfQmZgZ0qBx6GPQ83WqbPei5sGsvUD64rOCSBAiHiR0EW3++mHKWxneCPpVcsBSxsk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl/roLo9zMMtHhymGEweGktEXF1s+VoEIDJjF6paiB03KIq5sO Z8GJVUTti4bSoRacfetLZIjpR80BwoBXxSI09n/piWNpvOgFZhQVdifE X-Gm-Gg: AfdE7ckBPY8OeINSOlOZIxciobCgw5iyoukHvvf09LvnqH3dYDLSA8AcMDVxrq5ZlWR CUqEVZnAoB5t/Etw1XGiitm0gCAKCrd3P/ND0WiH+rpuDCDYu+aP2L87XaYuHXuvzU7aTf8TlMT R3NUzIO1UdnNktGB3WRXAjXEENtG8gz9TbOqComq4TuCoQFIIPDIjrjrOtkb2FkmS7EJmoA6UKp 3ermq1aiG5Px5aYTm+uRKwUUOydM99Yy1g1JbiY6GtPtQyUuJApAXwgC1f4NIjiZxlL886ETFds Dh1eC5HFscQe6IguDBDFCy/2XzBd34jEyhuAHoKtpCQue19Cnz8qy4FJBa35In/iC4HvGBUmSHM bFEUq6ZHptFlGYarBewHi3nwIotCrYGeeiPn+ekiONBdqxIzx1bbjL4DmQc/dnkciTu/v6q5YHK iOlX5lhfYVxp4= X-Received: by 2002:a05:6000:490a:b0:46a:41d3:deba with SMTP id ffacd0b85a97d-46a41d3ded3mr3009729f8f.43.1782159915997; Mon, 22 Jun 2026 13:25:15 -0700 (PDT) Received: from user ([104.28.155.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4666cea9581sm27317307f8f.0.2026.06.22.13.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 13:25:15 -0700 (PDT) From: yahia To: W_Armin@gmx.de Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re [PATCH v3] wmi/core: fix use-after-free in wmi_add_device() Date: Mon, 22 Jun 2026 23:25:13 +0300 Message-ID: <20260622202514.41504-1-yahia.a.abdrabou@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Armin, As per the documentation, The automatic cleanup is only triggered if the supplier probes or unbinds Similarly, when the device link is added from supplier's ``->probe`` callback, ``DL_FLAG_AUTOREMOVE_SUPPLIER`` causes the device link to be automatically purged when the supplier fails to probe or later unbinds. To my understanding, the cleanup won't activate here because we don't unbind pdev nor does the probe fail. Best regards, yahia