From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D51C23793A8 for ; Mon, 22 Jun 2026 22:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782166581; cv=none; b=PMDvWU3R8pM/FyHr0eVFmrx1jK7YUSLa++1AgmhiPFFVx3Sb77QMoDegjyq0ezRKCbbgAbbuDRs3bWujgeu3/1d6lHAiEnMzhWz4shtdvI4nF9Qs3J1LJFlviPOjaAPxwsjMHYsUpDx/O3BLnd44acy7oZZ3mEbJvOqrCEnWdiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782166581; c=relaxed/simple; bh=i5eGL+0bjOTgStgBRZume+8QWckqbNTYKLWKt/J3/Nk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ushLg8I0wW9uW+cO1myENKpwCKeInPMmMjBT01ZT4guXOF0Uy7Y2v5ooZyiVgaEOfqDcWQRgPznJ3cOfLsVwH817qhZxpjbHCVTxudhcu/iJOPLMbAdC3+nsKdIi+cuq0EcLEdbvxkqYLjx3TuD0hUg64mOEjlSDXA/51UGsF/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mgwfReTk; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mgwfReTk" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-4624c1409c9so3621366f8f.3 for ; Mon, 22 Jun 2026 15:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782166578; x=1782771378; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nx/Y27zDaJEu50hN4vyc9cmgq80oWEzGh4CPSjvb3QU=; b=mgwfReTk4w/5vWK58+vTiaRKa8KJX1XdQvRbvOCst88Q6dFucUyYMjaE3wFjcHv+8x FkdkWhHMpHlHS0RnwC+u/vi2KCOw9tO00L+JOiSeSsyBDg4Q4ApD1RkhMCrSU53feSTy 2eGG5rLZUwjJy3+40vFraghHf44slVcv8jyjPYVu3z4hR2fczUlKEtdhhfwVOm4s/J94 ie0T04aLJ0AF2tEXoI8EoFVaVwPXZe/iYEt/mjBvj08sPtTnQedVKmT8Ld6//q+qVsZ1 2pZRLpcGHEp0Pr3Ncjvc+XP8pbIvthPyeJgzs5gJsyDy/Q73HdZABKPhypUUWEjiMdKi EYvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782166578; x=1782771378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nx/Y27zDaJEu50hN4vyc9cmgq80oWEzGh4CPSjvb3QU=; b=RsR/pyDJ0AS4FjxXUIp3JT5EjoHoLhfxCIuI69lbnwbsojCxnVYZvhk9ntCeJ6p0f2 XuyVJ1rwFl3cMkOGMwag0wxPhqbwbLj50CoJ0HhSju/n4I+J4wO1HAOF+vpowlhcf7YS nqisMTOfpRYtQt5OJOvtki8ZxsMKkgGtpsvwhjILdXET49WN5FodT6AJ0IPiD1jQqaws M0Tq7ksimrdUn4G45BcXlPmRevOuGnrF0JewCWpmCY1stU7Uv9OCg6KfqEtEIyC1DmGQ Kk+jkfcPnKIwmqCUyC6PyyTYNLjRlb4LEHlcbGeHTHn/fAB6ljRus4wVNVW5KyA5tNdv CTCw== X-Forwarded-Encrypted: i=1; AHgh+Ro3jkzM9bLRmf9muiv0DltZn1dhfoj9C90psoYvB8AvkbmM4aV1lbst449EOJDCB7E1iOOzfcQZXdX23Oo=@vger.kernel.org X-Gm-Message-State: AOJu0YyRTHK339HYNOyKbC4FF3q8rNTZdRH9yDja9q9FtzQVVVoDjaJI chHCV0REBapsO3ILctgVCZZ36Y21Pf9YlxOWZ2P1Tv0Gq0PQzchOjlyz X-Gm-Gg: AfdE7cnfTYJ7+VJUhdnjtMCW5l9k2UdOJfr7GFvpsqVQWGxoPA8fSqhufiTe3r8UeI5 ZfmpJQH52GGx1iIqpLkKL84Q10cUIVjXw6eJ/gueq0D+lhrBkYcDhY9TNjqScx8tZ9PXlxCMqPQ y7KAkQd8Y4a/tJrQIWGShuaq6fFb7NiTR6PZNl+MMe1ZfNTS0R+P39yzTOfR7BmG+rUCpVtxoW5 mdzGP0wu2InTzadcWOP3/VL6G4FDgScIi+F/iXTshWSL9gnaHgh6Y9gUOImC9nQQ1NLssXxTLZn 2aTV7qYB/0u/fuV8e8zCLOxBbE+PyzZPBmTQ2O9weIhABYWBvZe8YHUQiqGqG5Z6Z6yuGkmrnyD ro8g6cIt5AH6en9CZ4alPtB5m05JiW1EfUe7PCazgA1r8ySN12SNhD0bJGRZhQDBPxj6f5A7Z0M byuO8kCtXXxMOHUjGc25nof/r3TiCg X-Received: by 2002:a05:6000:4013:b0:454:a41f:d082 with SMTP id ffacd0b85a97d-466607440bcmr18403853f8f.3.1782166578349; Mon, 22 Jun 2026 15:16:18 -0700 (PDT) Received: from Nitro5-JS.kielce.vectranet.pl ([2a02:2a40:27ec:2900::3ab6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-466648c53fdsm31319845f8f.10.2026.06.22.15.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 15:16:17 -0700 (PDT) From: Jakub Szczudlo To: linux-iio@vger.kernel.org Cc: andy@kernel.org, antoniu.miclaus@analog.com, conor+dt@kernel.org, devicetree@vger.kernel.org, dlechner@baylibre.com, duje@dujemihanovic.xyz, jic23@kernel.org, jishnu.prakash@oss.qualcomm.com, jorge.marques@analog.com, joshua.crofts1@gmail.com, krzk+dt@kernel.org, linusw@kernel.org, jakubszczudlo40@gmail.com, linux-kernel@vger.kernel.org, marcelo.schmitt@analog.com, mazziesaccount@gmail.com, mike.looijmans@topic.nl, nuno.sa@analog.com, robh@kernel.org, sakari.ailus@linux.intel.com, wens@kernel.org Subject: [PATCH v4 3/3] iio: adc: Add ti-ads1110 support to ti-ads1100 driver Date: Tue, 23 Jun 2026 00:15:50 +0200 Message-ID: <20260622221550.374235-4-jakubszczudlo40@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260622221550.374235-1-jakubszczudlo40@gmail.com> References: <20260622221550.374235-1-jakubszczudlo40@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add ADS1110 support that have faster datarate than ADS1100, it also uses internal voltage reference of 2.048V for measurement. Signed-off-by: Jakub Szczudlo --- drivers/iio/adc/Kconfig | 6 +-- drivers/iio/adc/ti-ads1100.c | 81 +++++++++++++++++++++++++++--------- 2 files changed, 64 insertions(+), 23 deletions(-) diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 1c663c98c6c9..30198335c63b 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -1765,11 +1765,11 @@ config TI_ADS1018 called ti-ads1018. config TI_ADS1100 - tristate "Texas Instruments ADS1100 and ADS1000 ADC" + tristate "Texas Instruments ADS1100 and similar single channel I2C ADC" depends on I2C help - If you say yes here you get support for Texas Instruments ADS1100 and - ADS1000 ADC chips. + If you say yes here you get support TI ADS1100 and similar single + channel I2C Analog to Digital Converters. This driver can also be built as a module. If so, the module will be called ti-ads1100. diff --git a/drivers/iio/adc/ti-ads1100.c b/drivers/iio/adc/ti-ads1100.c index e3c801381434..ec79a89464fb 100644 --- a/drivers/iio/adc/ti-ads1100.c +++ b/drivers/iio/adc/ti-ads1100.c @@ -5,7 +5,7 @@ * Copyright (c) 2023, Topic Embedded Products * * Datasheet: https://www.ti.com/lit/gpn/ads1100 - * IIO driver for ADS1100 and ADS1000 ADC 16-bit I2C + * IIO driver for ADS1100 and similar single channel ADC 16-bit I2C */ #include @@ -40,20 +40,44 @@ #define ADS1100_SINGLESHOT ADS1100_CFG_SC #define ADS1100_SLEEP_DELAY_MS 2000 +#define ADS1110_INTERNAL_REF_mV 2048 static const int ads1100_data_rate[] = { 128, 32, 16, 8 }; +static const int ads1110_data_rate[] = { 240, 60, 30, 15 }; static const int ads1100_data_rate_bits[] = { 12, 14, 15, 16 }; /* Timeout based on the minimum sample rate of 8 SPS (7.5s) */ #define ADS1100_MAX_DRDY_TIMEOUT_US 7500000 +struct ads1100_config { + const char *name; + const int *data_rate; + const int data_rate_count; + bool has_internal_vref_only; +}; + +static const struct ads1100_config ads1100_config = { + .name = "ads1100", + .data_rate = ads1100_data_rate, + .data_rate_count = ARRAY_SIZE(ads1100_data_rate), + .has_internal_vref_only = false, +}; + +static const struct ads1100_config ads1110_config = { + .name = "ads1110", + .data_rate = ads1110_data_rate, + .data_rate_count = ARRAY_SIZE(ads1110_data_rate), + .has_internal_vref_only = true, +}; + struct ads1100_data { struct i2c_client *client; struct regulator *reg_vdd; struct mutex lock; int scale_avail[2 * 4]; /* 4 gain settings */ + const struct ads1100_config *ads_config; u8 config; - bool supports_data_rate; /* Only the ADS1100 can select the rate */ + bool supports_data_rate; }; static const struct iio_chan_spec ads1100_channel = { @@ -89,6 +113,14 @@ static int ads1100_set_config_bits(struct ads1100_data *data, u8 mask, u8 value) return 0; }; +static int ads1100_get_vref_milivolts(struct ads1100_data *data) +{ + if (data->ads_config->has_internal_vref_only) + return ADS1110_INTERNAL_REF_mV; + + return regulator_get_voltage(data->reg_vdd) / MILLI; +} + static int ads1100_data_bits(struct ads1100_data *data) { return ads1100_data_rate_bits[FIELD_GET(ADS1100_DR_MASK, data->config)]; @@ -114,6 +146,9 @@ static int ads1100_get_adc_result(struct ads1100_data *data, int chan, int *val) if (ret < 0) { dev_err(&data->client->dev, "I2C read fail: %d\n", ret); return ret; + } else if (ret < 2) { + dev_err(&data->client->dev, "Short I2C read\n"); + return -EIO; } /* Value is always 16-bit 2's complement */ @@ -184,7 +219,7 @@ static int ads1100_set_scale(struct ads1100_data *data, int val, int val2) if (ret) return ret; - microvolts = regulator_get_voltage(data->reg_vdd); + microvolts = ads1100_get_vref_milivolts(data) * (MICRO / MILLI); /* * val2 is in 'micro' units, n = val2 / 1000000 * result must be millivolts, d = microvolts / 1000 @@ -209,9 +244,9 @@ static int ads1100_set_data_rate(struct ads1100_data *data, int chan, int rate) unsigned int size; int ret; - size = data->supports_data_rate ? ARRAY_SIZE(ads1100_data_rate) : 1; + size = data->supports_data_rate ? data->ads_config->data_rate_count : 1; for (i = 0; i < size; i++) { - if (ads1100_data_rate[i] != rate) + if (data->ads_config->data_rate[i] != rate) continue; PM_RUNTIME_ACQUIRE_AUTOSUSPEND(&data->client->dev, pm); @@ -233,14 +268,9 @@ static int ads1100_set_data_rate(struct ads1100_data *data, int chan, int rate) return -EINVAL; } -static int ads1100_get_vdd_millivolts(struct ads1100_data *data) -{ - return regulator_get_voltage(data->reg_vdd) / (MICRO / MILLI); -} - static void ads1100_calc_scale_avail(struct ads1100_data *data) { - int millivolts = ads1100_get_vdd_millivolts(data); + int millivolts = ads1100_get_vref_milivolts(data); unsigned int i; for (i = 0; i < ARRAY_SIZE(data->scale_avail) / 2; i++) { @@ -262,9 +292,9 @@ static int ads1100_read_avail(struct iio_dev *indio_dev, switch (mask) { case IIO_CHAN_INFO_SAMP_FREQ: *type = IIO_VAL_INT; - *vals = ads1100_data_rate; + *vals = data->ads_config->data_rate; if (data->supports_data_rate) - *length = ARRAY_SIZE(ads1100_data_rate); + *length = data->ads_config->data_rate_count; else *length = 1; return IIO_AVAIL_LIST; @@ -283,6 +313,7 @@ static int ads1100_read_raw(struct iio_dev *indio_dev, int *val2, long mask) { int ret; + int data_rate_index; struct ads1100_data *data = iio_priv(indio_dev); guard(mutex)(&data->lock); @@ -299,12 +330,12 @@ static int ads1100_read_raw(struct iio_dev *indio_dev, return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: /* full-scale is the supply voltage in millivolts */ - *val = ads1100_get_vdd_millivolts(data); + *val = ads1100_get_vref_milivolts(data); *val2 = 15 + FIELD_GET(ADS1100_PGA_MASK, data->config); return IIO_VAL_FRACTIONAL_LOG2; case IIO_CHAN_INFO_SAMP_FREQ: - *val = ads1100_data_rate[FIELD_GET(ADS1100_DR_MASK, - data->config)]; + data_rate_index = FIELD_GET(ADS1100_DR_MASK, data->config); + *val = data->ads_config->data_rate[data_rate_index]; return IIO_VAL_INT; default: return -EINVAL; @@ -373,6 +404,7 @@ static int ads1100_probe(struct i2c_client *client) struct iio_dev *indio_dev; struct ads1100_data *data; struct device *dev = &client->dev; + const struct ads1100_config *model; int ret; indio_dev = devm_iio_device_alloc(dev, sizeof(*data)); @@ -404,6 +436,13 @@ static int ads1100_probe(struct i2c_client *client) if (ret) return ret; + model = i2c_get_match_data(client); + if (!model) + return dev_err_probe(dev, -EINVAL, + "Can't get device data from firmware\n"); + + data->ads_config = (struct ads1100_config *)model; + ret = ads1100_setup(data); if (ret) return dev_err_probe(dev, ret, @@ -466,16 +505,18 @@ static DEFINE_RUNTIME_DEV_PM_OPS(ads1100_pm_ops, NULL); static const struct i2c_device_id ads1100_id[] = { - { .name = "ads1100" }, - { .name = "ads1000" }, + { .name = "ads1000", .driver_data = (kernel_ulong_t)&ads1100_config }, + { .name = "ads1100", .driver_data = (kernel_ulong_t)&ads1100_config }, + { .name = "ads1110", .driver_data = (kernel_ulong_t)&ads1110_config }, { } }; MODULE_DEVICE_TABLE(i2c, ads1100_id); static const struct of_device_id ads1100_of_match[] = { - {.compatible = "ti,ads1100" }, - {.compatible = "ti,ads1000" }, + { .compatible = "ti,ads1000", .data = &ads1100_config }, + { .compatible = "ti,ads1100", .data = &ads1100_config }, + { .compatible = "ti,ads1110", .data = &ads1110_config }, { } }; -- 2.47.3