From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10BA61F099C for ; Tue, 23 Jun 2026 12:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782219026; cv=none; b=kdVjOTTzeWkyHP8vpvHZqBdJUqW8fRRKojAr9gMQVsu19d5f8DAyfk8D1xtJwgm/U+gJ1FzfgcLXBWcVUJNdEJLS7/F2cOjf+b1VvYEDBtmNW4Nr/T7zREW1KFdDaPXvc9KGjYZJLn+IS3aQYDEUy6QiWMEse44hkFTxp/1jOwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782219026; c=relaxed/simple; bh=ScFFqr1Y4T5ka4YvBc6DVkvQUgWEMOdpk05Ur+4sxPI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bvwduSJHVlBRxHw3PLH+OcY1pR13/OaUot235zKUn2u/FLbWWM811N/qeVWQe+42D1ftjiThLPmjOpetRGwcDMEn8hKDS0mYsxqoSNTQERz0z3wyzLSs2Ozv7HYmd7wvxAZX9Nzi/FC4vfbTQjJh/ZK1TPPUQzFtf3qNzLcOAis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cr+2dggi; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cr+2dggi" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-697e96dd8d2so128350a12.1 for ; Tue, 23 Jun 2026 05:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782219023; x=1782823823; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UKUs6CELJR/1Q1bIKn9jYUW7U/GC0CCNgQj6pM1EaDs=; b=Cr+2dggirb/s+iJWHki8cFQ/1fxBX/wfW673B1A2yDV5/T06EQlG4blIo6Au1KO7bL Rxr4KcGaA28gHI4bYkWL5ymEltiI2SCd9Wx7iEJupbycY/nQBa5+UN0C72i80sS1AA/z oSh5r2YjALapGGgVEXVQyS1VvC4MAiRSRrd/PxNsh4gaON7FWW1vtCEhHebRRRorKU9h dHVDyE81rmEOJTHF1UVE07pcBkfg6Gaq//0q4kiWsieTQ6DqLwCThLuCSJj9ExisQRBl ZPIXD0XXJZnODOMyvQI8H1nmKlV+EYzMy/rSM0SU+2J4DO5fyqisyU/QnLKG6WC0PoyB dt2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782219023; x=1782823823; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UKUs6CELJR/1Q1bIKn9jYUW7U/GC0CCNgQj6pM1EaDs=; b=V12PQoIDXhCV0JC43t7H0FWLRjxtx0FhTmQN6Wim83Mn1FVY/k8NEeXWeW6mcyLlyY FfhzExBzT3X4QJxzZ6M9BOgoVr0WEgRzT2bNrFGIKNtVRRdc/2CTGIZDgZ/1FM7kWaLU V/da9GqPuOqTsg8RdDjU+pa492UWko9FyCCH6ywOl5fL0IuQkyoZUtKIohR3JQKyWwgy FKkJUGtFxWwhdNR8t6QT8HZJ8OakZzi/MBfZyY0KhYnqpokLKuhDC7E2Emkl5uJAhiZk 7Epdthd1ty1NAjPKWooV8/Z7lPQhDFM1WaFy4w6qzXYeZO5u/FSDI8VCFKYzbgKFUllB 3wMg== X-Forwarded-Encrypted: i=1; AFNElJ/mbzz1SoxEk5quNbxZfLnbeFBH+Xng2Fa5g9rZr5A+MgI+JrttsT25wHn5u1cfv4L4akwViqLbpK3JN9Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwpCh55pKEy63ug+u0c/lWQLNohtiWySuYKrMguFbJhPaZWfABd LnnqDuBsjn7r2sEklbDTLw7/55MjyRwM6u07H2kNoDQLosy6+Go0LA1P X-Gm-Gg: AfdE7cmTac4v7dJdyZjXgbLJ4o94dr7f01C27leazwv8EJH09hmiMonFIALLRjjSNki tE6U+/yxShVrX1UlpliDvJYl3rAgFJk1GuK/4/2q8i5T4kxWZyyXrShtat/x6775pFuoNOS3cNC ys/4W9bzaFw0S3kx5UW/TJWnqBC2ruyhnSTyROWFAqHk5ziKLQxIucI2rkOdp19Bh+mJwQZTQzr /uMVfLHDwt9rL1mtV5FoyTBgGVUavGwf+E4tW1oxaCq1LiDhD+GVPMPK0vzZVyFc0LoOeQwcgsV 1YlAem4/et6G84c0ZLHU87s67c2eDadsMagRQJd+42GpT9fb+az0NEYuTnOL5rha65aly2RVJKB Ar11wOtc6EFlLZyJ2vU3/m1P50ib52yaScXfu26c22KOMUEcJvq0Jc/eNu7wVxc7MBrgYQ2H3xz tAiODciFAsRWYl8nELWtXp X-Received: by 2002:a17:907:ec0a:b0:c0f:cbe9:9e7a with SMTP id a640c23a62f3a-c10309ba1acmr182459466b.15.1782219023302; Tue, 23 Jun 2026 05:50:23 -0700 (PDT) Received: from [127.0.0.2] ([194.35.121.133]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977b82fd6fsm5153967a12.2.2026.06.23.05.50.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 05:50:22 -0700 (PDT) From: Diogo Silva Date: Tue, 23 Jun 2026 14:49:44 +0200 Subject: [PATCH 2/2] drm/exynos: Add error handling to drm_encoder_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260623-exynos-drm-simple-v1-2-bb52f098b1ee@gmail.com> References: <20260623-exynos-drm-simple-v1-0-bb52f098b1ee@gmail.com> In-Reply-To: <20260623-exynos-drm-simple-v1-0-bb52f098b1ee@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Diogo Silva X-Mailer: b4 0.14.3 Not handling the return code on drm_encoder_init can lead to silent failure and/or a drm_encoder_cleanup on a non-initialized encoder. This patch adds error handling to the drm_encoder_init calls to prevent that from happening. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 6 +++++- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 7 ++++++- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 +++- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 7 ++++++- drivers/gpu/drm/exynos/exynos_hdmi.c | 7 ++++++- 5 files changed, 26 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index a2095fb43483..3311674aa32a 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -99,8 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + dev_err(dp->dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 4a3d443a15e6..495fcabca0a1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -198,8 +198,13 @@ int exynos_dpi_bind(struct drm_device *dev, struct drm_encoder *encoder) { int ret; - drm_encoder_init(dev, encoder, &exynos_dpi_encoder_funcs, + ret = drm_encoder_init(dev, encoder, &exynos_dpi_encoder_funcs, DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + DRM_DEV_ERROR(encoder_to_dpi(encoder)->dev, + "failed to create encoder ret = %d\n", ret); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dpi_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 25c438cdc744..73f7c9fe611a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -83,8 +83,10 @@ static int exynos_dsi_bind(struct device *dev, struct device *master, void *data struct drm_device *drm_dev = data; int ret; - drm_encoder_init(drm_dev, encoder, &exynos_drm_dsi_encoder_funcs, + ret = drm_encoder_init(drm_dev, encoder, &exynos_drm_dsi_encoder_funcs, DRM_MODE_ENCODER_TMDS, NULL); + if (ret) + return ret; ret = exynos_drm_set_possible_crtcs(encoder, EXYNOS_DISPLAY_TYPE_LCD); if (ret < 0) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index b0f3cfc2a283..a639f2ee4933 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -449,8 +449,13 @@ static int vidi_bind(struct device *dev, struct device *master, void *data) return PTR_ERR(ctx->crtc); } - drm_encoder_init(drm_dev, encoder, &&exynos_vidi_encoder_funcs, + ret = drm_encoder_init(drm_dev, encoder, &&exynos_vidi_encoder_funcs, DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + DRM_DEV_ERROR(dev, "failed to initialize encoder ret = %d\n", + ret); + return ret; + } drm_encoder_helper_add(encoder, &exynos_vidi_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 26baf5357997..17323c9233ad 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1867,8 +1867,13 @@ static int hdmi_bind(struct device *dev, struct device *master, void *data) hdata->phy_clk.enable = hdmiphy_clk_enable; - drm_encoder_init(drm_dev, encoder, &exynos_hdmi_encoder_funcs, + ret = drm_encoder_init(drm_dev, encoder, &exynos_hdmi_encoder_funcs, DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + DRM_DEV_ERROR(dev, "failed to initialize encoder ret = %d\n", + ret); + return ret; + } drm_encoder_helper_add(encoder, &exynos_hdmi_encoder_helper_funcs); -- 2.51.2