From: Dmitry Guzman <Dmitry.Guzman@mobileye.com>
To: Andi Shyti <andi.shyti@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Linus Walleij <linusw@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Dmitry Guzman <Dmitry.Guzman@mobileye.com>
Subject: [PATCH 2/7] i2c: nomadik: optimize layout of struct nmk_i2c_dev
Date: Tue, 23 Jun 2026 19:31:49 +0300 [thread overview]
Message-ID: <20260623-i2c-fault-reporting-v1-2-6db1a8aabf18@mobileye.com> (raw)
In-Reply-To: <20260623-i2c-fault-reporting-v1-0-6db1a8aabf18@mobileye.com>
Put two bool variables `xfer_done` and `has_32b_bus` and two char
variables `tft` and `rft` together in order to reduce struct size
wasted for padding.
Signed-off-by: Dmitry Guzman <Dmitry.Guzman@mobileye.com>
---
drivers/i2c/busses/i2c-nomadik.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index b63ee51c1652080e414f4302bee16905914c1288..e4e5c6943c66144058fba857d7bf6c0be79ed5bd 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -187,13 +187,13 @@ struct i2c_nmk_client {
* @clk_freq: clock frequency for the operation mode
* @tft: Tx FIFO Threshold in bytes
* @rft: Rx FIFO Threshold in bytes
+ * @xfer_done: xfer done boolean.
+ * @has_32b_bus: controller is on a bus that only supports 32-bit accesses.
* @timeout_usecs: Slave response timeout
* @sm: speed mode
* @stop: stop condition.
* @xfer_wq: xfer done wait queue.
- * @xfer_done: xfer done boolean.
* @result: controller propogated result.
- * @has_32b_bus: controller is on a bus that only supports 32-bit accesses.
*/
struct nmk_i2c_dev {
struct i2c_vendor_data *vendor;
@@ -206,13 +206,13 @@ struct nmk_i2c_dev {
u32 clk_freq;
unsigned char tft;
unsigned char rft;
+ bool xfer_done;
+ bool has_32b_bus;
u32 timeout_usecs;
enum i2c_freq_mode sm;
int stop;
struct wait_queue_head xfer_wq;
- bool xfer_done;
int result;
- bool has_32b_bus;
};
/* controller's abort causes */
--
2.43.0
next prev parent reply other threads:[~2026-06-23 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 16:31 [PATCH 0/7] I2C - detailed transfer reporting in case of a fault Dmitry Guzman
2026-06-23 16:31 ` [PATCH 1/7] i2c: add I2C_XFER_V2 - support for detailed transfer reporting Dmitry Guzman
2026-06-23 16:31 ` Dmitry Guzman [this message]
2026-06-24 22:36 ` [PATCH 2/7] i2c: nomadik: optimize layout of struct nmk_i2c_dev Linus Walleij
2026-07-01 13:46 ` Dmitry Guzman
2026-06-23 16:31 ` [PATCH 3/7] i2c: nomadik: do not try to retransmit I2C message series on errors Dmitry Guzman
2026-06-24 22:51 ` Linus Walleij
2026-06-23 16:31 ` [PATCH 4/7] i2c: nomadik: return proper fault codes Dmitry Guzman
2026-06-24 22:53 ` Linus Walleij
2026-06-23 16:31 ` [PATCH 5/7] i2c: nomadik: change print level for fault messages to debug Dmitry Guzman
2026-06-24 22:54 ` Linus Walleij
2026-06-23 16:31 ` [PATCH 6/7] i2c: nomadik: add quirks max_len=2047 and no_zero_len_read Dmitry Guzman
2026-06-24 22:55 ` Linus Walleij
2026-06-23 16:31 ` [PATCH 7/7] i2c: nomadik: add support for I2C_XFER_V2 - detailed fault reporting Dmitry Guzman
2026-06-24 22:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260623-i2c-fault-reporting-v1-2-6db1a8aabf18@mobileye.com \
--to=dmitry.guzman@mobileye.com \
--cc=andi.shyti@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®