From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa2.hc555-34.eu.iphmx.com (esa2.hc555-34.eu.iphmx.com [23.90.104.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E353318ED7; Tue, 23 Jun 2026 16:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.90.104.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782232354; cv=none; b=UPssjuK+uS2W2CuiLfoRhFYLot/7EkVe7SK4Lr0FFEuN/2DEnvAEFjO3xo0eNKNUnN++E64BayVhLMk8RykiotPYJ7spQiuyMH9cJwMf7x3G6UAZ7r1MU5CL4cFxV6mfU+n5gAbAbWZI8LOkD4Ly13+FLUISovuEmlg/h53Zh5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782232354; c=relaxed/simple; bh=oG9nkyldQyyI/7WMBxXQe7MvXPqBKeJkeAmDpqjZ4uc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XtqzOPnvw9l+s70RxKnEKYS7MvgayfRBUHy/BxxIWg3v3uAZgwYb+k16V7nnaStzsNbZ/ZLSvFas066uy6JFqc8FHoki538DCy/Tll/blKoPg+aIDcwjD+eo4weWA/5gajSfWIUgd3yZru2pQc29lrTN5mXr1hX4LR1XdNlPUWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mobileye.com; spf=pass smtp.mailfrom=mobileye.com; dkim=fail (0-bit key) header.d=mobileye.com header.i=@mobileye.com header.b=e3BJ2lt8 reason="key not found in DNS"; arc=none smtp.client-ip=23.90.104.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mobileye.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mobileye.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mobileye.com header.i=@mobileye.com header.b="e3BJ2lt8" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mobileye.com; i=@mobileye.com; q=dns/txt; s=MoEyIP; t=1782232346; x=1813768346; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=oG9nkyldQyyI/7WMBxXQe7MvXPqBKeJkeAmDpqjZ4uc=; b=e3BJ2lt8caDa0mppIzq4EdKLi/uxBqy2cWcPaghqnaVsUaAY5cz4qTCw nxIH42H4Ix41UXpbGTTWc0bneHpQvcRL9U5cvzjzpfF8xepYH/fN6I4bU ET7TMe3F8SSbWHZBUuaWShYsqnHKcs8kWjbqYl8hibhv0G8ehy1rJqKqo qKrhrLS0pt5uiBQ2bSLOAYvVYswdSjJIfOkmbczdUbSlFaDYxx4H0rRN0 EO6GQIyPhZI/gH5aisWKY24Yu100c4r600ydVinzVSGnYAhVuBVaoka6Z ryrHMnsZ4VeqEANb2Rjkv0FPOfEtDD/gAZOCQ4e6dvWch3YuXjP+5LGfe g==; X-CSE-ConnectionGUID: 5B2kRBwMSeKX+fi1EpcMaA== X-CSE-MsgGUID: deDaP7YNSsq3/dALSu54Lw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from unknown (HELO ces01_data.me-corp.lan) ([146.255.191.134]) by esa2.hc555-34.eu.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 19:32:24 +0300 X-CSE-ConnectionGUID: z3gDAWAXRIK5/bfqOX3Iaw== X-CSE-MsgGUID: ZxvTOvUiS3GUK9Xe1gOEaw== Received: from unknown (HELO epgd056.me-corp.lan) ([10.154.54.2]) by ces01_data.me-corp.lan with SMTP; 23 Jun 2026 19:37:34 +0300 Received: by epgd056.me-corp.lan (sSMTP sendmail emulation); Tue, 23 Jun 2026 19:32:23 +0300 From: Dmitry Guzman Date: Tue, 23 Jun 2026 19:31:52 +0300 Subject: [PATCH 5/7] i2c: nomadik: change print level for fault messages to debug Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260623-i2c-fault-reporting-v1-5-6db1a8aabf18@mobileye.com> References: <20260623-i2c-fault-reporting-v1-0-6db1a8aabf18@mobileye.com> In-Reply-To: <20260623-i2c-fault-reporting-v1-0-6db1a8aabf18@mobileye.com> To: Andi Shyti , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Linus Walleij Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dmitry Guzman X-Mailer: b4 0.14.2 i2c-nomadik driver prints error message on every faulted message. This is not a good practice, because in I2C a fault not always is an error, sometimes it is the expected result. For example, scanning bus with `i2cdetects` prints over 100 messages in dmesg (two messages per each target address). To avoid excessive prints in the log, change the print level from err to debug. Signed-off-by: Dmitry Guzman --- drivers/i2c/busses/i2c-nomadik.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index e19ace904e79cd2d83171d9f38fc103a6c5e023b..7d93fb3876dc1324003dd19884e3fd5cbba9cfbb 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -627,7 +627,7 @@ static int write_i2c(struct nmk_i2c_dev *priv, u16 flags) if (!xfer_done) { /* Controller timed out */ - dev_err(&priv->adev->dev, "write to slave 0x%x timed out\n", + dev_dbg(&priv->adev->dev, "write to slave 0x%x timed out\n", priv->cli.slave_adr); status = -ETIMEDOUT; } @@ -661,7 +661,7 @@ static int nmk_i2c_xfer_one(struct nmk_i2c_dev *priv, u16 flags) i2c_sr = readl(priv->virtbase + I2C_SR); if (FIELD_GET(I2C_SR_STATUS, i2c_sr) == I2C_ABORT) { cause = FIELD_GET(I2C_SR_CAUSE, i2c_sr); - dev_err(&priv->adev->dev, "%s\n", + dev_dbg(&priv->adev->dev, "%s\n", cause >= ARRAY_SIZE(abort_causes) ? "unknown reason" : abort_causes[cause]); -- 2.43.0