From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853D535A387 for ; Mon, 22 Jun 2026 21:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782163149; cv=none; b=sC9+53/qtJ1KHhyvtwz1T7azkCI67J/hUqgD3FhJ7ZVklztVdX5CO0sauH8kRERQDtqmkdsjLsiIDyv9Y7K9iJIIw2HlykmtIPvePI0YeX73RBohWRYmKGxVIrQQy49uazKa9GiO3/oSIdwQGoC8aDdEo3fBnk6gcQW8eb2le/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782163149; c=relaxed/simple; bh=ATrTdqo1jlcfQ3mHuUEXHK9/hrNkCyYMvwXtawjP/oA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=ANTKSuSE8jo+HNgeU/LdcPMgOWtBAKTWdfrj/3dCxk/LX1Ym97/G3DqIfA/zh2fkvccU6635IzYJUkJTJbflHE7STOku5KW9OJ/rY/2yf74s0gYzcCm6HNsP5UTdV7YZ3y8VqVczIIZKx2OgP4YcFj8Rwh1Qh2VYDQue+0f5RDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oVXhTpzP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dcmbvoLk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oVXhTpzP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dcmbvoLk" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MJZduc178974 for ; Mon, 22 Jun 2026 21:19:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=jbWnur0UQozabsJp1eS7Fj jSZ9kDV6hLBfR8H71dKkY=; b=oVXhTpzPWyS8DnIR0ZSDgMtKe3m68zHO0HdM2C GJUVZEjE5oOO1sx1yqfha+MMRk7uepuKSwiX7lfx4ezWmioZO17+zLyjNrU2vZdg jps+mjEH83oxu+Y006A1Tq4Fbitg6AX7d9wHdCg3TmaRr6o22I5ZYLODxKMCD82D sTsIRYNnXEy+m7gOTDnxXrWMaFRnmf9/wR4Xef4W9eEXulEJL0Uv2zedaXQNWzRP de3trtraKFECIirHsSSKIeePQw6tAAykA+6qUIOtuSEPmxbwnJqARg0bmZZo4UIN BhJv5WNBLGkK3+9aQ7jxlj/ASfiKv2smfQy+GWPS4XE9NNjQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey2yhtc1y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 21:19:07 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c894c1c4aa9so3102318a12.0 for ; Mon, 22 Jun 2026 14:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782163147; x=1782767947; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=jbWnur0UQozabsJp1eS7FjjSZ9kDV6hLBfR8H71dKkY=; b=dcmbvoLkytF12cK0KU46cH/XNJEU/EHsCg/YBE1lg9ys/V4BJaFKDYWIVv/feCEEP6 DcYTbD6GfZLBghV7ZBPDHefzWJZjIhmmA6rOvCgTat20AR42t5dOV2rSNn7hTx3sy3r+ 2ms7QZYz601WtQx7CUl5VW38UkkoFvWU+VS/hkdvDGFMQK/iOHPzKPlkNSlOjjQZmGbW VrR0kaIGexQbTEQgVjDdHjxTSNf85RdY0aoO79h5dXQ3QTKnM4K2H+PbXVjbxi6EZYwR 28a4Swawie8yuowu3eSoBx97N8asyCNE1HX+IuOkq0h+tv0I6E6DmykxdsUByQ2FKCBw gl3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782163147; x=1782767947; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jbWnur0UQozabsJp1eS7FjjSZ9kDV6hLBfR8H71dKkY=; b=KDNYO0w5gst4TKu/q9y48MK+SKF2ELiDBSXpx1qM9lA4FUEaosCf+NP6XjGApx1Kvv qIGVt/FRLEJtqRJeZTbgJ7/KzjcgFIBFjUxwS3tPfwWJX+Cq9J6kOAo06CG89tt/v/+f OlSr/xpAKcexXtBVWU3ZHVK+4d8YN5V0I0X8eokYkM0inLq6BV8D3eDa0zUz4Qy7MT4j ZYiRAyO467xBcLQfgGufpzQnLTJd3qnWbFcKtDhpBDpmm64t2T1yIBLSPbcqOEX9ocOY 1icemCPo1RJhPZJOKH3VdjHYrkrEkwarDzx5i2a5s9iR1SPjVjL+vAdWJgX+mWzvz1AX COiQ== X-Forwarded-Encrypted: i=1; AFNElJ98AoUokRSZlpxY3F/OzP+1wqJkf117Er1kCHN+rrG0kEVAj2H70+8G7RpQUN6Oqy4cskpCG8Li17fbdoA=@vger.kernel.org X-Gm-Message-State: AOJu0YxvfeKVD8MptXVCVM2mjyz0bd6dl8mYdxNSEhh+JaSQ+Y3SsHud KLXo3rU+vnBKa0nBDDY3W+PnQTero2GrrgjsIIN9ZEOto222/bEPWsADtovlrmuij+2YuRtFbzR /CE9E1hhzvUGfyXAKJJu+uGkFCmlVwY7ixKl2zZNK0ssC84hzri/8lVleRtMBh20/Uns= X-Gm-Gg: AfdE7clsFJAsB0PQBRKwxSb+BDzBdL4NNl0xEjAXQ3p4kLDMoHW7kMVYSHlPWooBNpI Ob75cnnRfsEOEuvoUOqpupAYasNdOSxEKWfotrP1g6qnEsrh5xeaGxumwM7JNuDiUkPNKP7iLUj ACtwCNp4uLvHqahoiTnws6wOoWP5hnP4nzXurfMi9z/zOTvfAfHoC16Lb+aZqyVyi05+Y40SSUY hFGykg9ZK86tvEU0jmIWtOdjfFlPDkk3rt5d1K4qRgXUJcf/yKFHNVIxKiW2Rlx4HkkosV2B0cT 0408yVXX/lgn6JQQZAaE9Cvinz/0WcAAljzToiOPnc4oEHClhIV0Kkq6sm5/XAAG72l5gS1qTxR RIBQI3fkjV1cnJ/MNHO33hpSupVnARJ6evQVsa7+e8H20 X-Received: by 2002:a05:6a21:3299:b0:3b4:7236:1b5 with SMTP id adf61e73a8af0-3bd15169c58mr183617637.26.1782163146806; Mon, 22 Jun 2026 14:19:06 -0700 (PDT) X-Received: by 2002:a05:6a21:3299:b0:3b4:7236:1b5 with SMTP id adf61e73a8af0-3bd15169c58mr183567637.26.1782163146079; Mon, 22 Jun 2026 14:19:06 -0700 (PDT) Received: from hu-ketakish-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8bc374375csm8380733a12.13.2026.06.22.14.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 14:19:05 -0700 (PDT) From: Ketan Date: Tue, 23 Jun 2026 02:48:04 +0530 Subject: [PATCH v3] mm: page_ext: add count limit to page_ext_iter_next to prevent invalid PFN access Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260623-page_ext-v3-1-a89799a5367c@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAIumOWoC/22NUQ+CIBRG/0rjOZyAqOup/9FaQ7woLcVAmc353 wNby4de7na275y7IAdWg0Onw4IseO206QOw4wHJVvQNYF0HRjSleZqTHA+igRvMI2YEFOc847m SKMwHC0rPW+py/bCbqjvIMfpx0Wo3GvvafnkSd99s8ct6gglmhajLlFZEsPJsnEuek3hI03VJO CjWPd35lO58GnzCeJ1JVcmMqj/+uq5v+tUKU/kAAAA= X-Change-ID: 20260616-page_ext-31ef555456fc To: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Luiz Capitulino , David Hildenbrand Cc: kernel@oss.qualcomm.com, stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Ketan Kishore , syzbot@syzkaller.appspotmail.com, Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , David Hildenbrand X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782163140; l=5625; i=ketan.kishore@oss.qualcomm.com; s=20260617; h=from:subject:message-id; bh=ATrTdqo1jlcfQ3mHuUEXHK9/hrNkCyYMvwXtawjP/oA=; b=cZEBwPoANnoLKkmm74TLao3n44k2IM+wtVqqAQ1nadYNuwacQdKggZ9yR3CDkZq3KnSRPMqn8 vm58lo3BWYlBJB38MA+2Qcc+WDVUV4LZvVcFHgl+dImn9QBMDGfK7Z3 X-Developer-Key: i=ketan.kishore@oss.qualcomm.com; a=ed25519; pk=4sb5Ima5x03wc0KSnl57v8kR/7FxMt01+xlZJ53rSJU= X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDIwNiBTYWx0ZWRfX47X4AGggLSmn PcmrCU+iEFYoREpAq+xG7Me+L/rAgp7VgSSyVmbhjPxRbeCK9oN07a3IgAIvgEmJZCQ0wjexXqd 6AoL2vnF45XwsUOw/u8zYOpPARvNxig= X-Proofpoint-ORIG-GUID: FK0LhwsgmU9dy5Gz8ObEMVQcPKOEShcS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDIwNiBTYWx0ZWRfX9F988ck/lFHW hvwgZYEsczChqMEIA1A7IvH+fzcxPfPDDhkgJfEvNSxbLQCnCb0OvPe8vgYeRaOMPzLNte3baxg l1oKDyTZ/SlRxYNu8tq7YCQP4ClLv8HnkcJuVpw4sJG54kDhYj8DBhl53RwRkyfWX8xBFe/c812 kFwISqDa8cww9PZ34Zqbn0B4HCfFwaudA9JogbV+Y/UQX6zL0CsRx3oYCMwrUf9MOrA3Ou2V8E4 19sB/SopfEDexCa/CHKwI4JsbwMIE0LxFqjywxNcyI1TEnqo+MXI6VS26DWSwRw1UWVNifCWzQr mcI1HpQuibPsW9os8XDsTexPchEPbJpe/Ix1oxvbgmg+jhM/GBI1AngYCqMy8Eqin6MF1+N/LAo jCrp/VRBUFr5zBQ2XVma65TcVxpwPMVBCC0W+aZ3v5/dW5EZhs6QKDsMW2kOU21rhv4Uz5KvLLT 42YF3KFbaJrW2Vk131g== X-Proofpoint-GUID: FK0LhwsgmU9dy5Gz8ObEMVQcPKOEShcS X-Authority-Analysis: v=2.4 cv=cKbQdFeN c=1 sm=1 tr=0 ts=6a39a6cb cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=JfrnYn6hAAAA:8 a=hSkVLCK3AAAA:8 a=Z4Rwk6OoAAAA:8 a=1XWaLZrsAAAA:8 a=iox4zFpeAAAA:8 a=37rDS-QxAAAA:8 a=v2oVMEoAPVEBj90iUNMA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=FO4_E8m0qiDe52t0p3_H:22 a=1CNFftbPRP8L7MoqJWF3:22 a=cQPPKAXgyycSBL8etih5:22 a=HkZW87K1Qel5hWWM3VKY:22 a=WzC6qhA0u3u7Ye7llzcV:22 a=k1Nq6YrhK2t884LQW06G:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_04,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220206 The page_ext iteration API does not validate if the PFN still belongs to a valid section while advancing the iterator. When dynamically adding memory in the hotplug path, it can lead to a NULL pointer dereference during page_ext_lookup at the boundary of the last valid section when iterator count equals __pgcount. The for_each_page_ext() macro calls page_ext_iter_next() as its loop increment. for_each_page_ext() does a "__page_ext = page_ext_iter_next(&__iter)" at the end. This causes page_ext_iter_next() to increment iter->index past __pgcount and call page_ext_lookup(start_pfn + __pgcount). During memory hotplug (online), the PFN at start_pfn + __pgcount may belong to a section that has not yet been initialized, causing page_ext_lookup() to trigger a NULL pointer dereference. [ 14.555124][ T846] Call trace: [ 14.555125][ T846] lookup_page_ext+0x6c/0x108 (P) [ 14.555127][ T846] page_ext_lookup+0x30/0x3c [ 14.555129][ T846] __reset_page_owner+0x11c/0x260 [ 14.571201][ T846] __free_pages_ok+0x5e8/0x8e0 [ 14.571204][ T846] __free_pages_core+0x78/0xf0 [ 14.571206][ T846] generic_online_page+0x14/0x24 [ 14.597782][ T846] online_pages+0x178/0x30c [ 14.597784][ T846] memory_block_change_state+0x284/0x32c [ 14.597787][ T846] memory_subsys_online+0x4c/0x64 [ 14.597789][ T846] device_online+0x88/0xb0 [ 14.597791][ T846] online_memory_block+0x30/0x40 [ 14.597793][ T846] walk_memory_blocks+0xac/0xe8 [ 14.597794][ T846] add_memory_resource+0x280/0x298 [ 14.656161][ T846] add_memory+0x60/0x98 Move the iteration boundary enforcement inside the iterator functions, so callers cannot inadvertently access beyond the requested range. Fixes: 9039b9096ea2 ("mm: page_owner: use new iteration API") Cc: stable@vger.kernel.org Suggested-by: David Hildenbrand Suggested-by: Matthew Wilcox Signed-off-by: Ketan Kishore Tested-by: syzbot@syzkaller.appspotmail.com --- Changes in v3: - Fix the iter->index++ increment to pre increment(++iter->index) - modify the (count == 0) check to (!count) - Link to v2: https://patch.msgid.link/20260622-page_ext-v2-1-135d4cfbc42f@oss.qualcomm.com Changes in v2: - Incorporated comments from David and Matthew to check for invalid PFN in page_ext iterator rather than checking for NULL section in page_ext_lookup. - Minor improvement in commit description to include the issue with page_ext_iter_next - Link to v1: https://patch.msgid.link/20260617-page_ext-v1-1-37ad802b1a38@oss.qualcomm.com To: Andrew Morton To: David Hildenbrand To: Lorenzo Stoakes To: "Liam R. Howlett" To: Vlastimil Babka To: Mike Rapoport To: Suren Baghdasaryan To: Michal Hocko To: Luiz Capitulino Cc: kernel@oss.qualcomm.com Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- include/linux/page_ext.h | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/include/linux/page_ext.h b/include/linux/page_ext.h index 61e876e255e8..f23d4b218da0 100644 --- a/include/linux/page_ext.h +++ b/include/linux/page_ext.h @@ -120,14 +120,18 @@ struct page_ext_iter { * page_ext_iter_begin() - Prepare for iterating through page extensions. * @iter: page extension iterator. * @pfn: PFN of the page we're interested in. + * @count: maximum number of page extensions to return. * * Must be called with RCU read lock taken. * * Return: NULL if no page_ext exists for this page. */ static inline struct page_ext *page_ext_iter_begin(struct page_ext_iter *iter, - unsigned long pfn) + unsigned long pfn, unsigned long count) { + if (!count) + return NULL; + iter->index = 0; iter->start_pfn = pfn; iter->page_ext = page_ext_lookup(pfn); @@ -138,19 +142,22 @@ static inline struct page_ext *page_ext_iter_begin(struct page_ext_iter *iter, /** * page_ext_iter_next() - Get next page extension * @iter: page extension iterator. + * @count: maximum number of page extensions to return. * * Must be called with RCU read lock taken. * * Return: NULL if no next page_ext exists. */ -static inline struct page_ext *page_ext_iter_next(struct page_ext_iter *iter) +static inline struct page_ext *page_ext_iter_next(struct page_ext_iter *iter, + unsigned long count) { unsigned long pfn; if (WARN_ON_ONCE(!iter->page_ext)) return NULL; - iter->index++; + if (++iter->index >= count) + return NULL; pfn = iter->start_pfn + iter->index; if (page_ext_iter_next_fast_possible(pfn)) @@ -183,9 +190,9 @@ static inline struct page_ext *page_ext_iter_get(const struct page_ext_iter *ite * IMPORTANT: must be called with RCU read lock taken. */ #define for_each_page_ext(__page, __pgcount, __page_ext, __iter) \ - for (__page_ext = page_ext_iter_begin(&__iter, page_to_pfn(__page));\ - __page_ext && __iter.index < __pgcount; \ - __page_ext = page_ext_iter_next(&__iter)) + for (__page_ext = page_ext_iter_begin(&__iter, page_to_pfn(__page), __pgcount); \ + __page_ext; \ + __page_ext = page_ext_iter_next(&__iter, __pgcount)) #else /* !CONFIG_PAGE_EXTENSION */ struct page_ext; --- base-commit: c425609d6ac4012c8bbf01ec2e10e801b1923a7b change-id: 20260616-page_ext-31ef555456fc Best regards, -- Ketan Kishore