From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 298761E832A for ; Tue, 23 Jun 2026 09:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205546; cv=none; b=UrcrodiND90mae4beB0IOgFLb4G6/c9FKThmrO6LRXLThIatgrVAnCsHZ2uqrKdxXROF58MJQShk2KGeQyV3hx0AY0cYLwK9j1qXvVG6WZ0mloMK2ivkTmDvlXyGzkn1IB7V1egmICUkTFVUETPkLhSN3J+pQVHvoyEQ/t2Lg5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205546; c=relaxed/simple; bh=tJ/lhsd06ekkim7NuWPjso8G4mEd5kfe/sEuS+RJYUk=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=EFhScB3qQmpFGjJxsAC9Vkv5d0G/jLONGS8eI5lzgvzIGkK6xSODB3Fia9IXX7JOZcFzBS/60NArQVOPwb/sg7tA5SalzJCA8fRYUUuDCvYAez2L0qHTT3UNueDj3MCYgFG0rC9Af1N8ZD07azfgloAnMRxgrqTavxkXwLCUXw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=e2n0UOx9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JBA7+Eod; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="e2n0UOx9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JBA7+Eod" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N8Ux9G3244161 for ; Tue, 23 Jun 2026 09:05:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=gEjSX4RAO8IgOrvx6tsw4d OpUHRVql3aBZzMOZKH1aA=; b=e2n0UOx93tYBQxtyNWmMGtfcX61PmMMwLPuhWT jF5DTmsp99xxVzjgDFGdgNTf9LPR0Ca0Fn3tQ1jGFzO7mDZpvwh0kRi6UQtXPDhF Fk4fMoRUMzosteD0dv1U1WdHadSo2qsmEEL0OKkciU56xoHhX+tV0dWhE9W+t8m6 /OHndnKO8d9IwEnu5L3rVwiNaopgsX+P3I90Dm1at0gSN9CT3sFZhynDvJQtw5pW 8rp/uv9biCo2524hqxZb6sFq0Bi5iWQgqvBCDe5G+OyTWvgj23LupsWFlE8fPvef RZtqCtR5pMgH0pC/Xomb0qsxsJSTBgcNlET00B6agSXcGZgg== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyppyg44w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 09:05:43 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-30bccca5620so7428019eec.1 for ; Tue, 23 Jun 2026 02:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782205543; x=1782810343; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=gEjSX4RAO8IgOrvx6tsw4dOpUHRVql3aBZzMOZKH1aA=; b=JBA7+Eodz3TC6HA7cUF5F1HFOj/MGI5V/mjAD52f0s2cm7Tlbetb6O1hte5qlCboMb n8G9mz+JHT71nMxGdnc51VC18+purZGXGQedCpR2YKeOm2fywkOvZPjTcpogvFYuqHYG my+KetMQ0Jnqb31b5Po9PsSQLa5VsLjq47ZHX0ms1Yf08AVuvfAD86vvFFrluYsLl75o xIs2drPZhOTEoQI4Bha3BH5eHRyShrgmAkwySV881qA3XKeQ5Ai8Vgrznehr2CP8woy6 RvXcvfRDEXYTzUfmS071KQVvms1pHXmGmsBFIqiWk6q3wjYbwYYkwKLU0P+RBZ/IKRd5 1yGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782205543; x=1782810343; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gEjSX4RAO8IgOrvx6tsw4dOpUHRVql3aBZzMOZKH1aA=; b=lMK/InKPCWbn+LgamynSZn0CJQXLOwHQoP4xlQtcXsx0ul6mnyryAKwA0D+Z0UTgjz kFUraTXgBPGGNYhGehdzxFXekuM6/N2ku4cIFwbPSNa8Sg2IgJHgS2Mv97Nf8+vl+eGH t67tSkGFojfX2Rl2YCxW5HmyGjaohD+KLcrdguv/peOaf2BL8W+VxyLVmYBIRS0qeDg2 9mHrGXDJHfaZ/VaOEhsV6Fk8XjipPUyyJBSEfH1jK99P2bKM4ic2QGYu3oSMkUbrdz+I q4uos0kqGlMly35FEnPnsoJsVEtU9Wpruc9WDsxeSDKOwxPEhTp82G+EbsECBViZUfoG F2dg== X-Forwarded-Encrypted: i=1; AHgh+RrbNfH7RwWwi1ja6Zecc9GmXXFjCpK2uqZVKU2WXZaRNT00aidM7VlLsis8yokOv41Ma8oM2GE0daOBJnM=@vger.kernel.org X-Gm-Message-State: AOJu0YwGj/vogaQIBWfp3+loZUGubhNh33lbCnTkeRi1ieiigIVeCqPz mTnx83zisnMICBxZ+NJFp6eQJB1VXA0MVVgGw3KblWV6HFfkjCaCIbKXlonnalqk2S2VMc2Bypl 1fGPtsSES9Nv1tsxRxlDrH2xj5IKRirGa65Lm3bV1mEjc1VzcYHacMwyyGp+67yvk3Po= X-Gm-Gg: AfdE7cmwFo+MgH0ubn0yCfV9XwbW4edaaROyWsR19mAd5y6sfZuKNSi0PdSUX+zxhtz 8YxDuCnotuYnLbNYuj3GIZueS4C1Iae9vY6FuWGXTpuV4mgCfBexT66nlfRW2IYYxQapLRE2YmV GaFQqUD8haELXdllq3SdBRfFmT8EmvekEt84z2tHKzCDpzg0N4xcCtJB6cmwVzjLrnS2O1+3qLd kwHGmvfS/BWHqohilOM/x4bIBYpUFwgjKNfoPmAMNhZFyLgQjAxHk0I80s0j8fnYL84Oh1j5Kse UXsXo3oX5wuUg90r82sE0HijqZ4/V/qH0DuLeE3lJ6ObOWCunJv6skxD8TY5nk0sXBX1hTIyUTH 55zhMRdi0mduis/+6jPUCyeSZBLbbiH7JacEyOXLLEpbQhMQrGpg/DpVKl0CeEA== X-Received: by 2002:a05:7300:1341:b0:303:f2dc:8ab4 with SMTP id 5a478bee46e88-30c06e0e40bmr11902142eec.2.1782205542648; Tue, 23 Jun 2026 02:05:42 -0700 (PDT) X-Received: by 2002:a05:7300:1341:b0:303:f2dc:8ab4 with SMTP id 5a478bee46e88-30c06e0e40bmr11902121eec.2.1782205542115; Tue, 23 Jun 2026 02:05:42 -0700 (PDT) Received: from hu-jingyw-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c1be5c5desm15202122eec.28.2026.06.23.02.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 02:05:41 -0700 (PDT) From: Jingyi Wang Subject: [PATCH v3 0/3] remoteproc: improve robustness for rproc_attach fail cases Date: Tue, 23 Jun 2026 02:05:33 -0700 Message-Id: <20260623-rproc-attach-issue-v3-0-8e24310707ce@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAF1MOmoC/22NwQ6CMBBEf4X07JK2hIqe/A/DYSmLbSIUu0A0h H+34NXLJC+ZmbcKpuiJxTVbRaTFsw9DguKUCetweBD4NrHQUhtpdAFxjMECThNaB555JkCJLXa oZdFUIg3HSJ1/H6f3OnGDTNBEHKzbr6RRZq85z1OIn0O9qL38s5Tq8s+yaJBgERVhdy5lpW6BO X/N+LSh7/MUot627Qtryisg0gAAAA== To: Bjorn Andersson , Mathieu Poirier Cc: aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Jingyi Wang X-Mailer: b4 0.15-dev-3d134 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782205541; l=1316; i=jingyi.wang@oss.qualcomm.com; s=20250911; h=from:subject:message-id; bh=tJ/lhsd06ekkim7NuWPjso8G4mEd5kfe/sEuS+RJYUk=; b=Sgx10XD+tppToJkDvfASwTn7BlAFut76Dp8fDmEU1SzLMhj6xulm3q5Ww1OXUbBbCb5hW3+n+ xwP5GEulA7FDMNlZeCpc6ulJcmSCE/d7DXMYKkMhT9W8AnE8L7d1voi X-Developer-Key: i=jingyi.wang@oss.qualcomm.com; a=ed25519; pk=PSoHZ6KbUss3IW8FPRVMHMK0Jkkr/jV347mBYJO3iLo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA3MiBTYWx0ZWRfX9kq/fH+WaQX0 Dkmpg5iE8p0RNXQKdSUpHoKETi4vZqcgo27rKkYPHVG5Ny0wVohDXWiHa/0qPvRhEi98OScUrRl Ih6fJ1Kjj5739BJPFbUtCphnBgzeRKYIQ59Xn/sWTBsGtfXB/bV3jEg4m9LJALczwknWS+fJBgF o12q94lRX7wVxD8sGY5CpfP1bMh2qF5DwOPivK7Xp5Y/75zdy1/BuDvHbhN9dpcdcEC6tYMKxri 3RflS5p8B9+utANlKUW53+sc6tdaWtYAw2wOO1qAZ5LXaJqZVpe+t7FeDXYsEq5bTmS/Gs19jnX CR2M/kZesfdyC4ybveellf6yLesMN8GMoreVvVdB3+ZwPr1v+nCgf/WuncLBBf8q45slHooKca2 KdtAcdxYDmfAKIkY+HuAToEyQOXxssPniY67vfxRmqLHpEJxi+PQd5WBtYFUHliiOXyS3fbq2bF nvLM761SoPLR6Xuw0gA== X-Proofpoint-GUID: r1JGmf_e22b9ejzQ8hM9L8XWsR5VWMrJ X-Authority-Analysis: v=2.4 cv=dvfrzVg4 c=1 sm=1 tr=0 ts=6a3a4c67 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=-wlysWeROCUhhefnZiMA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA3MiBTYWx0ZWRfX8DJbRcbcw/AK dySdbFTXuLDCpCgvVE15Oru7Kii5pdLLEPSGXPev+QAQm9rPuWwyjHCVLNyGWTFqTQP22MlN/nn wubs9IIre5itS8Nit249yw9ovlyp1vc= X-Proofpoint-ORIG-GUID: r1JGmf_e22b9ejzQ8hM9L8XWsR5VWMrJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230072 Failure in rproc_attach() path can cause issues like NULL pointer dereference when doing recovery and rproc_add() fail, improve the robustness for rproc_attach fail cases. Signed-off-by: Jingyi Wang --- Changes in v3: - update and check subdevs_started flag in rproc_start_subdevices()/rproc_stop_subdevices() - Link to v2: https://lore.kernel.org/r/20260519-rproc-attach-issue-v2-0-caa1eaf75081@oss.qualcomm.com Changes in v2: - commit msg update - Introduce subdevs_started flag instead of check nullptr - Add change to cancel crash_handler work - Link to v1: https://lore.kernel.org/r/20260409-rproc-attach-issue-v1-0-088a1c348e7a@oss.qualcomm.com --- Jingyi Wang (3): remoteproc: core: Attach rproc asynchronously in rproc_add() path via schedule_work() remoteproc: qcom: Check subdev start status in rproc_stop() remoteproc: core: cancel crash_handler work in rproc_add() error path drivers/remoteproc/remoteproc_core.c | 28 ++++++++++++++++++++-------- include/linux/remoteproc.h | 4 ++++ 2 files changed, 24 insertions(+), 8 deletions(-) --- base-commit: 4fa3f5fabb30bf00d7475d5a33459ea83d639bf9 change-id: 20260623-rproc-attach-issue-a0adafa203b8 Best regards, -- Jingyi Wang