From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 652902C21E6 for ; Tue, 23 Jun 2026 09:05:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205547; cv=none; b=b9qhT8+0nni6+AiaZTvob3yBshOuwWQ1YjhnDhai8vijLPClPnD4SSRqjFfmB7L+TQ9vPbiUqe95dZgU7qVF4u+wf0T+x6uNZAQOfSKJ3fxP0usCZ6HKVRpNBQlR6Ot+w5CPVwozAmhO6Z7tBSk2jVKYAny0fSq9hV8s7w1VBRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205547; c=relaxed/simple; bh=4zraT7CC6EN+bGQODjtV6ZifYWiE0anAhrLQwhBKLBA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mw+3X2DuztCaEdatu9Wfbx0Vj107e8jDtQXEnCVhRXOrsU7PJxYknA++Io2LFv2A8373jMd0UpinIbCsHaAi7m2tET7KHsoceMnfodltdTkOtPIOJe+Iopx67rZg8r6RnUFwJ9bAG0a6ZBeVcsRDwBmqvFk10x4al9h5wvaRkRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ps2r7nCb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GsI9AfEl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ps2r7nCb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GsI9AfEl" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N8UubI3243384 for ; Tue, 23 Jun 2026 09:05:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CE8klnNfmiQMHcUZgP80frOuN8UU/IWTyTQkre0op6Q=; b=Ps2r7nCbGKc+LVI+ lh6dI0mdTb/1vXTu7jpBs1p2QDWsjlNP501XAYT5e5zoBRZdYZCSGgsQmvdCwo9W dOFmZST1jfeBBPAPQI1taSS/bhOkAw6oUqkin4mjHZcFYGpBpIL/YcwJ8VVL1Z7Q bUbzPS7frLwe9+Ek3CJA0sXY2mMcFt4As2Y/4e4U4fYz6bea6+VeWHqPhwG8bzmR hbN5TUhicFNjjRvPGnPU0/936E+PvFz9jI9/nkohMrpjhFraDmpJ4+C4VDnjghr9 3EAX7px4rkV/dkIS8sbm39QHzwu69iXIFDATFZ+32RVaGojRAiObVO6vnhqdT1+Y gOxJWQ== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyppyg457-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 09:05:45 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-30c5978b108so767487eec.1 for ; Tue, 23 Jun 2026 02:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782205545; x=1782810345; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CE8klnNfmiQMHcUZgP80frOuN8UU/IWTyTQkre0op6Q=; b=GsI9AfElrOB1vFkrKFpgpROQRkLjPUQwSeMpvcDzqta+P9iu5zljxDYXWbqX1p5wcp owT6bnJHxMQPRUsGe3oqKBYkOp4e9AiU05kf6S8qga7Q++r54F5gEyA0v7Kp3vNXeFaw bVmD7IWKoMAUg3r42OtYRV7P5Dfsxws6sSa8Hjg98umRj0dk40sxAD0VFCmDwqzDbgVf 3kzPUVw3o+Y4u0t/ZZRQgLWfyGPLbaJJ3IVNgeUkMnaEreQy+6F+EeIIrl0B+oimGmlR OsIoDYbFYHBDNe4EqbjJSCyhsDBMLNomh0AmqqKNP+NvF67SSEkX2iDCDWWuhP+u9yMO nBzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782205545; x=1782810345; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CE8klnNfmiQMHcUZgP80frOuN8UU/IWTyTQkre0op6Q=; b=bOY2mgxEQZxRNZD2vdW21ORTNTgr1qN5ZwvbIXm/70AE6d+sXKRIw5/+zJQ+GB+DzE TYnQem8qzP7IqNktqkDbSbw3wcjo8+Ct2kTHIFA1WTck8ZVayhk85OGgJXhV92v7dozc KdXj+NrfoxasQ6htXcsrZiGRJpPxDpzafH/+MmThBT5lbV/1ITfo5PJnlaGv6Ei/V9AH zUUH2vntFw+7N0+2IhNAznUNYfQ4XEvJqpie04KlNkMpbXNbTjnviTzrWWgo59No+pCV p539myQ3v5kgIdvUOWEtTpe8ich3DyLNq8e/YUrgHGDSrNXYhHvEeV9Be8byFN+Z13VH PKQw== X-Forwarded-Encrypted: i=1; AHgh+RrHqPcWkK7W+Nsafn3xkyYo6CMjM4DDdw9tauUdv8yi6c5MeXmmulz/tYcTo5Icguo3v5NeGt/QErX8ZLc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1qfsQg7lFJWVh5dLHSLgd25xTywB1iapOmVn2M5KkCOIxJm2W rvGi+hr1090xzVnNJP0EYLMDZ9TSwWKB2JoVP/vo1yeXK2K6HXi5AOt3JtgfK9F00LshQ7FdWpG wn+8patuTPYgRJbY+cnE5dS7FQn115VY7Hap3coVGTB57Hm83iVTZWrhS2plLcXUp/N4= X-Gm-Gg: AfdE7ckLnBCsLenHFqI/21QiVxUjmGyaRPj9I4LZTTEk8rSeQUXPruxu0+emPSfgknL nzxaaw2PXNX2E0gvRkV562tXy9JR2Zq+VjLk6JEU/gGbYpMXDFOrMxspnnFldEwLQXETqTUXjnK r1wo490oA2vjpF3UW0Jz/6n+g69vNPlN571KUYPzY9XUWNsOwi5VC9sppS08kSaV+ej5H5BZxqG rBPxvUIfseT39VJhuAn5Un7R2LmCPC1EguvN9XGYo0nsOv3dGp3yoStPvdgJsvIT4uL+NBP1q2t /U4lodB8IAh2G9a8+8HRgyYOpv7O43VSicedQte/ofZeEaanvVku2pMo1pssocTu1FZkXA+SqWe Q1ASkZaa6z/PYfssbf1deLCAdaH3NEO0TILNw/YKigCP6hfDwd12crCeARBlBHQ== X-Received: by 2002:a05:7300:3b2b:b0:30b:c40f:de0c with SMTP id 5a478bee46e88-30c5b774099mr1237252eec.10.1782205545167; Tue, 23 Jun 2026 02:05:45 -0700 (PDT) X-Received: by 2002:a05:7300:3b2b:b0:30b:c40f:de0c with SMTP id 5a478bee46e88-30c5b774099mr1237224eec.10.1782205544582; Tue, 23 Jun 2026 02:05:44 -0700 (PDT) Received: from hu-jingyw-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c1be5c5desm15202122eec.28.2026.06.23.02.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 02:05:44 -0700 (PDT) From: Jingyi Wang Date: Tue, 23 Jun 2026 02:05:36 -0700 Subject: [PATCH v3 3/3] remoteproc: core: cancel crash_handler work in rproc_add() error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260623-rproc-attach-issue-v3-3-8e24310707ce@oss.qualcomm.com> References: <20260623-rproc-attach-issue-v3-0-8e24310707ce@oss.qualcomm.com> In-Reply-To: <20260623-rproc-attach-issue-v3-0-8e24310707ce@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier Cc: aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Jingyi Wang X-Mailer: b4 0.15-dev-3d134 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782205541; l=703; i=jingyi.wang@oss.qualcomm.com; s=20250911; h=from:subject:message-id; bh=4zraT7CC6EN+bGQODjtV6ZifYWiE0anAhrLQwhBKLBA=; b=LeJEQceLCn/IKxdZny8csHhDo53GXgO8hlOPYDWFqSJOQvb3feCqBGvuyJTwlH6g/EzwPkyRV 0+GYzeN48ViDk9QaitNYGInjXfPuMEpjlLqljQzEA70CSzo2rTBm2SW X-Developer-Key: i=jingyi.wang@oss.qualcomm.com; a=ed25519; pk=PSoHZ6KbUss3IW8FPRVMHMK0Jkkr/jV347mBYJO3iLo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA3MiBTYWx0ZWRfX3CJA0kOVcs8W ueh5g09a/JRCiVz/uxM3i8KBNXx7T6xdtXnLZoqEnn+v+bv74UYE9UqpKfyJKvwlf2srlCbmEh2 Gb+ze9a9YWTyZqQpc7ZdBEh9sV/DjAtTN+Qc+h1EzK6bMmSrrR3f6LEXcCt/BO+4eDQxj3tB4GR EB+w4rii7QEBwPYaVyjQL+Wkl8+hlySRDcp2yqE7gbo2/sUKDa3/RS4U4vmzWieFGHvgllocicR jaRiuy6rG/z7t0AeovIXrG+ulAZWlWXffflkJvMvNZ+K5Rl2rLb+R9Nr/2Q0lY7trhzzEUpRNOZ In1EHh7IzMxY9lbhe9vNeWJe29AlDy/eepfNubjyt+i+eG8sMVkn+AQ7Ab9Omr8wTNUzO3AEXqo CBHTjoAURXn9Adp/7JX6Xus+Fw96zUX6zuh8/PZVdNVdw/cbBe1/ATMNpNrUrKnFmgWKE3lWaxr x6uu2PHSKLEyJZmvNcw== X-Proofpoint-GUID: TKvIlz56SQWESO2rTt91bRp28joaL4f2 X-Authority-Analysis: v=2.4 cv=dvfrzVg4 c=1 sm=1 tr=0 ts=6a3a4c69 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=VRyQhUk9NtpfCekB4XAA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA3MiBTYWx0ZWRfX45D3LwfqrTcs fLKXbVWT8CgJ3QA+cTInvHkXkwBh9ixvgmSTnIF520r1ejgc3sVvUSAZA7YkFe7D87j+aqv2mjc yxO6ba78UgQQ79piJEVq5FL6sQqgGq4= X-Proofpoint-ORIG-GUID: TKvIlz56SQWESO2rTt91bRp28joaL4f2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230072 Ensure crash_handler work is cancelled before tearing down rproc resources to avoid accessing freed memory. Signed-off-by: Jingyi Wang --- drivers/remoteproc/remoteproc_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 71a7be7c1e9f..ae885afc618d 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -2327,6 +2327,7 @@ int rproc_add(struct rproc *rproc) return 0; rproc_remove_dev: + cancel_work_sync(&rproc->crash_handler); rproc_delete_debug_dir(rproc); device_del(dev); rproc_remove_cdev: -- 2.34.1